Title: Remove the need for a timeout in smoke test for font loading by mgrandrath · Pull Request #6 · jamesshore/lets_code_javascript · GitHub
Open Graph Title: Remove the need for a timeout in smoke test for font loading by mgrandrath · Pull Request #6 · jamesshore/lets_code_javascript
X Title: Remove the need for a timeout in smoke test for font loading by mgrandrath · Pull Request #6 · jamesshore/lets_code_javascript
Description: I wired up the font loading events to PhantomJS. The callback onInitialized is called before the page is loaded (especially before the IIFE with the TypeKit boilerplate is executed). It defines callbacks for fontactive and done in the browser's global namespace. The loaded fonts get stored in a local array. When done is called PhantomJS is notified via callPhantom (which is provided by PhantomJS). callPhantom triggers page.onCallback with the collected fonts array as argument (Note: only serializable data can be exchanged this way). On the client side, the callbacks that are defined via PhantomJS are assigned to the config object (or a no-op function if they are undefined, which will be the case outside of the smoke test). Remaining problems The test does not feel terribly faster. I don't know if there are any PhantomJS settings or other tweaks that would improve this. The call to phantom.exit() is now within onCallback which is less than ideal. Either should there be a mechanism for collecting asynchronous test results or each test should go into its own file. The former is probably better for performance (because of spawning less processes) while the latter is generally simpler and makes it easier to organize the tests.
Open Graph Description: I wired up the font loading events to PhantomJS. The callback onInitialized is called before the page is loaded (especially before the IIFE with the TypeKit boilerplate is executed). It defines ca...
X Description: I wired up the font loading events to PhantomJS. The callback onInitialized is called before the page is loaded (especially before the IIFE with the TypeKit boilerplate is executed). It defines ca...
Opengraph URL: https://github.com/jamesshore/lets_code_javascript/pull/6
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:bb46fc2b-41de-a852-e233-b9c264d7bb52 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A440:6B47E:57B0EA:7307DA:69921560 |
| html-safe-nonce | 02a887250b43faad69b93287bc55e00c2e8e82c6716ff2ea1c8efaf98f2a20c1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDQwOjZCNDdFOjU3QjBFQTo3MzA3REE6Njk5MjE1NjAiLCJ2aXNpdG9yX2lkIjoiNDE0NjA2ODE2NDY2NzY0MzIzMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 041888856f42c7b9d1269615f9e59008f039a6a03b4f69b1d8363dc9f1a2964e |
| hovercard-subject-tag | pull_request:25169149 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/jamesshore/lets_code_javascript/pull/6/files |
| twitter:image | https://avatars.githubusercontent.com/u/399903?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/399903?s=400&v=4 |
| og:image:alt | I wired up the font loading events to PhantomJS. The callback onInitialized is called before the page is loaded (especially before the IIFE with the TypeKit boilerplate is executed). It defines ca... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/jamesshore/lets_code_javascript git https://github.com/jamesshore/lets_code_javascript.git |
| octolytics-dimension-user_id | 123129 |
| octolytics-dimension-user_login | jamesshore |
| octolytics-dimension-repository_id | 4981757 |
| octolytics-dimension-repository_nwo | jamesshore/lets_code_javascript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 4981757 |
| octolytics-dimension-repository_network_root_nwo | jamesshore/lets_code_javascript |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width