René's URL Explorer Experiment


Title: Logging setup violates best practices · Issue #27 · ipdata/python · GitHub

Open Graph Title: Logging setup violates best practices · Issue #27 · ipdata/python

X Title: Logging setup violates best practices · Issue #27 · ipdata/python

Description: I just ran into an issue when adding ipdata as a library used by my project that the log outputs I received suddenly changed formatting. Upon digging into the issue, I found that the ipdata library calls logging.basicConfig to set a Rich...

Open Graph Description: I just ran into an issue when adding ipdata as a library used by my project that the log outputs I received suddenly changed formatting. Upon digging into the issue, I found that the ipdata library...

X Description: I just ran into an issue when adding ipdata as a library used by my project that the log outputs I received suddenly changed formatting. Upon digging into the issue, I found that the ipdata library...

Opengraph URL: https://github.com/ipdata/python/issues/27

X: @github

direct link

Domain: patch-diff.githubusercontent.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Logging setup violates best practices","articleBody":"I just ran into an issue when adding ipdata as a library used by my project that the log outputs I received suddenly changed formatting. Upon digging into the issue, I found that the ipdata library calls logging.basicConfig to set a RichHandler instance for the root logger if one is not otherwise defined.  It then writes its logs to a logger named \"rich\".\r\n\r\nThis violates several of python's best practices regarding configuring logging within a library: https://docs.python.org/3/howto/logging.html#configuring-logging-for-a-library\r\n\r\nIn particular, the issue that is causing problems for my application is that the app does not define any handlers on the root logger, but when we started using ipdata, all of a sudden logs from all of our 3rd party libraries were showing up in our log and in strange formats, resulting in further downstream frustrations.\r\n\r\nTo be compliant with python best practices, I believe that the logging.basicConfig call should be removed from the ipdata library and the logger name used by the library should be updated to `__name__ `.","author":{"url":"https://github.com/mdecuir","@type":"Person","name":"mdecuir"},"datePublished":"2023-11-07T14:03:47.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/27/python/issues/27"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:11701c97-a3cb-3b05-6173-533d1d96a5e9
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id84CA:181429:B1CEC0:FE4197:6978C77D
html-safe-nonceacb812c8fdf23f042b8bf36ad7fe0be093edbd8677fab0ff7cf6a8659318de70
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NENBOjE4MTQyOTpCMUNFQzA6RkU0MTk3OjY5NzhDNzdEIiwidmlzaXRvcl9pZCI6IjQ3Mzc4OTg1NjQ4MTIzMjY3ODEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8a6060299e5f00f82f89d46e203042f4062d8796d09c64e30616fa6774a3e81c
hovercard-subject-tagissue:1981440828
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/ipdata/python/27/issue_layout
twitter:imagehttps://opengraph.githubassets.com/4ee4689136d05b602c469d8e647f1caad810b92445a9c28c09b4d1413bc7b0c3/ipdata/python/issues/27
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4ee4689136d05b602c469d8e647f1caad810b92445a9c28c09b4d1413bc7b0c3/ipdata/python/issues/27
og:image:altI just ran into an issue when adding ipdata as a library used by my project that the log outputs I received suddenly changed formatting. Upon digging into the issue, I found that the ipdata library...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemdecuir
hostnamegithub.com
expected-hostnamegithub.com
None8a71ca1f7ab5436216e1df86f398ef7a51ed3152c90e3f7332fc70cf97fcb9d6
turbo-cache-controlno-preview
go-importgithub.com/ipdata/python git https://github.com/ipdata/python.git
octolytics-dimension-user_id33085067
octolytics-dimension-user_loginipdata
octolytics-dimension-repository_id108238848
octolytics-dimension-repository_nwoipdata/python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id108238848
octolytics-dimension-repository_network_root_nwoipdata/python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseeaed570eead52a9920afef75dc3eb6d826fdc5ef
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/ipdata/python/issues/27#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fipdata%2Fpython%2Fissues%2F27
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fipdata%2Fpython%2Fissues%2F27
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=ipdata%2Fpython
Reloadhttps://patch-diff.githubusercontent.com/ipdata/python/issues/27
Reloadhttps://patch-diff.githubusercontent.com/ipdata/python/issues/27
Reloadhttps://patch-diff.githubusercontent.com/ipdata/python/issues/27
ipdata https://patch-diff.githubusercontent.com/ipdata
pythonhttps://patch-diff.githubusercontent.com/ipdata/python
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fipdata%2Fpython
Fork 6 https://patch-diff.githubusercontent.com/login?return_to=%2Fipdata%2Fpython
Star 19 https://patch-diff.githubusercontent.com/login?return_to=%2Fipdata%2Fpython
Code https://patch-diff.githubusercontent.com/ipdata/python
Issues 7 https://patch-diff.githubusercontent.com/ipdata/python/issues
Pull requests 0 https://patch-diff.githubusercontent.com/ipdata/python/pulls
Actions https://patch-diff.githubusercontent.com/ipdata/python/actions
Projects 0 https://patch-diff.githubusercontent.com/ipdata/python/projects
Security 0 https://patch-diff.githubusercontent.com/ipdata/python/security
Insights https://patch-diff.githubusercontent.com/ipdata/python/pulse
Code https://patch-diff.githubusercontent.com/ipdata/python
Issues https://patch-diff.githubusercontent.com/ipdata/python/issues
Pull requests https://patch-diff.githubusercontent.com/ipdata/python/pulls
Actions https://patch-diff.githubusercontent.com/ipdata/python/actions
Projects https://patch-diff.githubusercontent.com/ipdata/python/projects
Security https://patch-diff.githubusercontent.com/ipdata/python/security
Insights https://patch-diff.githubusercontent.com/ipdata/python/pulse
New issuehttps://patch-diff.githubusercontent.com/login?return_to=https://github.com/ipdata/python/issues/27
New issuehttps://patch-diff.githubusercontent.com/login?return_to=https://github.com/ipdata/python/issues/27
Logging setup violates best practiceshttps://patch-diff.githubusercontent.com/ipdata/python/issues/27#top
https://github.com/mdecuir
https://github.com/mdecuir
mdecuirhttps://github.com/mdecuir
on Nov 7, 2023https://github.com/ipdata/python/issues/27#issue-1981440828
https://docs.python.org/3/howto/logging.html#configuring-logging-for-a-libraryhttps://docs.python.org/3/howto/logging.html#configuring-logging-for-a-library
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.