Title: Rethink slf4j packaging · Issue #8 · ipdata/java · GitHub
Open Graph Title: Rethink slf4j packaging · Issue #8 · ipdata/java
X Title: Rethink slf4j packaging · Issue #8 · ipdata/java
Description: Hello ipdata team, We have a build problem regarding the usage of your library: ipdata uses the "Simple Logging Facade for Java (SLF4J)" for encapsulating logging. This is of course fine to be flexible for using different logging framewo...
Open Graph Description: Hello ipdata team, We have a build problem regarding the usage of your library: ipdata uses the "Simple Logging Facade for Java (SLF4J)" for encapsulating logging. This is of course fine to be flex...
X Description: Hello ipdata team, We have a build problem regarding the usage of your library: ipdata uses the "Simple Logging Facade for Java (SLF4J)" for encapsulating logging. This is of course fine ...
Opengraph URL: https://github.com/ipdata/java/issues/8
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Rethink slf4j packaging","articleBody":"Hello ipdata team,\r\n\r\nWe have a build problem regarding the usage of your library: ipdata uses the \"Simple Logging Facade for Java (SLF4J)\" for encapsulating logging. This is of course fine to be flexible for using different logging framework.\r\n\r\nBut the \"unwanted\" thing is that ipdata has a direct dependency to slf4j-log4j12 (Log4J). We do not use Log4j and had to exclude this dependency in pom.xml:\r\n\r\n```\r\n \u003cdependency\u003e\r\n \u003cgroupId\u003eco.ipdata.client\u003c/groupId\u003e\r\n \u003cartifactId\u003eipdata-java-client\u003c/artifactId\u003e\r\n \u003cversion\u003e0.2.0\u003c/version\u003e\r\n \u003cexclusions\u003e\r\n \u003c!-- Exclude Log4J binding because slf4j-jdk14 is defined in project --\u003e\r\n \u003cexclusion\u003e\r\n \u003cgroupId\u003eorg.slf4j\u003c/groupId\u003e\r\n \u003cartifactId\u003eslf4j-log4j12\u003c/artifactId\u003e\r\n \u003c/exclusion\u003e\r\n \u003c/exclusions\u003e\r\n \u003c/dependency\u003e\r\n```\r\n\r\nPlease refer to the slf4j [documentation](https://www.slf4j.org/codes.html#StaticLoggerBinder):\r\n\r\n\u003e Embedded components such as libraries or frameworks should not declare a dependency on any SLF4J binding but only depend on slf4j-api. When a library declares a compile-time dependency on a SLF4J binding, it imposes that binding on the end-user, thus negating SLF4J's purpose. When you come across an embedded component declaring a compile-time dependency on any SLF4J binding, **please take the time to contact the authors of said component/library and kindly ask them to mend their ways**.\r\n\r\nCan you please investigate whether to leave out this dependency?\r\nIn our opinion this can be done backward compatible: If slf4j doesn't find a logger implementation it will fallback to the no-operation logger and will trace out the following warning:\r\n```\r\nSLF4J: Failed to load class \"org.slf4j.impl.StaticLoggerBinder\".\r\nSLF4J: Defaulting to no-operation (NOP) logger implementation\r\nSLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.\r\n\r\n```\r\nThank's for your support!","author":{"url":"https://github.com/norbertroamsys","@type":"Person","name":"norbertroamsys"},"datePublished":"2023-03-21T07:47:11.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/8/java/issues/8"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:85e384ad-5db8-5f35-d823-eef46fc46cad |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D624:20A8F8:BF1D0A:10F1882:6978C866 |
| html-safe-nonce | bff40e938839f325705d2840ee594e06907e738aefe2974af846f1d50f1525cf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjI0OjIwQThGODpCRjFEMEE6MTBGMTg4Mjo2OTc4Qzg2NiIsInZpc2l0b3JfaWQiOiIyOTk0NTAzMDU2NzIxNjk1NzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 79c6d22614d18b1390e59fc5fa32ed4f6f6da678eb1bf7de0868fad2e799711f |
| hovercard-subject-tag | issue:1633379800 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/ipdata/java/8/issue_layout |
| twitter:image | https://opengraph.githubassets.com/d5df0e9a54ed26d6fbf6f2afe91566b6893b26f9e95ed338c147a16a15b45f4f/ipdata/java/issues/8 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d5df0e9a54ed26d6fbf6f2afe91566b6893b26f9e95ed338c147a16a15b45f4f/ipdata/java/issues/8 |
| og:image:alt | Hello ipdata team, We have a build problem regarding the usage of your library: ipdata uses the "Simple Logging Facade for Java (SLF4J)" for encapsulating logging. This is of course fine to be flex... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | norbertroamsys |
| hostname | github.com |
| expected-hostname | github.com |
| None | 8a71ca1f7ab5436216e1df86f398ef7a51ed3152c90e3f7332fc70cf97fcb9d6 |
| turbo-cache-control | no-preview |
| go-import | github.com/ipdata/java git https://github.com/ipdata/java.git |
| octolytics-dimension-user_id | 33085067 |
| octolytics-dimension-user_login | ipdata |
| octolytics-dimension-repository_id | 236467949 |
| octolytics-dimension-repository_nwo | ipdata/java |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 236467949 |
| octolytics-dimension-repository_network_root_nwo | ipdata/java |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | eaed570eead52a9920afef75dc3eb6d826fdc5ef |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width