René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Hypermodel `after_commit` handler is dropping errors instead of raising","articleBody":"in the after_commit method of hypermodel, the `SendPacket` operation is run which will return a promise, but it is not checked for an error state.\r\n\r\n```ruby\r\ndef self.after_commit(operation, model)\r\n  # Calling public_columns_hash once insures all policies are loaded\r\n  # before the first broadcast.\r\n  @public_columns_hash ||= ActiveRecord::Base.public_columns_hash\r\n  Hyperstack::InternalPolicy.regulate_broadcast(model) do |data|\r\n    puts \"Broadcast aftercommit hook: #{data}\" if Hyperstack::Connection.show_diagnostics\r\n\r\n    if !Hyperstack.on_server? \u0026\u0026 Hyperstack::Connection.root_path\r\n      send_to_server(operation, data, model.__synchromesh_update_time) rescue nil # fails if server no longer running so ignore\r\n    else\r\n      SendPacket.run(data, operation: operation, updated_at: model.__synchromesh_update_time)\r\n    end\r\n  end\r\nrescue ActiveRecord::StatementInvalid =\u003e e\r\n  raise e unless e.message == \"Could not find table 'hyperstack_connections'\"\r\nend unless RUBY_ENGINE == 'opal'\r\n```\r\n\r\nThe line containing `SendPacket` should be \r\n```ruby\r\nSendPacket.run(data, operation: operation, updated_at: model.__synchromesh_update_time).tap { |p| raise p.error if p.error }\r\n```\r\n\r\nThe easiest way to patch this is by adding this:\r\n\r\n```ruby\r\nmodule Hyperstack\r\n  class InternalPolicy\r\n    alias original_send_message send_message\r\n    def send_message(*args, \u0026block)\r\n      original_send_message(*args, \u0026block).tap { |p| raise p.error if p.is_a?(Promise) \u0026\u0026 p.error }\r\n    end  \r\n  end\r\nend\r\n```\r\n\r\nThis will catch the error with the smallest patch.  Note the patch needs to check if its a promise, but the actual fix does not.","author":{"url":"https://github.com/catmando","@type":"Person","name":"catmando"},"datePublished":"2023-03-27T20:02:21.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/453/hyperstack/issues/453"}