René's URL Explorer Experiment


Title: Use of six.text type in isinstance by marcdm · Pull Request #64 · html5lib/html5lib-python · GitHub

Open Graph Title: Use of six.text type in isinstance by marcdm · Pull Request #64 · html5lib/html5lib-python

X Title: Use of six.text type in isinstance by marcdm · Pull Request #64 · html5lib/html5lib-python

Description: As reported in #63, there are a couple places where isinstance(varname, six.text_type) is called. This is ok on Python 3, but not on Python 2. This patch fixes the issue. I don't quite understand t...

Open Graph Description: As reported in #63, there are a couple places where isinstance(varname, six.text_type) is called. This is ok on Python 3, but not on Python 2. This patch fixes the issue. I don't quite understa...

X Description: As reported in #63, there are a couple places where isinstance(varname, six.text_type) is called. This is ok on Python 3, but not on Python 2. This patch fixes the issue. I don't quite unde...

Opengraph URL: https://github.com/html5lib/html5lib-python/pull/64

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/:user_id/:repository/pull/*id(.:format)
route-controllerpull_requests
route-actionshow
fetch-noncev2:0bb570e4-c786-5750-a05b-3012ad0869d8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9138:2CE99D:CCE946:11E627F:6970BEF7
html-safe-noncee6d85109a68c98f3324b8b088f9fd55fc22b5acee1844822bcf1ca99ece59cca
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTM4OjJDRTk5RDpDQ0U5NDY6MTFFNjI3Rjo2OTcwQkVGNyIsInZpc2l0b3JfaWQiOiI2MDc5OTk5ODYyNTQ1MzY2Nzc1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc9395e011ed51851480b9fac631193a756415f085664e367dee8cf30f48bc54e
hovercard-subject-tagpull_request:6349422
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/html5lib/html5lib-python/pull/64
twitter:imagehttps://opengraph.githubassets.com/43ca7e5476ba96043b723070ed3b1be64aab9b307bcec4eb36bfbe5dc6691b96/html5lib/html5lib-python/pull/64
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/43ca7e5476ba96043b723070ed3b1be64aab9b307bcec4eb36bfbe5dc6691b96/html5lib/html5lib-python/pull/64
og:image:altAs reported in #63, there are a couple places where isinstance(varname, six.text_type) is called. This is ok on Python 3, but not on Python 2. This patch fixes the issue. I don't quite understa...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemarcdm
hostnamegithub.com
expected-hostnamegithub.com
Nonebb43a7bc61aba1b91c3c5cf8e7d00342e1e77a0cfe55a141222dbd7f9782d26f
turbo-cache-controlno-preview
go-importgithub.com/html5lib/html5lib-python git https://github.com/html5lib/html5lib-python.git
octolytics-dimension-user_id4092973
octolytics-dimension-user_loginhtml5lib
octolytics-dimension-repository_id9322649
octolytics-dimension-repository_nwohtml5lib/html5lib-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id9322649
octolytics-dimension-repository_network_root_nwohtml5lib/html5lib-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release34817b01ad7cdf8b2beb35ea7b0e2a7609004eff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fhtml5lib%2Fhtml5lib-python%2Fpull%2F64
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fhtml5lib%2Fhtml5lib-python%2Fpull%2F64
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=html5lib%2Fhtml5lib-python
Reloadhttps://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64
Reloadhttps://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64
Reloadhttps://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64
html5lib https://patch-diff.githubusercontent.com/html5lib
html5lib-pythonhttps://patch-diff.githubusercontent.com/html5lib/html5lib-python
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fhtml5lib%2Fhtml5lib-python
Fork 302 https://patch-diff.githubusercontent.com/login?return_to=%2Fhtml5lib%2Fhtml5lib-python
Star 1.2k https://patch-diff.githubusercontent.com/login?return_to=%2Fhtml5lib%2Fhtml5lib-python
Code https://patch-diff.githubusercontent.com/html5lib/html5lib-python
Issues 81 https://patch-diff.githubusercontent.com/html5lib/html5lib-python/issues
Pull requests 12 https://patch-diff.githubusercontent.com/html5lib/html5lib-python/pulls
Discussions https://patch-diff.githubusercontent.com/html5lib/html5lib-python/discussions
Actions https://patch-diff.githubusercontent.com/html5lib/html5lib-python/actions
Projects 0 https://patch-diff.githubusercontent.com/html5lib/html5lib-python/projects
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/html5lib/html5lib-python/security
Please reload this pagehttps://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64
Insights https://patch-diff.githubusercontent.com/html5lib/html5lib-python/pulse
Code https://patch-diff.githubusercontent.com/html5lib/html5lib-python
Issues https://patch-diff.githubusercontent.com/html5lib/html5lib-python/issues
Pull requests https://patch-diff.githubusercontent.com/html5lib/html5lib-python/pulls
Discussions https://patch-diff.githubusercontent.com/html5lib/html5lib-python/discussions
Actions https://patch-diff.githubusercontent.com/html5lib/html5lib-python/actions
Projects https://patch-diff.githubusercontent.com/html5lib/html5lib-python/projects
Security https://patch-diff.githubusercontent.com/html5lib/html5lib-python/security
Insights https://patch-diff.githubusercontent.com/html5lib/html5lib-python/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fhtml5lib%2Fhtml5lib-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fhtml5lib%2Fhtml5lib-python%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64#issue-comment-box
marcdmhttps://patch-diff.githubusercontent.com/marcdm
html5lib:masterhttps://patch-diff.githubusercontent.com/html5lib/html5lib-python/tree/master
marcdm:masterhttps://patch-diff.githubusercontent.com/marcdm/html5lib-python/tree/master
Use of six.text type in isinstance https://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64#top
marcdmhttps://patch-diff.githubusercontent.com/marcdm
html5lib:masterhttps://patch-diff.githubusercontent.com/html5lib/html5lib-python/tree/master
marcdm:masterhttps://patch-diff.githubusercontent.com/marcdm/html5lib-python/tree/master
Conversation 4 https://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64
Commits 6 https://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64/commits
Checks 0 https://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64/checks
Files changed https://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64/files
Please reload this pagehttps://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/marcdm
marcdmhttps://patch-diff.githubusercontent.com/marcdm
Jun 16, 2013https://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64#issue-15612668
#63https://github.com/html5lib/html5lib-python/issues/63
Please reload this pagehttps://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64
fixed the unicode/str/six bug, but the test that proves it is in an a…https://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64/commits/c8e024b8ae8712baa79872ac0aed6d0b82e06fa2
c8e024bhttps://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64/commits/c8e024b8ae8712baa79872ac0aed6d0b82e06fa2
https://patch-diff.githubusercontent.com/hoppipolla-critic-bot
hoppipolla-critic-bothttps://patch-diff.githubusercontent.com/hoppipolla-critic-bot
Jun 16, 2013https://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64#issuecomment-19521521
https://critic.hoppipolla.co.uk/r/179https://critic.hoppipolla.co.uk/r/179
Please reload this pagehttps://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64
tweaks so that Travis doesn't complainhttps://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64/commits/de312430310886bd74ef6ce39b7f037e26bc19d5
de31243https://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64/commits/de312430310886bd74ef6ce39b7f037e26bc19d5
https://patch-diff.githubusercontent.com/gsnedders
gsneddershttps://patch-diff.githubusercontent.com/gsnedders
Jun 17, 2013https://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64#issuecomment-19552842
Please reload this pagehttps://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64
June 18, 2013 18:15https://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64#commits-pushed-07bbab1
good good, all tests pass except the one that needs to gohttps://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64/commits/07bbab1a3f4b005d60e0cd0b514b8cc6c646a530
07bbab1https://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64/commits/07bbab1a3f4b005d60e0cd0b514b8cc6c646a530
lots of lessons learned, hopefully the test is more useful nowhttps://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64/commits/b5c80859900f6f60d512a583c66a5bb9c1eb45fa
b5c8085https://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64/commits/b5c80859900f6f60d512a583c66a5bb9c1eb45fa
https://patch-diff.githubusercontent.com/marcdm
marcdmhttps://patch-diff.githubusercontent.com/marcdm
Jun 19, 2013https://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64#issuecomment-19651876
Please reload this pagehttps://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64
June 22, 2013 22:31https://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64#commits-pushed-4a7adf2
minor update for clarityhttps://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64/commits/4a7adf281e0a670cb124dda03b7391a8974837bf
4a7adf2https://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64/commits/4a7adf281e0a670cb124dda03b7391a8974837bf
updated test commenthttps://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64/commits/841e67c902156af640ce9f7eabb6ac1ff89afe22
841e67chttps://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64/commits/841e67c902156af640ce9f7eabb6ac1ff89afe22
https://patch-diff.githubusercontent.com/gsnedders
gsneddershttps://patch-diff.githubusercontent.com/gsnedders
Jun 26, 2013https://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64#issuecomment-20088749
1d3434fhttps://github.com/html5lib/html5lib-python/commit/1d3434f392a797a04e7ad3214271b51280e83b2e
Please reload this pagehttps://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64
https://patch-diff.githubusercontent.com/gsnedders
gsneddershttps://patch-diff.githubusercontent.com/gsnedders
Jun 26, 2013https://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64#event-54281774
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fhtml5lib%2Fhtml5lib-python%2Fpull%2F64
1.0 https://patch-diff.githubusercontent.com/html5lib/html5lib-python/milestone/1
Please reload this pagehttps://patch-diff.githubusercontent.com/html5lib/html5lib-python/pull/64
https://patch-diff.githubusercontent.com/marcdm
https://patch-diff.githubusercontent.com/hoppipolla-critic-bot
https://patch-diff.githubusercontent.com/gsnedders
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.