René's URL Explorer Experiment


Title: Fix pure cpp1 header file generated using -import-std by MatthieuHernandez · Pull Request #1319 · hsutter/cppfront · GitHub

Open Graph Title: Fix pure cpp1 header file generated using -import-std by MatthieuHernandez · Pull Request #1319 · hsutter/cppfront

X Title: Fix pure cpp1 header file generated using -import-std by MatthieuHernandez · Pull Request #1319 · hsutter/cppfront

Description: I've noticed that if I execute cppfront.exe with the -import-std option on a .h file that doesn't contain any cpp2 code, then an #endif will be missing at the end of the file. See #1320 for more i...

Open Graph Description: I've noticed that if I execute cppfront.exe with the -import-std option on a .h file that doesn't contain any cpp2 code, then an #endif will be missing at the end of the file. See #1320 fo...

X Description: I've noticed that if I execute cppfront.exe with the -import-std option on a .h file that doesn't contain any cpp2 code, then an #endif will be missing at the end of the file. See #...

Opengraph URL: https://github.com/hsutter/cppfront/pull/1319

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f17e6b8c-75c9-b140-8465-4b6314ebf407
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDE2C:18F725:EC2FEC:14CCB60:69725F39
html-safe-nonce74ba05e344cf441999a0d62866d725e5a3e38b962fc26b7a031d2850411c85fc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTJDOjE4RjcyNTpFQzJGRUM6MTRDQ0I2MDo2OTcyNUYzOSIsInZpc2l0b3JfaWQiOiIxOTg2ODc0Mjc5NzQzMDg2MzkzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5bd9dddecbdc96b1a96a2acc962fc0a7f36eb47cdef8b43230f7376636d6d254
hovercard-subject-tagpull_request:2130928873
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/hsutter/cppfront/1319/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e1dc637ec340283f4ae8e1567d1a4c378e92cba9ded2e600507067900f6e6459/hsutter/cppfront/pull/1319
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e1dc637ec340283f4ae8e1567d1a4c378e92cba9ded2e600507067900f6e6459/hsutter/cppfront/pull/1319
og:image:altI've noticed that if I execute cppfront.exe with the -import-std option on a .h file that doesn't contain any cpp2 code, then an #endif will be missing at the end of the file. See #1320 fo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMatthieuHernandez
hostnamegithub.com
expected-hostnamegithub.com
Noneab2c8e6ec49d8737f6bf007a86b2c4a2bc434bba562c524e0c76465bc9ed358b
turbo-cache-controlno-preview
go-importgithub.com/hsutter/cppfront git https://github.com/hsutter/cppfront.git
octolytics-dimension-user_id1801526
octolytics-dimension-user_loginhsutter
octolytics-dimension-repository_id406923731
octolytics-dimension-repository_nwohsutter/cppfront
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id406923731
octolytics-dimension-repository_network_root_nwohsutter/cppfront
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release52bb8e0c9f4e51b63385b80feac0e6ba25e8dbd5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fhsutter%2Fcppfront%2Fpull%2F1319
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fhsutter%2Fcppfront%2Fpull%2F1319
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=hsutter%2Fcppfront
Reloadhttps://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319
Reloadhttps://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319
Reloadhttps://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319
hsutter https://patch-diff.githubusercontent.com/hsutter
cppfronthttps://patch-diff.githubusercontent.com/hsutter/cppfront
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fhsutter%2Fcppfront
Fork 265 https://patch-diff.githubusercontent.com/login?return_to=%2Fhsutter%2Fcppfront
Star 5.9k https://patch-diff.githubusercontent.com/login?return_to=%2Fhsutter%2Fcppfront
Code https://patch-diff.githubusercontent.com/hsutter/cppfront
Issues 190 https://patch-diff.githubusercontent.com/hsutter/cppfront/issues
Pull requests 11 https://patch-diff.githubusercontent.com/hsutter/cppfront/pulls
Discussions https://patch-diff.githubusercontent.com/hsutter/cppfront/discussions
Actions https://patch-diff.githubusercontent.com/hsutter/cppfront/actions
Wiki https://patch-diff.githubusercontent.com/hsutter/cppfront/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/hsutter/cppfront/security
Please reload this pagehttps://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319
Insights https://patch-diff.githubusercontent.com/hsutter/cppfront/pulse
Code https://patch-diff.githubusercontent.com/hsutter/cppfront
Issues https://patch-diff.githubusercontent.com/hsutter/cppfront/issues
Pull requests https://patch-diff.githubusercontent.com/hsutter/cppfront/pulls
Discussions https://patch-diff.githubusercontent.com/hsutter/cppfront/discussions
Actions https://patch-diff.githubusercontent.com/hsutter/cppfront/actions
Wiki https://patch-diff.githubusercontent.com/hsutter/cppfront/wiki
Security https://patch-diff.githubusercontent.com/hsutter/cppfront/security
Insights https://patch-diff.githubusercontent.com/hsutter/cppfront/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fhsutter%2Fcppfront%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fhsutter%2Fcppfront%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319#issue-comment-box
MatthieuHernandezhttps://patch-diff.githubusercontent.com/MatthieuHernandez
hsutter:mainhttps://patch-diff.githubusercontent.com/hsutter/cppfront/tree/main
MatthieuHernandez:Fix_pure1_with_import_stdhttps://patch-diff.githubusercontent.com/MatthieuHernandez/cppfront/tree/Fix_pure1_with_import_std
Fix pure cpp1 header file generated using -import-std https://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319#top
MatthieuHernandezhttps://patch-diff.githubusercontent.com/MatthieuHernandez
hsutter:mainhttps://patch-diff.githubusercontent.com/hsutter/cppfront/tree/main
MatthieuHernandez:Fix_pure1_with_import_stdhttps://patch-diff.githubusercontent.com/MatthieuHernandez/cppfront/tree/Fix_pure1_with_import_std
Conversation 5 https://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319
Commits 1 https://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319/commits
Checks 0 https://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319/checks
Files changed https://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319/files
Please reload this pagehttps://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/hsutter/cppfront/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/MatthieuHernandez
MatthieuHernandezhttps://patch-diff.githubusercontent.com/MatthieuHernandez
Oct 17, 2024https://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319#issue-2595631049
Please reload this pagehttps://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319
#1320https://github.com/hsutter/cppfront/issues/1320
Please reload this pagehttps://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319
https://patch-diff.githubusercontent.com/JohelEGP
Sign in to viewhttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fhsutter%2Fcppfront%2Fpull%2F1319
https://patch-diff.githubusercontent.com/MatthieuHernandez
MatthieuHernandezhttps://patch-diff.githubusercontent.com/MatthieuHernandez
force-pushedhttps://patch-diff.githubusercontent.com/hsutter/cppfront/compare/31e6312a28d25a3e577e2029c996826f70ff5f04..df266a67a7f92449cbdc6763a20df8acf5871ae2
31e6312https://patch-diff.githubusercontent.com/hsutter/cppfront/commit/31e6312a28d25a3e577e2029c996826f70ff5f04
df266a6https://patch-diff.githubusercontent.com/hsutter/cppfront/commit/df266a67a7f92449cbdc6763a20df8acf5871ae2
Compare https://patch-diff.githubusercontent.com/hsutter/cppfront/compare/31e6312a28d25a3e577e2029c996826f70ff5f04..df266a67a7f92449cbdc6763a20df8acf5871ae2
October 17, 2024 20:15https://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319#event-14705076656
https://patch-diff.githubusercontent.com/MatthieuHernandez
MatthieuHernandezhttps://patch-diff.githubusercontent.com/MatthieuHernandez
Oct 17, 2024 https://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319#ref-issue-2595684957
[BUG] Missing #endif in pure cpp1 header file when generated using -import-std #1320 https://patch-diff.githubusercontent.com/hsutter/cppfront/issues/1320
https://patch-diff.githubusercontent.com/gregmarr
gregmarrhttps://patch-diff.githubusercontent.com/gregmarr
Oct 17, 2024https://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319#issuecomment-2420536986
cppfront/source/to_cpp1.hhttps://github.com/hsutter/cppfront/blob/68b716abe3e4b623e875d68a2b9b3f0efcd39b45/source/to_cpp1.h#L1298-L1305
68b716ahttps://patch-diff.githubusercontent.com/hsutter/cppfront/commit/68b716abe3e4b623e875d68a2b9b3f0efcd39b45
Please reload this pagehttps://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319
https://patch-diff.githubusercontent.com/gregmarr
gregmarrhttps://patch-diff.githubusercontent.com/gregmarr
Oct 17, 2024 https://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319#pullrequestreview-2376268674
View reviewed changes https://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319/files
source/to_cpp1.hhttps://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319/files#diff-9e3e6d623803ce8a26a44e27a5824cf938eae42d04829e2a41b80bd40a43a246
gregmarrhttps://patch-diff.githubusercontent.com/gregmarr
Oct 17, 2024https://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319#discussion_r1805414883
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
cppfront/source/to_cpp1.hhttps://github.com/hsutter/cppfront/blob/68b716abe3e4b623e875d68a2b9b3f0efcd39b45/source/to_cpp1.h#L1301-L1305
68b716ahttps://patch-diff.githubusercontent.com/hsutter/cppfront/commit/68b716abe3e4b623e875d68a2b9b3f0efcd39b45
Please reload this pagehttps://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319
MatthieuHernandezhttps://patch-diff.githubusercontent.com/MatthieuHernandez
Oct 17, 2024https://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319#discussion_r1805422829
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319
https://patch-diff.githubusercontent.com/MatthieuHernandez
Fix pure1 file with -import-stdhttps://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319/commits/ed1fa670e0fa211776e611bd6ffeaf8c58f41ace
ed1fa67https://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319/commits/ed1fa670e0fa211776e611bd6ffeaf8c58f41ace
https://patch-diff.githubusercontent.com/MatthieuHernandez
MatthieuHernandezhttps://patch-diff.githubusercontent.com/MatthieuHernandez
force-pushedhttps://patch-diff.githubusercontent.com/hsutter/cppfront/compare/df266a67a7f92449cbdc6763a20df8acf5871ae2..ed1fa670e0fa211776e611bd6ffeaf8c58f41ace
df266a6https://patch-diff.githubusercontent.com/hsutter/cppfront/commit/df266a67a7f92449cbdc6763a20df8acf5871ae2
ed1fa67https://patch-diff.githubusercontent.com/hsutter/cppfront/commit/ed1fa670e0fa211776e611bd6ffeaf8c58f41ace
Compare https://patch-diff.githubusercontent.com/hsutter/cppfront/compare/df266a67a7f92449cbdc6763a20df8acf5871ae2..ed1fa670e0fa211776e611bd6ffeaf8c58f41ace
October 17, 2024 20:54https://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319#event-14705538138
https://patch-diff.githubusercontent.com/JohelEGP
JohelEGPhttps://patch-diff.githubusercontent.com/JohelEGP
Oct 17, 2024 https://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319#pullrequestreview-2376407698
View reviewed changes https://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319/files/ed1fa670e0fa211776e611bd6ffeaf8c58f41ace
https://patch-diff.githubusercontent.com/hsutter
hsutterhttps://patch-diff.githubusercontent.com/hsutter
Oct 31, 2024https://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319#issuecomment-2448902116
Please reload this pagehttps://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319
https://patch-diff.githubusercontent.com/hsutter
hsutterhttps://patch-diff.githubusercontent.com/hsutter
awaiting-cla https://patch-diff.githubusercontent.com/hsutter/cppfront/issues?q=state%3Aopen%20label%3Aawaiting-cla
awaiting-cla https://patch-diff.githubusercontent.com/hsutter/cppfront/issues?q=state%3Aopen%20label%3Aawaiting-cla
Oct 31, 2024https://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319#event-15024484482
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fhsutter%2Fcppfront%2Fpull%2F1319
https://patch-diff.githubusercontent.com/gregmarr
gregmarr https://patch-diff.githubusercontent.com/gregmarr
https://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319/files/df266a67a7f92449cbdc6763a20df8acf5871ae2
https://patch-diff.githubusercontent.com/JohelEGP
JohelEGP https://patch-diff.githubusercontent.com/JohelEGP
https://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319/files/ed1fa670e0fa211776e611bd6ffeaf8c58f41ace
Please reload this pagehttps://patch-diff.githubusercontent.com/hsutter/cppfront/pull/1319
https://patch-diff.githubusercontent.com/MatthieuHernandez
https://patch-diff.githubusercontent.com/JohelEGP
https://patch-diff.githubusercontent.com/gregmarr
https://patch-diff.githubusercontent.com/hsutter
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.