Title: DirectivesHolder does not implement toString · Issue #4190 · graphql-java/graphql-java · GitHub
Open Graph Title: DirectivesHolder does not implement toString · Issue #4190 · graphql-java/graphql-java
X Title: DirectivesHolder does not implement toString · Issue #4190 · graphql-java/graphql-java
Description: Describe the bug #4027 introduced an unannounced breaking change in 25.0. Quite a few places that now contain a DirectivesHolder implicitly call toString on it in their own toString implementations. Before this change that worked just fi...
Open Graph Description: Describe the bug #4027 introduced an unannounced breaking change in 25.0. Quite a few places that now contain a DirectivesHolder implicitly call toString on it in their own toString implementations...
X Description: Describe the bug #4027 introduced an unannounced breaking change in 25.0. Quite a few places that now contain a DirectivesHolder implicitly call toString on it in their own toString implementations...
Opengraph URL: https://github.com/graphql-java/graphql-java/issues/4190
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"DirectivesHolder does not implement toString","articleBody":"**Describe the bug**\n#4027 introduced an unannounced breaking change in 25.0. Quite a few places that now contain a DirectivesHolder implicitly call `toString` on it in their own `toString` implementations. Before this change that worked just fine, because directives were just a list and lists tend to have reasonable `toString` implementations.\n\nHere is one example:\nhttps://github.com/graphql-java/graphql-java/blob/021fe1b5d2394c979cbb4e7b38839753b99bfffd/src/main/java/graphql/language/ScalarTypeDefinition.java#L116-L121\n\n`DirectivesHolder`, however, does not have one, so all those other `toString` implementations no longer produce reasonable output.\n\n**To Reproduce**\nCreate a ScalarTypeDefinition object. Call `toString` on it.\n\nActual output:\n```\nScalarTypeDefinition{name='Int', directives=graphql.language.NodeUtil$DirectivesHolder@5c995dee}\n```\n\nExpected output (and actual output in 24.x):\n```\nScalarTypeDefinition{name='Int', directives=[]}\n```","author":{"url":"https://github.com/invliD","@type":"Person","name":"invliD"},"datePublished":"2025-12-09T23:02:01.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/4190/graphql-java/issues/4190"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e94a5041-ed8d-f16b-059e-b10e303d36ef |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D378:3CE303:D16452:1284382:696F4C35 |
| html-safe-nonce | dc30fe78e3ba0306fa94a331bf9ddc62a64d9690fa67beb9369914739e44fce7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzc4OjNDRTMwMzpEMTY0NTI6MTI4NDM4Mjo2OTZGNEMzNSIsInZpc2l0b3JfaWQiOiIzNzU3OTI2MzQ4MDEzNjUzMDQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 3180f91548f93a890be89099743b063644a36e927374c3e31aaad1c3c0552c36 |
| hovercard-subject-tag | issue:3712944376 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/graphql-java/graphql-java/4190/issue_layout |
| twitter:image | https://opengraph.githubassets.com/5d94c3ffd5d7cb78595cdeaee94d25fb522c14440b931a4933f6c7e587f7af52/graphql-java/graphql-java/issues/4190 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5d94c3ffd5d7cb78595cdeaee94d25fb522c14440b931a4933f6c7e587f7af52/graphql-java/graphql-java/issues/4190 |
| og:image:alt | Describe the bug #4027 introduced an unannounced breaking change in 25.0. Quite a few places that now contain a DirectivesHolder implicitly call toString on it in their own toString implementations... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | invliD |
| hostname | github.com |
| expected-hostname | github.com |
| None | 49bb2ee76ae1b4ec758faefafda636ff20b05a9708bb290d28422cdf542ae979 |
| turbo-cache-control | no-preview |
| go-import | github.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git |
| octolytics-dimension-user_id | 14289921 |
| octolytics-dimension-user_login | graphql-java |
| octolytics-dimension-repository_id | 38602457 |
| octolytics-dimension-repository_nwo | graphql-java/graphql-java |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 38602457 |
| octolytics-dimension-repository_network_root_nwo | graphql-java/graphql-java |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 036f37fe552777ac9c6ee661957f947285aab936 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width