René's URL Explorer Experiment


Title: refactor: switch RowNumber to 0-based indexing in sqlglot compiler by chelsea-lin · Pull Request #2292 · googleapis/python-bigquery-dataframes · GitHub

Open Graph Title: refactor: switch RowNumber to 0-based indexing in sqlglot compiler by chelsea-lin · Pull Request #2292 · googleapis/python-bigquery-dataframes

X Title: refactor: switch RowNumber to 0-based indexing in sqlglot compiler by chelsea-lin · Pull Request #2292 · googleapis/python-bigquery-dataframes

Description: This change aims to fix the tests failing in #2248 because of a 1-based indexing error. Fixes internal issue 417774347 🦕

Open Graph Description: This change aims to fix the tests failing in #2248 because of a 1-based indexing error. Fixes internal issue 417774347 🦕

X Description: This change aims to fix the tests failing in #2248 because of a 1-based indexing error. Fixes internal issue 417774347 🦕

Opengraph URL: https://github.com/googleapis/python-bigquery-dataframes/pull/2292

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0868b525-83ae-f28b-d6d5-c92d7c99d87b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB6F2:F7DFA:2CF125:3DFA0F:696E6F1F
html-safe-nonce6e98909df41d41614a2eba924489b12aac2b6e98e444b3bc1dcef85030003398
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNkYyOkY3REZBOjJDRjEyNTozREZBMEY6Njk2RTZGMUYiLCJ2aXNpdG9yX2lkIjoiMTg5NTUxMTIwNTg4MTA3NTUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca6643dcf5c1a00052c1df55dfd822374685aa9c80c4f9e0f8685435d59a2eaeb
hovercard-subject-tagpull_request:3041880037
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/python-bigquery-dataframes/2292/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8926fce2c4383a6005999618c88367c9e4e6a8cb91408b553e28195a33e8723f/googleapis/python-bigquery-dataframes/pull/2292
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8926fce2c4383a6005999618c88367c9e4e6a8cb91408b553e28195a33e8723f/googleapis/python-bigquery-dataframes/pull/2292
og:image:altThis change aims to fix the tests failing in #2248 because of a 1-based indexing error. Fixes internal issue 417774347 🦕
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamechelsea-lin
hostnamegithub.com
expected-hostnamegithub.com
Nonedd24262d9e4947a6c63df018b01e9a6da49caaf8259148a56a04b665d15d66b3
turbo-cache-controlno-preview
go-importgithub.com/googleapis/python-bigquery-dataframes git https://github.com/googleapis/python-bigquery-dataframes.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id667598363
octolytics-dimension-repository_nwogoogleapis/python-bigquery-dataframes
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id667598363
octolytics-dimension-repository_network_root_nwogoogleapis/python-bigquery-dataframes
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release307ab96ec5f21762ff6c530a60b1ef6b1e74dd5a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-bigquery-dataframes%2Fpull%2F2292
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-bigquery-dataframes%2Fpull%2F2292
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fpython-bigquery-dataframes
Reloadhttps://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292
Reloadhttps://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292
Reloadhttps://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292
googleapis https://patch-diff.githubusercontent.com/googleapis
python-bigquery-dataframeshttps://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fgoogleapis%2Fpython-bigquery-dataframes
Fork 63 https://patch-diff.githubusercontent.com/login?return_to=%2Fgoogleapis%2Fpython-bigquery-dataframes
Star 278 https://patch-diff.githubusercontent.com/login?return_to=%2Fgoogleapis%2Fpython-bigquery-dataframes
Code https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes
Issues 13 https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/issues
Pull requests 48 https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pulls
Actions https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/actions
Projects 0 https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/projects
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/security
Please reload this pagehttps://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292
Insights https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pulse
Code https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes
Issues https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/issues
Pull requests https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pulls
Actions https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/actions
Projects https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/projects
Security https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/security
Insights https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fgoogleapis%2Fpython-bigquery-dataframes%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fgoogleapis%2Fpython-bigquery-dataframes%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292#issue-comment-box
chelsea-linhttps://patch-diff.githubusercontent.com/chelsea-lin
mainhttps://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/tree/main
main_chelsealin_rownumberhttps://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/tree/main_chelsealin_rownumber
refactor: switch RowNumber to 0-based indexing in sqlglot compiler https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292#top
chelsea-linhttps://patch-diff.githubusercontent.com/chelsea-lin
mainhttps://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/tree/main
main_chelsealin_rownumberhttps://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/tree/main_chelsealin_rownumber
Conversation 0 https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292
Commits 1 https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292/commits
Checks 14 https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292/checks
Files changed https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292/files
Please reload this pagehttps://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/chelsea-lin
chelsea-linhttps://patch-diff.githubusercontent.com/chelsea-lin
Nov 25, 2025https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292#issue-3660984508
Please reload this pagehttps://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292
#2248https://github.com/googleapis/python-bigquery-dataframes/pull/2248
Please reload this pagehttps://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292
https://patch-diff.githubusercontent.com/chelsea-lin
refactor: switch RowNumber to 0-based indexing in sqlglot compilerhttps://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292/commits/3f8fef487ef2d930f73f327c2f9ec45115af5806
3f8fef4https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292/commits/3f8fef487ef2d930f73f327c2f9ec45115af5806
https://patch-diff.githubusercontent.com/apps/product-auto-label
product-auto-labelhttps://patch-diff.githubusercontent.com/apps/product-auto-label
size: s https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/issues?q=state%3Aopen%20label%3A%22size%3A%20s%22
api: bigquery https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/issues?q=state%3Aopen%20label%3A%22api%3A%20bigquery%22
Nov 25, 2025https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292#event-21151788225
https://patch-diff.githubusercontent.com/chelsea-lin
chelsea-linhttps://patch-diff.githubusercontent.com/chelsea-lin
November 25, 2025 00:22https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292#event-21151823284
https://patch-diff.githubusercontent.com/chelsea-lin
chelsea-linhttps://patch-diff.githubusercontent.com/chelsea-lin
code ownershttps://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/blob/b487cf1f6ecacb1ee3b35ffdd934221516bbd558/.github/CODEOWNERS#L9
November 25, 2025 00:22https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292#event-21151823400
https://patch-diff.githubusercontent.com/chelsea-lin
chelsea-linhttps://patch-diff.githubusercontent.com/chelsea-lin
jialuoohttps://patch-diff.githubusercontent.com/jialuoo
November 25, 2025 00:22https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292#event-21151823520
https://patch-diff.githubusercontent.com/apps/blunderbuss-gcf
blunderbuss-gcfhttps://patch-diff.githubusercontent.com/apps/blunderbuss-gcf
sycaihttps://patch-diff.githubusercontent.com/sycai
Nov 25, 2025https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292#event-21151823915
https://patch-diff.githubusercontent.com/jialuoo
jialuoohttps://patch-diff.githubusercontent.com/jialuoo
Nov 25, 2025 https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292#pullrequestreview-3506290992
View reviewed changes https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292/files/3f8fef487ef2d930f73f327c2f9ec45115af5806
https://patch-diff.githubusercontent.com/chelsea-lin
chelsea-linhttps://patch-diff.githubusercontent.com/chelsea-lin
3275761https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/commit/32757619a40ab2ecfd4336c38b64efe64ec764f6
Nov 25, 2025https://github.com/googleapis/python-bigquery-dataframes/pull/2292#event-21171262074
Please reload this pagehttps://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292
https://patch-diff.githubusercontent.com/chelsea-lin
chelsea-linhttps://patch-diff.githubusercontent.com/chelsea-lin
November 25, 2025 18:22https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292#event-21171263058
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-bigquery-dataframes%2Fpull%2F2292
https://patch-diff.githubusercontent.com/jialuoo
jialuoo https://patch-diff.githubusercontent.com/jialuoo
https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292/files/3f8fef487ef2d930f73f327c2f9ec45115af5806
https://patch-diff.githubusercontent.com/sycai
sycai https://patch-diff.githubusercontent.com/sycai
api: bigquery https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/issues?q=state%3Aopen%20label%3A%22api%3A%20bigquery%22
size: s https://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/issues?q=state%3Aopen%20label%3A%22size%3A%20s%22
Please reload this pagehttps://patch-diff.githubusercontent.com/googleapis/python-bigquery-dataframes/pull/2292
https://patch-diff.githubusercontent.com/chelsea-lin
https://patch-diff.githubusercontent.com/jialuoo
https://patch-diff.githubusercontent.com/sycai
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.