Title: Fix type annotations for Transaction in model.py. · Issue #118 · google/python-spanner-orm · GitHub
Open Graph Title: Fix type annotations for Transaction in model.py. · Issue #118 · google/python-spanner-orm
X Title: Fix type annotations for Transaction in model.py. · Issue #118 · google/python-spanner-orm
Description: Currently model.py uses google.cloud.spanner_v1.transaction.Transaction for all the transaction parameters, but I think the read-only methods are designed to work with google.cloud.spanner_v1.snapshot.Snapshot too. Snapshot is available ...
Open Graph Description: Currently model.py uses google.cloud.spanner_v1.transaction.Transaction for all the transaction parameters, but I think the read-only methods are designed to work with google.cloud.spanner_v1.snaps...
X Description: Currently model.py uses google.cloud.spanner_v1.transaction.Transaction for all the transaction parameters, but I think the read-only methods are designed to work with google.cloud.spanner_v1.snaps...
Opengraph URL: https://github.com/google/python-spanner-orm/issues/118
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Fix type annotations for Transaction in model.py.","articleBody":"Currently `model.py` uses `google.cloud.spanner_v1.transaction.Transaction` for all the transaction parameters, but I think the read-only methods are designed to work with `google.cloud.spanner_v1.snapshot.Snapshot` too. `Snapshot` is available through the Spanner ORM API in `spanner_orm.api.SpannerReadApi.run_read_only()` and `spanner_orm.decorator.transactional_read()`, so we really should support using correct type annotations for `Snapshot`. Another thing to consider is whether there should be any support for `google.cloud.spanner_v1.batch.Batch` in write-only Model methods.","author":{"url":"https://github.com/dseomn","@type":"Person","name":"dseomn"},"datePublished":"2020-12-30T01:36:37.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/118/python-spanner-orm/issues/118"}| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:3030aaa8-d1fb-db3e-518c-12b736a03416 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8A5A:5218B:140B7B8:1B7A7D8:697B22DC |
| html-safe-nonce | 97c6a583a0a735fc1aeb596f9ca3cb268a397be15ed1bac93c811bc464736898 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTVBOjUyMThCOjE0MEI3Qjg6MUI3QTdEODo2OTdCMjJEQyIsInZpc2l0b3JfaWQiOiIxMDA4NDIwMjc4MDUwMTY5NTY1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 78d85da0ab03ea92ed1300449fcdd5365091b7a7b3572e17ed9fb40f483ba172 |
| hovercard-subject-tag | issue:776157319 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/google/python-spanner-orm/118/issue_layout |
| twitter:image | https://opengraph.githubassets.com/3bd70d91a9e2b4d603cbbc97a84e83a8baac5659321e931fb0031b492898f092/google/python-spanner-orm/issues/118 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3bd70d91a9e2b4d603cbbc97a84e83a8baac5659321e931fb0031b492898f092/google/python-spanner-orm/issues/118 |
| og:image:alt | Currently model.py uses google.cloud.spanner_v1.transaction.Transaction for all the transaction parameters, but I think the read-only methods are designed to work with google.cloud.spanner_v1.snaps... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dseomn |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7ce8ed0a54c4730aeca4e6abacfc6490365fc42e25480b86883054df3f9181c8 |
| turbo-cache-control | no-preview |
| go-import | github.com/google/python-spanner-orm git https://github.com/google/python-spanner-orm.git |
| octolytics-dimension-user_id | 1342004 |
| octolytics-dimension-user_login | |
| octolytics-dimension-repository_id | 155757264 |
| octolytics-dimension-repository_nwo | google/python-spanner-orm |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 155757264 |
| octolytics-dimension-repository_network_root_nwo | google/python-spanner-orm |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82440e908b5650143b0930c6bf91e184f2bad20c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width