| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7f0b0af6-b6c7-256e-73a7-ba3b6ac85b62 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D2EE:C53D0:2A3FFF1:3B47966:69710620 |
| html-safe-nonce | bf9d0d6758a8b5d8052e0ce1ffb6c780876b96baa15e6ab75d3a3d8dee496f02 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkVFOkM1M0QwOjJBM0ZGRjE6M0I0Nzk2Njo2OTcxMDYyMCIsInZpc2l0b3JfaWQiOiI0NTk3MjM5OTQ0OTQwOTQ2OTc2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 24c3089ccc8950aea904699913721b0b523ee09588a51bcbfed52bd63c63770e |
| hovercard-subject-tag | pull_request:1880997896 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/google/python-fire/513/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d311c652645594c635da880351a4c7dfbcfca2b11c6f9a873d858ce2538bf083/google/python-fire/pull/513 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d311c652645594c635da880351a4c7dfbcfca2b11c6f9a873d858ce2538bf083/google/python-fire/pull/513 |
| og:image:alt | Closes #508
Fixed bug where objects from typing instance were not displayed correctly mentioned in #508 and also Union types.
Added tests for typing.Union and typing.Optional
Other notes
Removed co... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Jemeljanov |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6d0e7b0d5e294a53c55f49e80755e785182080c6e6a48c9ed353bedddaee69f4 |
| turbo-cache-control | no-preview |
| go-import | github.com/google/python-fire git https://github.com/google/python-fire.git |
| octolytics-dimension-user_id | 1342004 |
| octolytics-dimension-user_login | google |
| octolytics-dimension-repository_id | 82729529 |
| octolytics-dimension-repository_nwo | google/python-fire |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 82729529 |
| octolytics-dimension-repository_network_root_nwo | google/python-fire |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6d5a3a396bc74e65fd3ef897b0a99a6e489debaa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/google/python-fire/pull/513#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2Fpython-fire%2Fpull%2F513 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2Fpython-fire%2Fpull%2F513 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=google%2Fpython-fire |
| Reload | https://patch-diff.githubusercontent.com/google/python-fire/pull/513 |
| Reload | https://patch-diff.githubusercontent.com/google/python-fire/pull/513 |
| Reload | https://patch-diff.githubusercontent.com/google/python-fire/pull/513 |
|
google
| https://patch-diff.githubusercontent.com/google |
| python-fire | https://patch-diff.githubusercontent.com/google/python-fire |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Fgoogle%2Fpython-fire |
|
Fork
1.5k
| https://patch-diff.githubusercontent.com/login?return_to=%2Fgoogle%2Fpython-fire |
|
Star
28.1k
| https://patch-diff.githubusercontent.com/login?return_to=%2Fgoogle%2Fpython-fire |
|
Code
| https://patch-diff.githubusercontent.com/google/python-fire |
|
Issues
127
| https://patch-diff.githubusercontent.com/google/python-fire/issues |
|
Pull requests
33
| https://patch-diff.githubusercontent.com/google/python-fire/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/google/python-fire/actions |
|
Projects
0
| https://patch-diff.githubusercontent.com/google/python-fire/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://patch-diff.githubusercontent.com/google/python-fire/security |
| Please reload this page | https://patch-diff.githubusercontent.com/google/python-fire/pull/513 |
|
Insights
| https://patch-diff.githubusercontent.com/google/python-fire/pulse |
|
Code
| https://patch-diff.githubusercontent.com/google/python-fire |
|
Issues
| https://patch-diff.githubusercontent.com/google/python-fire/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/google/python-fire/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/google/python-fire/actions |
|
Projects
| https://patch-diff.githubusercontent.com/google/python-fire/projects |
|
Security
| https://patch-diff.githubusercontent.com/google/python-fire/security |
|
Insights
| https://patch-diff.githubusercontent.com/google/python-fire/pulse |
| Sign up for GitHub
| https://patch-diff.githubusercontent.com/signup?return_to=%2Fgoogle%2Fpython-fire%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=%2Fgoogle%2Fpython-fire%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://patch-diff.githubusercontent.com/google/python-fire/pull/513#issue-comment-box |
| Jemeljanov | https://patch-diff.githubusercontent.com/Jemeljanov |
| google:master | https://patch-diff.githubusercontent.com/google/python-fire/tree/master |
| Jemeljanov:bug-fix-typing-package | https://patch-diff.githubusercontent.com/Jemeljanov/python-fire/tree/bug-fix-typing-package |
|
bug fix for help from typing package, add test for optional and union
| https://patch-diff.githubusercontent.com/google/python-fire/pull/513#top |
| Jemeljanov | https://patch-diff.githubusercontent.com/Jemeljanov |
| google:master | https://patch-diff.githubusercontent.com/google/python-fire/tree/master |
| Jemeljanov:bug-fix-typing-package | https://patch-diff.githubusercontent.com/Jemeljanov/python-fire/tree/bug-fix-typing-package |
|
Conversation
5
| https://patch-diff.githubusercontent.com/google/python-fire/pull/513 |
|
Commits
3
| https://patch-diff.githubusercontent.com/google/python-fire/pull/513/commits |
|
Checks
0
| https://patch-diff.githubusercontent.com/google/python-fire/pull/513/checks |
|
Files changed
| https://patch-diff.githubusercontent.com/google/python-fire/pull/513/files |
| Please reload this page | https://patch-diff.githubusercontent.com/google/python-fire/pull/513 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/google/python-fire/pull/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/Jemeljanov |
| Jemeljanov | https://patch-diff.githubusercontent.com/Jemeljanov |
| May 21, 2024 | https://patch-diff.githubusercontent.com/google/python-fire/pull/513#issue-2308906516 |
| Please reload this page | https://patch-diff.githubusercontent.com/google/python-fire/pull/513 |
| #508 | https://github.com/google/python-fire/issues/508 |
| #508 | https://github.com/google/python-fire/issues/508 |
| Please reload this page | https://patch-diff.githubusercontent.com/google/python-fire/pull/513 |
|
| https://patch-diff.githubusercontent.com/Jemeljanov |
| bug fix for help from typing package, add test for optional and union | https://patch-diff.githubusercontent.com/google/python-fire/pull/513/commits/3f95b16de238d1b0107e1c78682ccd45a0e7198b |
| 3f95b16 | https://patch-diff.githubusercontent.com/google/python-fire/pull/513/commits/3f95b16de238d1b0107e1c78682ccd45a0e7198b |
| https://patch-diff.githubusercontent.com/apps/google-cla |
| google-cla | https://patch-diff.githubusercontent.com/apps/google-cla |
| May 21, 2024 | https://patch-diff.githubusercontent.com/google/python-fire/pull/513#issuecomment-2123244726 |
| failed invocation | https://github.com/google/python-fire/pull/513/checks?check_run_id=25243016616 |
| Please reload this page | https://patch-diff.githubusercontent.com/google/python-fire/pull/513 |
| https://patch-diff.githubusercontent.com/Jemeljanov |
| Jemeljanov | https://patch-diff.githubusercontent.com/Jemeljanov |
|
May 22, 2024
| https://patch-diff.githubusercontent.com/google/python-fire/pull/513#ref-issue-2252966062 |
|
Optional type args are mistyped in help
#508
| https://patch-diff.githubusercontent.com/google/python-fire/issues/508 |
| https://patch-diff.githubusercontent.com/dbieber |
| dbieber | https://patch-diff.githubusercontent.com/dbieber |
|
May 22, 2024
| https://patch-diff.githubusercontent.com/google/python-fire/pull/513#pullrequestreview-2072466684 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/google/python-fire/pull/513/files/3f95b16de238d1b0107e1c78682ccd45a0e7198b |
| fire/helptext_test.py | https://patch-diff.githubusercontent.com/google/python-fire/pull/513/files/3f95b16de238d1b0107e1c78682ccd45a0e7198b#diff-ea8f6442e3fa13ab4758cfc1fae501b4ff98bb510e04d1370daeb4d917c3a1e8 |
| Please reload this page | https://patch-diff.githubusercontent.com/google/python-fire/pull/513 |
| https://patch-diff.githubusercontent.com/dbieber |
| dbieber | https://patch-diff.githubusercontent.com/dbieber |
| May 22, 2024 | https://patch-diff.githubusercontent.com/google/python-fire/pull/513#issuecomment-2125833905 |
| Please reload this page | https://patch-diff.githubusercontent.com/google/python-fire/pull/513 |
|
| https://patch-diff.githubusercontent.com/Jemeljanov |
| Refactor helptext.py to remove unused import and simplify code | https://patch-diff.githubusercontent.com/google/python-fire/pull/513/commits/9bc2ad3f024135b56e9c05a309699ae95c0242b7 |
| 9bc2ad3 | https://patch-diff.githubusercontent.com/google/python-fire/pull/513/commits/9bc2ad3f024135b56e9c05a309699ae95c0242b7 |
| https://patch-diff.githubusercontent.com/Jemeljanov |
| Jemeljanov | https://patch-diff.githubusercontent.com/Jemeljanov |
| May 22, 2024 | https://patch-diff.githubusercontent.com/google/python-fire/pull/513#issuecomment-2125910410 |
| Please reload this page | https://patch-diff.githubusercontent.com/google/python-fire/pull/513 |
| @dbieber | https://github.com/dbieber |
| Please reload this page | https://patch-diff.githubusercontent.com/google/python-fire/pull/513 |
| https://patch-diff.githubusercontent.com/Jemeljanov |
| Jemeljanov | https://patch-diff.githubusercontent.com/Jemeljanov |
| dbieber | https://patch-diff.githubusercontent.com/dbieber |
| May 23, 2024 15:36 | https://patch-diff.githubusercontent.com/google/python-fire/pull/513#event-12911469090 |
|
| https://patch-diff.githubusercontent.com/dbieber |
| Merge branch 'master' into bug-fix-typing-package | https://patch-diff.githubusercontent.com/google/python-fire/pull/513/commits/2b0ebfad398c9ed62c2ee4553b9f2d23f7d85857 |
| 2b0ebfa | https://patch-diff.githubusercontent.com/google/python-fire/pull/513/commits/2b0ebfad398c9ed62c2ee4553b9f2d23f7d85857 |
| https://patch-diff.githubusercontent.com/dbieber |
| dbieber | https://patch-diff.githubusercontent.com/dbieber |
| Sep 21, 2024 | https://patch-diff.githubusercontent.com/google/python-fire/pull/513#issuecomment-2365307829 |
| Please reload this page | https://patch-diff.githubusercontent.com/google/python-fire/pull/513 |
| https://patch-diff.githubusercontent.com/Borda |
| Borda | https://patch-diff.githubusercontent.com/Borda |
|
Feb 11, 2025
| https://patch-diff.githubusercontent.com/google/python-fire/pull/513#pullrequestreview-2608596365 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/google/python-fire/pull/513/files/2b0ebfad398c9ed62c2ee4553b9f2d23f7d85857 |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2Fpython-fire%2Fpull%2F513 |
|
| https://patch-diff.githubusercontent.com/dbieber |
|
dbieber
| https://patch-diff.githubusercontent.com/dbieber |
|
| https://patch-diff.githubusercontent.com/Borda |
|
Borda
| https://patch-diff.githubusercontent.com/Borda |
|
| https://patch-diff.githubusercontent.com/google/python-fire/pull/513/files/2b0ebfad398c9ed62c2ee4553b9f2d23f7d85857 |
|
Optional type args are mistyped in help
| https://github.com/google/python-fire/issues/508 |
| Please reload this page | https://patch-diff.githubusercontent.com/google/python-fire/pull/513 |
|
| https://patch-diff.githubusercontent.com/Jemeljanov |
|
| https://patch-diff.githubusercontent.com/dbieber |
|
| https://patch-diff.githubusercontent.com/Borda |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |