René's URL Explorer Experiment


Title: Bugfix - sign_cryptography.CryptographySigner - keyfile opened as text (breaks on Python 3) by Halastra · Pull Request #172 · google/python-adb · GitHub

Open Graph Title: Bugfix - sign_cryptography.CryptographySigner - keyfile opened as text (breaks on Python 3) by Halastra · Pull Request #172 · google/python-adb

X Title: Bugfix - sign_cryptography.CryptographySigner - keyfile opened as text (breaks on Python 3) by Halastra · Pull Request #172 · google/python-adb

Description: This should fix an issue caused by the CryptographySigner initializer method, which opens the RSA public/private key files for reading in "text mode" instead of "binary mode". Python 2.x does work ...

Open Graph Description: This should fix an issue caused by the CryptographySigner initializer method, which opens the RSA public/private key files for reading in "text mode" instead of "binary mode". P...

X Description: This should fix an issue caused by the CryptographySigner initializer method, which opens the RSA public/private key files for reading in "text mode" instead of "binary m...

Opengraph URL: https://github.com/google/python-adb/pull/172

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3c035b97-ab89-7a4a-5abd-db3d9186275d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id86BA:C551D:7795AF:A4E3EF:697756E7
html-safe-nonce1303d72fdba68e2ef67307f4a0460c9fbfdaf3b757b1f509fa30cc9a9491b7fd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NkJBOkM1NTFEOjc3OTVBRjpBNEUzRUY6Njk3NzU2RTciLCJ2aXNpdG9yX2lkIjoiMTczMjA4MDgyMDk5MTUxNDM0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac48890a8c2ef0065413c6c36450fb87fd2c77fe1e687cc8338b19a9ed1177f33a
hovercard-subject-tagpull_request:346807096
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/google/python-adb/172/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/03117f626d845c9afcdae15f102ffaccd2d42bffb70f2b3eff9919fe3c0bbc3a/google/python-adb/pull/172
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/03117f626d845c9afcdae15f102ffaccd2d42bffb70f2b3eff9919fe3c0bbc3a/google/python-adb/pull/172
og:image:altThis should fix an issue caused by the CryptographySigner initializer method, which opens the RSA public/private key files for reading in "text mode" instead of "binary mode". P...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameHalastra
hostnamegithub.com
expected-hostnamegithub.com
None3310064f35a62c06a4024ba37f41c06836f39376a095c2dfd2c4b693c34965be
turbo-cache-controlno-preview
go-importgithub.com/google/python-adb git https://github.com/google/python-adb.git
octolytics-dimension-user_id1342004
octolytics-dimension-user_logingoogle
octolytics-dimension-repository_id21404763
octolytics-dimension-repository_nwogoogle/python-adb
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21404763
octolytics-dimension-repository_network_root_nwogoogle/python-adb
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release67d5f8d1d53c3cc4f49fc3bb8029933c3dc219e6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/google/python-adb/pull/172#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2Fpython-adb%2Fpull%2F172
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2Fpython-adb%2Fpull%2F172
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=google%2Fpython-adb
Reloadhttps://patch-diff.githubusercontent.com/google/python-adb/pull/172
Reloadhttps://patch-diff.githubusercontent.com/google/python-adb/pull/172
Reloadhttps://patch-diff.githubusercontent.com/google/python-adb/pull/172
google https://patch-diff.githubusercontent.com/google
python-adbhttps://patch-diff.githubusercontent.com/google/python-adb
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fgoogle%2Fpython-adb
Fork 361 https://patch-diff.githubusercontent.com/login?return_to=%2Fgoogle%2Fpython-adb
Star 1.9k https://patch-diff.githubusercontent.com/login?return_to=%2Fgoogle%2Fpython-adb
Code https://patch-diff.githubusercontent.com/google/python-adb
Issues 52 https://patch-diff.githubusercontent.com/google/python-adb/issues
Pull requests 20 https://patch-diff.githubusercontent.com/google/python-adb/pulls
Actions https://patch-diff.githubusercontent.com/google/python-adb/actions
Projects 0 https://patch-diff.githubusercontent.com/google/python-adb/projects
Security 0 https://patch-diff.githubusercontent.com/google/python-adb/security
Insights https://patch-diff.githubusercontent.com/google/python-adb/pulse
Code https://patch-diff.githubusercontent.com/google/python-adb
Issues https://patch-diff.githubusercontent.com/google/python-adb/issues
Pull requests https://patch-diff.githubusercontent.com/google/python-adb/pulls
Actions https://patch-diff.githubusercontent.com/google/python-adb/actions
Projects https://patch-diff.githubusercontent.com/google/python-adb/projects
Security https://patch-diff.githubusercontent.com/google/python-adb/security
Insights https://patch-diff.githubusercontent.com/google/python-adb/pulse
Halastrahttps://patch-diff.githubusercontent.com/Halastra
google:masterhttps://patch-diff.githubusercontent.com/google/python-adb/tree/master
Halastra:bugfix_sign_cryptographyhttps://patch-diff.githubusercontent.com/Halastra/python-adb/tree/bugfix_sign_cryptography
Bugfix - sign_cryptography.CryptographySigner - keyfile opened as text (breaks on Python 3) https://patch-diff.githubusercontent.com/google/python-adb/pull/172#top
Halastrahttps://patch-diff.githubusercontent.com/Halastra
google:masterhttps://patch-diff.githubusercontent.com/google/python-adb/tree/master
Halastra:bugfix_sign_cryptographyhttps://patch-diff.githubusercontent.com/Halastra/python-adb/tree/bugfix_sign_cryptography
Conversation 6 https://patch-diff.githubusercontent.com/google/python-adb/pull/172
Commits 2 https://patch-diff.githubusercontent.com/google/python-adb/pull/172/commits
Checks 0 https://patch-diff.githubusercontent.com/google/python-adb/pull/172/checks
Files changed https://patch-diff.githubusercontent.com/google/python-adb/pull/172/files
Please reload this pagehttps://patch-diff.githubusercontent.com/google/python-adb/pull/172
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/google/python-adb/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/Halastra
Halastrahttps://patch-diff.githubusercontent.com/Halastra
Nov 28, 2019https://patch-diff.githubusercontent.com/google/python-adb/pull/172#issue-530042202
Please reload this pagehttps://patch-diff.githubusercontent.com/google/python-adb/pull/172
Halastrahttps://patch-diff.githubusercontent.com/Halastra
November 28, 2019 20:06https://patch-diff.githubusercontent.com/google/python-adb/pull/172#commits-pushed-816b92c
https://patch-diff.githubusercontent.com/Halastra
Merge pull requesthttps://patch-diff.githubusercontent.com/google/python-adb/pull/172/commits/816b92cb64476766008d851be82e59ac815db660
#1https://github.com/Halastra/python-adb/pull/1
from google/masterhttps://patch-diff.githubusercontent.com/google/python-adb/pull/172/commits/816b92cb64476766008d851be82e59ac815db660
816b92chttps://patch-diff.githubusercontent.com/google/python-adb/pull/172/commits/816b92cb64476766008d851be82e59ac815db660
https://patch-diff.githubusercontent.com/Halastra
Bugfix: CryptographySigner.__init__ fix Python 3 compatibilityhttps://patch-diff.githubusercontent.com/google/python-adb/pull/172/commits/50ce72218959eb2baf481aabb6cbfb4997b99640
50ce722https://patch-diff.githubusercontent.com/google/python-adb/pull/172/commits/50ce72218959eb2baf481aabb6cbfb4997b99640
https://patch-diff.githubusercontent.com/coveralls
coverallshttps://patch-diff.githubusercontent.com/coveralls
Nov 28, 2019https://patch-diff.githubusercontent.com/google/python-adb/pull/172#issuecomment-559580471
https://coveralls.io/builds/27310239
50ce722https://github.com/google/python-adb/commit/50ce72218959eb2baf481aabb6cbfb4997b99640
f4e597fhttps://github.com/google/python-adb/commit/f4e597fe55900651a8a91fccc1e09061fd96b5e9
Please reload this pagehttps://patch-diff.githubusercontent.com/google/python-adb/pull/172
https://patch-diff.githubusercontent.com/JeffLIrion
JeffLIrionhttps://patch-diff.githubusercontent.com/JeffLIrion
Nov 28, 2019https://patch-diff.githubusercontent.com/google/python-adb/pull/172#issuecomment-559600058
sign_cryptography.pyhttps://github.com/JeffLIrion/adb_shell/blob/f6bacb8ae2d978b257656995e91080ddf2d6e0c0/adb_shell/auth/sign_cryptography.py#L54
test_sign_cryptography.pyhttps://github.com/JeffLIrion/adb_shell/blob/f6bacb8ae2d978b257656995e91080ddf2d6e0c0/tests/test_sign_cryptography.py#L19
Please reload this pagehttps://patch-diff.githubusercontent.com/google/python-adb/pull/172
https://patch-diff.githubusercontent.com/Halastra
Halastrahttps://patch-diff.githubusercontent.com/Halastra
Nov 29, 2019https://patch-diff.githubusercontent.com/google/python-adb/pull/172#issuecomment-559870735
Please reload this pagehttps://patch-diff.githubusercontent.com/google/python-adb/pull/172
https://patch-diff.githubusercontent.com/JeffLIrion
JeffLIrionhttps://patch-diff.githubusercontent.com/JeffLIrion
Nov 30, 2019https://patch-diff.githubusercontent.com/google/python-adb/pull/172#issuecomment-559924372
Travis CI outputhttps://travis-ci.com/JeffLIrion/adb_shell/jobs/261764822
this draft pull requesthttps://github.com/JeffLIrion/adb_shell/pull/51
Please reload this pagehttps://patch-diff.githubusercontent.com/google/python-adb/pull/172
https://patch-diff.githubusercontent.com/Halastra
Halastrahttps://patch-diff.githubusercontent.com/Halastra
Dec 4, 2019https://patch-diff.githubusercontent.com/google/python-adb/pull/172#issuecomment-561672169
Please reload this pagehttps://patch-diff.githubusercontent.com/google/python-adb/pull/172
read from the devicehttps://github.com/google/python-adb/blob/40ffe13448857df6d2ce34450f4a68234ade5b87/adb/adb_protocol.py#L314
signedhttps://github.com/google/python-adb/blob/40ffe13448857df6d2ce34450f4a68234ade5b87/adb/adb_protocol.py#L326
answer on stackoverflowhttps://stackoverflow.com/a/56572141
intantiatehttps://github.com/JeffLIrion/adb_shell/blob/f6bacb8ae2d978b257656995e91080ddf2d6e0c0/adb_shell/auth/sign_cryptography.py#L84
Please reload this pagehttps://patch-diff.githubusercontent.com/google/python-adb/pull/172
https://patch-diff.githubusercontent.com/JeffLIrion
JeffLIrionhttps://patch-diff.githubusercontent.com/JeffLIrion
Dec 5, 2019https://patch-diff.githubusercontent.com/google/python-adb/pull/172#issuecomment-561950038
https://github.com/JeffLIrion/adb_shell/blob/cf246bfdc7f023d466fb4a2d899967c61c857af6/tests/test_sign_cryptography.py#L23https://github.com/JeffLIrion/adb_shell/blob/cf246bfdc7f023d466fb4a2d899967c61c857af6/tests/test_sign_cryptography.py#L23
Please reload this pagehttps://patch-diff.githubusercontent.com/google/python-adb/pull/172
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2Fpython-adb%2Fpull%2F172
Please reload this pagehttps://patch-diff.githubusercontent.com/google/python-adb/pull/172
https://patch-diff.githubusercontent.com/Halastra
https://patch-diff.githubusercontent.com/coveralls
https://patch-diff.githubusercontent.com/JeffLIrion
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.