| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a65947b2-eb1b-9071-2e49-9e071ddd403f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B6E4:29F76B:11AC60E:1885100:698DA947 |
| html-safe-nonce | a34e326d7c32a3fffc50469426ecb25c38fa12906ac8bf72b16f8686b904452b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNkU0OjI5Rjc2QjoxMUFDNjBFOjE4ODUxMDA6Njk4REE5NDciLCJ2aXNpdG9yX2lkIjoiMjg5MjYwMTM2Mzk5MTk5Njc0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2e93e7257a19027fa9a8465edd1e1fcaf4a4eb7477aa5d5b7afaffe89b2dd6c6 |
| hovercard-subject-tag | pull_request:220723275 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/google/jsonapi/159/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/55fd12e6663866a25506c8f7f4b4f12ad04a93b9fc45593b0496d7f2de6ef400/google/jsonapi/pull/159 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/55fd12e6663866a25506c8f7f4b4f12ad04a93b9fc45593b0496d7f2de6ef400/google/jsonapi/pull/159 |
| og:image:alt | This is #136 rebased on top of current google/jsonapi master after merge of #99.
Small adjustments were made,
Updated request.go to address change in structure of handle attribute block
Changed in... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | shwoodard |
| hostname | github.com |
| expected-hostname | github.com |
| None | 8c7947c0c592efeab6162b9909ad11fa43bff8b0cb5ff43273dc25e41979d43e |
| turbo-cache-control | no-preview |
| go-import | github.com/google/jsonapi git https://github.com/google/jsonapi.git |
| octolytics-dimension-user_id | 1342004 |
| octolytics-dimension-user_login | google |
| octolytics-dimension-repository_id | 38635217 |
| octolytics-dimension-repository_nwo | google/jsonapi |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 38635217 |
| octolytics-dimension-repository_network_root_nwo | google/jsonapi |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b22a9fbf4dea601ec149a9e5362e0558df79b505 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2Fjsonapi%2Fpull%2F159 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2Fjsonapi%2Fpull%2F159 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=google%2Fjsonapi |
| Reload | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159 |
| Reload | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159 |
| Reload | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159 |
|
google
| https://patch-diff.githubusercontent.com/google |
| jsonapi | https://patch-diff.githubusercontent.com/google/jsonapi |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Fgoogle%2Fjsonapi |
|
Fork
218
| https://patch-diff.githubusercontent.com/login?return_to=%2Fgoogle%2Fjsonapi |
|
Star
1.4k
| https://patch-diff.githubusercontent.com/login?return_to=%2Fgoogle%2Fjsonapi |
|
Code
| https://patch-diff.githubusercontent.com/google/jsonapi |
|
Issues
42
| https://patch-diff.githubusercontent.com/google/jsonapi/issues |
|
Pull requests
26
| https://patch-diff.githubusercontent.com/google/jsonapi/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/google/jsonapi/actions |
|
Projects
0
| https://patch-diff.githubusercontent.com/google/jsonapi/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/google/jsonapi/wiki |
|
Security
0
| https://patch-diff.githubusercontent.com/google/jsonapi/security |
|
Insights
| https://patch-diff.githubusercontent.com/google/jsonapi/pulse |
|
Code
| https://patch-diff.githubusercontent.com/google/jsonapi |
|
Issues
| https://patch-diff.githubusercontent.com/google/jsonapi/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/google/jsonapi/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/google/jsonapi/actions |
|
Projects
| https://patch-diff.githubusercontent.com/google/jsonapi/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/google/jsonapi/wiki |
|
Security
| https://patch-diff.githubusercontent.com/google/jsonapi/security |
|
Insights
| https://patch-diff.githubusercontent.com/google/jsonapi/pulse |
| shwoodard | https://patch-diff.githubusercontent.com/shwoodard |
| google:master | https://patch-diff.githubusercontent.com/google/jsonapi/tree/master |
| shwoodard:shwoodard-defined-type-attributes | https://patch-diff.githubusercontent.com/shwoodard/jsonapi/tree/shwoodard-defined-type-attributes |
|
Add support for attributes of custom defined types
| https://patch-diff.githubusercontent.com/google/jsonapi/pull/159#top |
| shwoodard | https://patch-diff.githubusercontent.com/shwoodard |
| google:master | https://patch-diff.githubusercontent.com/google/jsonapi/tree/master |
| shwoodard:shwoodard-defined-type-attributes | https://patch-diff.githubusercontent.com/shwoodard/jsonapi/tree/shwoodard-defined-type-attributes |
|
Conversation
6
| https://patch-diff.githubusercontent.com/google/jsonapi/pull/159 |
|
Commits
8
| https://patch-diff.githubusercontent.com/google/jsonapi/pull/159/commits |
|
Checks
0
| https://patch-diff.githubusercontent.com/google/jsonapi/pull/159/checks |
|
Files changed
| https://patch-diff.githubusercontent.com/google/jsonapi/pull/159/files |
| Please reload this page | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/google/jsonapi/pull/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/shwoodard |
| shwoodard | https://patch-diff.githubusercontent.com/shwoodard |
| Oct 5, 2018 | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159#issue-367238761 |
| Please reload this page | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159 |
| #136 | https://github.com/google/jsonapi/pull/136 |
| #99 | https://github.com/google/jsonapi/pull/99 |
| Please reload this page | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159 |
| October 5, 2018 07:10 | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159#commits-pushed-ccac636 |
|
| https://patch-diff.githubusercontent.com/shwoodard |
| Add support for attributes of custom defined types | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159/commits/ccac636b4bc988406af60cb0f7d60c668d714c40 |
| ccac636 | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159/commits/ccac636b4bc988406af60cb0f7d60c668d714c40 |
|
| https://patch-diff.githubusercontent.com/shwoodard |
| Fixed format types | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159/commits/87c6b8e5b5a83ae51b4de974b0262aa0e08b5c03 |
| 87c6b8e | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159/commits/87c6b8e5b5a83ae51b4de974b0262aa0e08b5c03 |
|
| https://patch-diff.githubusercontent.com/shwoodard |
| adjust test so values are like from a json payload | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159/commits/ab2491314841ff2f2d2633cbc136aa029317b21a |
| ab24913 | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159/commits/ab2491314841ff2f2d2633cbc136aa029317b21a |
| https://patch-diff.githubusercontent.com/shwoodard |
| shwoodard | https://patch-diff.githubusercontent.com/shwoodard |
| aren55555 | https://patch-diff.githubusercontent.com/aren55555 |
| October 5, 2018 14:35 | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159#event-1887319545 |
| https://patch-diff.githubusercontent.com/googlebot |
| googlebot | https://patch-diff.githubusercontent.com/googlebot |
| Oct 5, 2018 | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159#issuecomment-427387315 |
| Please reload this page | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159 |
| shwoodard | https://patch-diff.githubusercontent.com/shwoodard |
| October 5, 2018 08:56 | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159#commits-pushed-d05fcd9 |
|
| https://patch-diff.githubusercontent.com/shwoodard |
| one line method removed | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159/commits/d05fcd97df612b980b0bcecbfd8939dc22ecca32 |
| d05fcd9 | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159/commits/d05fcd97df612b980b0bcecbfd8939dc22ecca32 |
|
| https://patch-diff.githubusercontent.com/shwoodard |
| refactor, consistency, add test to ensure we don't need additional ty… | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159/commits/ed08d4f02a4dd48caa526df5702bdc3bc837b578 |
| ed08d4f | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159/commits/ed08d4f02a4dd48caa526df5702bdc3bc837b578 |
| https://patch-diff.githubusercontent.com/shwoodard |
| shwoodard | https://patch-diff.githubusercontent.com/shwoodard |
| Oct 5, 2018 | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159#issuecomment-427457414 |
| @CrushedPixel | https://github.com/CrushedPixel |
| Please reload this page | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159 |
| https://patch-diff.githubusercontent.com/CrushedPixel |
| CrushedPixel | https://patch-diff.githubusercontent.com/CrushedPixel |
| Oct 5, 2018 | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159#issuecomment-427471063 |
| Please reload this page | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159 |
| https://patch-diff.githubusercontent.com/shwoodard |
| shwoodard | https://patch-diff.githubusercontent.com/shwoodard |
| Oct 5, 2018 | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159#issuecomment-427493885 |
| @CrushedPixel | https://github.com/CrushedPixel |
| Please reload this page | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159 |
| https://patch-diff.githubusercontent.com/shwoodard |
| shwoodard | https://patch-diff.githubusercontent.com/shwoodard |
| Oct 5, 2018 | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159#issuecomment-427501793 |
| https://gist.github.com/shwoodard/9ea721936aee624f3f2f9e20db533961 | https://gist.github.com/shwoodard/9ea721936aee624f3f2f9e20db533961 |
| @aren55555 | https://github.com/aren55555 |
| @CrushedPixel | https://github.com/CrushedPixel |
| Please reload this page | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159 |
| https://patch-diff.githubusercontent.com/aren55555 |
| aren55555 | https://patch-diff.githubusercontent.com/aren55555 |
| Oct 8, 2018 | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159#issuecomment-427985099 |
| Please reload this page | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159 |
| shwoodard | https://patch-diff.githubusercontent.com/shwoodard |
| October 11, 2018 04:47 | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159#commits-pushed-9063570 |
|
| https://patch-diff.githubusercontent.com/shwoodard |
| run gofmt on package | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159/commits/906357051e782d7c89b49ab2d417933c7ff2a4f1 |
| 9063570 | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159/commits/906357051e782d7c89b49ab2d417933c7ff2a4f1 |
|
| https://patch-diff.githubusercontent.com/shwoodard |
| wrote failing test for example so removing from docs | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159/commits/1947fea11fff75b7d6977b488f6a09c166a3c055 |
| 1947fea | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159/commits/1947fea11fff75b7d6977b488f6a09c166a3c055 |
|
| https://patch-diff.githubusercontent.com/shwoodard |
| add documentation for primative custom types only | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159/commits/e22856db883897c7a5b1cb4fb606e50682498970 |
| e22856d | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159/commits/e22856db883897c7a5b1cb4fb606e50682498970 |
| https://patch-diff.githubusercontent.com/shwoodard |
| shwoodard | https://patch-diff.githubusercontent.com/shwoodard |
| 9246c91 | https://patch-diff.githubusercontent.com/google/jsonapi/commit/9246c912f5ff63f2e315efd188d254f93e5598f0 |
| Oct 15, 2018 | https://github.com/google/jsonapi/pull/159#event-1905439279 |
| https://patch-diff.githubusercontent.com/botverse |
| botverse | https://patch-diff.githubusercontent.com/botverse |
|
Oct 16, 2018
| https://patch-diff.githubusercontent.com/google/jsonapi/pull/159#ref-issue-370641166 |
|
Are custom attribute types in the roadmap anymore?
#164
| https://patch-diff.githubusercontent.com/google/jsonapi/issues/164 |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2Fjsonapi%2Fpull%2F159 |
|
| https://patch-diff.githubusercontent.com/aren55555 |
|
aren55555
| https://patch-diff.githubusercontent.com/aren55555 |
| Please reload this page | https://patch-diff.githubusercontent.com/google/jsonapi/pull/159 |
|
| https://patch-diff.githubusercontent.com/shwoodard |
|
| https://patch-diff.githubusercontent.com/googlebot |
|
| https://patch-diff.githubusercontent.com/CrushedPixel |
|
| https://patch-diff.githubusercontent.com/aren55555 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |