Title: Possible leak in double-booking cursor · Issue #31 · gitpython-developers/smmap · GitHub
Open Graph Title: Possible leak in double-booking cursor · Issue #31 · gitpython-developers/smmap
X Title: Possible leak in double-booking cursor · Issue #31 · gitpython-developers/smmap
Description: Probably 70fae1f made a double acounting of region-clients in smmap.mman.py#L136, where a "manual" increment_client_count() follows a _obtain_region() which it also increments the client-count. From gitdb TC gitdb.test.test_pack:TestPack...
Open Graph Description: Probably 70fae1f made a double acounting of region-clients in smmap.mman.py#L136, where a "manual" increment_client_count() follows a _obtain_region() which it also increments the client-count. Fro...
X Description: Probably 70fae1f made a double acounting of region-clients in smmap.mman.py#L136, where a "manual" increment_client_count() follows a _obtain_region() which it also increments the client-...
Opengraph URL: https://github.com/gitpython-developers/smmap/issues/31
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Possible leak in double-booking cursor","articleBody":"Probably 70fae1f98bb7 made a double acounting of region-clients in [`smmap.mman.py#L136`](https://github.com/gitpython-developers/smmap/blob/master/smmap/mman.py#L136), where a \"manual\" `increment_client_count()` follows a `_obtain_region()` which it also increments the client-count.\n\nFrom _gitdb_ TC `gitdb.test.test_pack:TestPack.test_pack_entity()` I can see that this is indeed the case, where it is increased 2 x 3 times for 3 mmaps, while it is decremented just 3 times.\n","author":{"url":"https://github.com/ankostis","@type":"Person","name":"ankostis"},"datePublished":"2016-10-23T23:57:22.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":8},"url":"https://github.com/31/smmap/issues/31"}| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:8ceea43d-08dc-a3d9-5d92-2347a798c2d2 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 833E:26AEF0:1623B70:1DF955C:696EA9D8 |
| html-safe-nonce | 038c74c12122d27fe834d1684b9fe522b7caf3b8e0f6ae3a4aaca3105a4e90da |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzNFOjI2QUVGMDoxNjIzQjcwOjFERjk1NUM6Njk2RUE5RDgiLCJ2aXNpdG9yX2lkIjoiMTgzMTE1MTk5ODM4NDEyMjMyOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 90d8450c25d094bf51b492819f8ca032751bb4db6920e96e5961689e542cc2df |
| hovercard-subject-tag | issue:184725334 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/gitpython-developers/smmap/31/issue_layout |
| twitter:image | https://opengraph.githubassets.com/010fae9be792a7542a4de460767a499dc5b8dc91828ab690f53163c56da35d87/gitpython-developers/smmap/issues/31 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/010fae9be792a7542a4de460767a499dc5b8dc91828ab690f53163c56da35d87/gitpython-developers/smmap/issues/31 |
| og:image:alt | Probably 70fae1f made a double acounting of region-clients in smmap.mman.py#L136, where a "manual" increment_client_count() follows a _obtain_region() which it also increments the client-count. Fro... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ankostis |
| hostname | github.com |
| expected-hostname | github.com |
| None | fdad15fd2ad43212aa8b8be5f2c2725550f8374ceeeb154a999ad9145b43f3f7 |
| turbo-cache-control | no-preview |
| go-import | github.com/gitpython-developers/smmap git https://github.com/gitpython-developers/smmap.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1865144 |
| octolytics-dimension-repository_nwo | gitpython-developers/smmap |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1865144 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/smmap |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 27b23bc056eb973d350fc95afc848757edb9e7a9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width