Title: Add comprehensive tests for feature-flagged tool handling by Copilot · Pull Request #1747 · github/github-mcp-server · GitHub
Open Graph Title: Add comprehensive tests for feature-flagged tool handling by Copilot · Pull Request #1747 · github/github-mcp-server
X Title: Add comprehensive tests for feature-flagged tool handling by Copilot · Pull Request #1747 · github/github-mcp-server
Description: Summary Adds regression tests for feature flag tool filtering to prevent issues like copilot-cli#878 (get_job_logs tool call failures due to incorrect filtering of same-name tools). Why PR #1719 fixed a bug where filterToolsByName only returned the first matching tool, breaking feature flag filtering when renaming tools. This PR adds generic tests to prevent regression. What changed Added 4 generic test suites validating feature flag behavior across all combinations: TestFeatureFlaggedToolsAreMutuallyExclusive (pkg/github/tools_validation_test.go): Validates proper feature flag configuration ensuring no omissions, incorrect activations, or duplicate active tools across all flag states TestToolsList_WithFeatureFlags (pkg/inventory/registry_test.go): Tests tools/list endpoint with various flag states, ensuring no duplicates or omissions TestToolsCall_WithFeatureFlags (pkg/inventory/registry_test.go): Tests tools/call (ForMCPRequest) with feature flags TestNoDuplicateToolsInAnyFeatureFlagCombination (pkg/inventory/registry_test.go): Exhaustive test of all 2^n flag combinations Manually validated get_job_logs tool works correctly with real GitHub Actions workflows MCP impact No tool or API changes - Only test coverage added Prompts tested (tool changes only) N/A Security / limits No security or limits impact Tool renaming I am not renaming tools as part of this PR Lint & tests Linted locally with ./script/lint Tested locally with ./script/test Docs Not needed Original prompt Please look into github/copilot-cli#878 and see if you need to patch anything and test anything to safe;y handle same-name tool renames, and listing and calling tools with various feature flag states etc. this should be reproducable and fixable, with prevention of regression if we get things. We could also add a test that validates that there are no duplicate tools with any combo of feature flags etc too. 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Open Graph Description: Summary Adds regression tests for feature flag tool filtering to prevent issues like copilot-cli#878 (get_job_logs tool call failures due to incorrect filtering of same-name tools). Why PR #1719 fi...
X Description: Summary Adds regression tests for feature flag tool filtering to prevent issues like copilot-cli#878 (get_job_logs tool call failures due to incorrect filtering of same-name tools). Why PR #1719 fi...
Opengraph URL: https://github.com/github/github-mcp-server/pull/1747
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:8fe3a5dd-0065-a731-d4b1-bc90a55915c2 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | A40A:161581:4716B56:5D8D59B:6992F038 |
| html-safe-nonce | 4ccb2b63cf7820c6c8dca08d3725988f304c57058953301943f12b133b28981e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDBBOjE2MTU4MTo0NzE2QjU2OjVEOEQ1OUI6Njk5MkYwMzgiLCJ2aXNpdG9yX2lkIjoiODYzMzk3NjU5NzE3MzY5NDUyMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 26baabebd73366823f19a57359920093adfb289b9a54b172da4790f174ed1570 |
| hovercard-subject-tag | pull_request:3148900625 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/github-mcp-server/pull/1747/checks |
| twitter:image | https://avatars.githubusercontent.com/in/1143301?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/in/1143301?s=400&v=4 |
| og:image:alt | Summary Adds regression tests for feature flag tool filtering to prevent issues like copilot-cli#878 (get_job_logs tool call failures due to incorrect filtering of same-name tools). Why PR #1719 fi... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 01ab16879a3159e6f0717ab948b9b562e162a6aafd1f4393b786b07b747df244 |
| turbo-cache-control | no-preview |
| go-import | github.com/github/github-mcp-server git https://github.com/github/github-mcp-server.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 942771284 |
| octolytics-dimension-repository_nwo | github/github-mcp-server |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 942771284 |
| octolytics-dimension-repository_network_root_nwo | github/github-mcp-server |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b1570f3928bef80fa5fc7890ce0942e9b696ad9d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width