René's URL Explorer Experiment


Title: Recognize Kind regards as a signature by askehansen · Pull Request #71 · github/email_reply_parser · GitHub

Open Graph Title: Recognize Kind regards as a signature by askehansen · Pull Request #71 · github/email_reply_parser

X Title: Recognize Kind regards as a signature by askehansen · Pull Request #71 · github/email_reply_parser

Description: This pull request fixes #70 All I did was update the SIGNATURE regex to include multiple kind of "Kind regards", including one in danish: Kind regards Warm regards Best regards Med venlig hilsen https://github.com/github/email_reply_parser/compare/master...askehansen:kind-regards-signature?expand=1#diff-240c7196a90b5bff539340e9dbb77926R135 A better solution would be to keep these in a list and provide an interface for people to extend it in their codebase and locale.

Open Graph Description: This pull request fixes #70 All I did was update the SIGNATURE regex to include multiple kind of "Kind regards", including one in danish: Kind regards Warm regards Best regards Med venlig...

X Description: This pull request fixes #70 All I did was update the SIGNATURE regex to include multiple kind of "Kind regards", including one in danish: Kind regards Warm regards Best regards Me...

Opengraph URL: https://github.com/github/email_reply_parser/pull/71

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b884ea79-4154-24c8-ecb2-746e1b2b85c1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9B54:3ECBC5:300F3F:426288:69810CBD
html-safe-noncec1a8847ed87bd730426d433b1cec933bb5fdac397078430d86f1fe9b6a1c4db3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjU0OjNFQ0JDNTozMDBGM0Y6NDI2Mjg4OjY5ODEwQ0JEIiwidmlzaXRvcl9pZCI6IjEwMjAwMDk2NTQ1OTMzMjYyNjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac910d9e7207eb67213443f7fb24a705ba5f668f049ca7d0c428d53645f5d8a733
hovercard-subject-tagpull_request:263600158
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github/email_reply_parser/pull/71/files
twitter:imagehttps://avatars.githubusercontent.com/u/895373?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/895373?s=400&v=4
og:image:altThis pull request fixes #70 All I did was update the SIGNATURE regex to include multiple kind of "Kind regards", including one in danish: Kind regards Warm regards Best regards Med venlig...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None39fe8101494cbb823c09b619b68c80cd4d05ab7279997038dbe06bb91608abe1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/github/email_reply_parser git https://github.com/github/email_reply_parser.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id1400605
octolytics-dimension-repository_nwogithub/email_reply_parser
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1400605
octolytics-dimension-repository_network_root_nwogithub/email_reply_parser
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released5b34a4e4898b066c629879feb4b184bc471d6a7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Femail_reply_parser%2Fpull%2F71%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Femail_reply_parser%2Fpull%2F71%2Ffiles
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github%2Femail_reply_parser
Reloadhttps://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files
Reloadhttps://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files
Reloadhttps://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files
github https://patch-diff.githubusercontent.com/github
email_reply_parserhttps://patch-diff.githubusercontent.com/github/email_reply_parser
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fgithub%2Femail_reply_parser
Fork 156 https://patch-diff.githubusercontent.com/login?return_to=%2Fgithub%2Femail_reply_parser
Star 701 https://patch-diff.githubusercontent.com/login?return_to=%2Fgithub%2Femail_reply_parser
Code https://patch-diff.githubusercontent.com/github/email_reply_parser
Issues 20 https://patch-diff.githubusercontent.com/github/email_reply_parser/issues
Pull requests 8 https://patch-diff.githubusercontent.com/github/email_reply_parser/pulls
Actions https://patch-diff.githubusercontent.com/github/email_reply_parser/actions
Projects 0 https://patch-diff.githubusercontent.com/github/email_reply_parser/projects
Models https://patch-diff.githubusercontent.com/github/email_reply_parser/models
Security 0 https://patch-diff.githubusercontent.com/github/email_reply_parser/security
Insights https://patch-diff.githubusercontent.com/github/email_reply_parser/pulse
Code https://patch-diff.githubusercontent.com/github/email_reply_parser
Issues https://patch-diff.githubusercontent.com/github/email_reply_parser/issues
Pull requests https://patch-diff.githubusercontent.com/github/email_reply_parser/pulls
Actions https://patch-diff.githubusercontent.com/github/email_reply_parser/actions
Projects https://patch-diff.githubusercontent.com/github/email_reply_parser/projects
Models https://patch-diff.githubusercontent.com/github/email_reply_parser/models
Security https://patch-diff.githubusercontent.com/github/email_reply_parser/security
Insights https://patch-diff.githubusercontent.com/github/email_reply_parser/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fgithub%2Femail_reply_parser%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fgithub%2Femail_reply_parser%2Fissues%2Fnew%2Fchoose
askehansenhttps://patch-diff.githubusercontent.com/askehansen
github:masterhttps://patch-diff.githubusercontent.com/github/email_reply_parser/tree/master
askehansen:kind-regards-signaturehttps://patch-diff.githubusercontent.com/askehansen/email_reply_parser/tree/kind-regards-signature
Conversation 7 https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71
Commits 8 https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits
Checks 0 https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/checks
Files changed https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files
Please reload this pagehttps://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files
Recognize Kind regards as a signature https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#top
Show all changes 8 commits https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files
3943b0e added test for email with regards askehansen Mar 22, 2019 https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/3943b0e03ca118e001b157e894a8e915a07eb544
6f55573 added regards to to regex askehansen Mar 22, 2019 https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/6f555731c47a38494d371fb7e1bb0c7b1dcc6de5
59a09c9 accedentally removed EMPTY askehansen Mar 22, 2019 https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/59a09c98a9685b199f2f10f0d9e38b05c061b4f6
de92b4b create a regards fragment askehansen Apr 3, 2019 https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/de92b4ba92af824b7f23313d8effabf8be7571df
3d7e4b6 create regards regex from array and ignore case askehansen Apr 3, 2019 https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/3d7e4b691641c85893e67d2f13863b3d64d3cde1
cdb2aaf added configuration class askehansen Apr 3, 2019 https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/cdb2aafb942244e5912ff8a08811d962adcf6df8
b9aeb3f create regards regex at runtime askehansen Apr 3, 2019 https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/b9aeb3f4ac4947182b7b42b94861799af02f6619
8c8c036 rename test askehansen Apr 3, 2019 https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/8c8c036085d73b34b4b3744bb781232d244c516a
Clear filters https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files
Please reload this pagehttps://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files
Please reload this pagehttps://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files
email_reply_parser.gemspec https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-c6fb6d2afc194ac8daf24ca10900fae66abf946b694b01f4e93b3b53b6f316e3
email_reply_parser.rb https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba
email_reply_parser_test.rb https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-91557b697038f1d833cde2214164cd904ac8c9e0da353a6d843afda1e2085903
email_with_kind_regards.txt https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-a2cf9c27d365dc456f32e04c4932a952374aca9ba2b309f29bffb18864d31267
email_reply_parser.gemspechttps://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-c6fb6d2afc194ac8daf24ca10900fae66abf946b694b01f4e93b3b53b6f316e3
View file https://patch-diff.githubusercontent.com/github/email_reply_parser/blob/8c8c036085d73b34b4b3744bb781232d244c516a/email_reply_parser.gemspec
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-c6fb6d2afc194ac8daf24ca10900fae66abf946b694b01f4e93b3b53b6f316e3
https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-c6fb6d2afc194ac8daf24ca10900fae66abf946b694b01f4e93b3b53b6f316e3
lib/email_reply_parser.rbhttps://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba
View file https://patch-diff.githubusercontent.com/github/email_reply_parser/blob/8c8c036085d73b34b4b3744bb781232d244c516a/lib/email_reply_parser.rb
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba
https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba
mattyohohttps://patch-diff.githubusercontent.com/mattyoho
Apr 10, 2019https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#r273757760
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files
https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba
https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba
mattyohohttps://patch-diff.githubusercontent.com/mattyoho
Apr 10, 2019https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#r273758115
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files
https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba
mattyohohttps://patch-diff.githubusercontent.com/mattyoho
Apr 10, 2019https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#r273758543
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files
https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba
https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba
https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba
https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba
https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba
https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba
test/email_reply_parser_test.rbhttps://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-91557b697038f1d833cde2214164cd904ac8c9e0da353a6d843afda1e2085903
View file https://patch-diff.githubusercontent.com/github/email_reply_parser/blob/8c8c036085d73b34b4b3744bb781232d244c516a/test/email_reply_parser_test.rb
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-91557b697038f1d833cde2214164cd904ac8c9e0da353a6d843afda1e2085903
https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-91557b697038f1d833cde2214164cd904ac8c9e0da353a6d843afda1e2085903
https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-91557b697038f1d833cde2214164cd904ac8c9e0da353a6d843afda1e2085903
https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-91557b697038f1d833cde2214164cd904ac8c9e0da353a6d843afda1e2085903
test/emails/email_with_kind_regards.txthttps://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-a2cf9c27d365dc456f32e04c4932a952374aca9ba2b309f29bffb18864d31267
View file https://patch-diff.githubusercontent.com/github/email_reply_parser/blob/8c8c036085d73b34b4b3744bb781232d244c516a/test/emails/email_with_kind_regards.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.