| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b884ea79-4154-24c8-ecb2-746e1b2b85c1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9B54:3ECBC5:300F3F:426288:69810CBD |
| html-safe-nonce | c1a8847ed87bd730426d433b1cec933bb5fdac397078430d86f1fe9b6a1c4db3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjU0OjNFQ0JDNTozMDBGM0Y6NDI2Mjg4OjY5ODEwQ0JEIiwidmlzaXRvcl9pZCI6IjEwMjAwMDk2NTQ1OTMzMjYyNjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 910d9e7207eb67213443f7fb24a705ba5f668f049ca7d0c428d53645f5d8a733 |
| hovercard-subject-tag | pull_request:263600158 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/email_reply_parser/pull/71/files |
| twitter:image | https://avatars.githubusercontent.com/u/895373?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/895373?s=400&v=4 |
| og:image:alt | This pull request fixes #70
All I did was update the SIGNATURE regex to include multiple kind of "Kind regards", including one in danish:
Kind regards
Warm regards
Best regards
Med venlig... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 39fe8101494cbb823c09b619b68c80cd4d05ab7279997038dbe06bb91608abe1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/github/email_reply_parser git https://github.com/github/email_reply_parser.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 1400605 |
| octolytics-dimension-repository_nwo | github/email_reply_parser |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1400605 |
| octolytics-dimension-repository_network_root_nwo | github/email_reply_parser |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d5b34a4e4898b066c629879feb4b184bc471d6a7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Femail_reply_parser%2Fpull%2F71%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Femail_reply_parser%2Fpull%2F71%2Ffiles |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github%2Femail_reply_parser |
| Reload | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files |
| Reload | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files |
| Reload | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files |
|
github
| https://patch-diff.githubusercontent.com/github |
| email_reply_parser | https://patch-diff.githubusercontent.com/github/email_reply_parser |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Fgithub%2Femail_reply_parser |
|
Fork
156
| https://patch-diff.githubusercontent.com/login?return_to=%2Fgithub%2Femail_reply_parser |
|
Star
701
| https://patch-diff.githubusercontent.com/login?return_to=%2Fgithub%2Femail_reply_parser |
|
Code
| https://patch-diff.githubusercontent.com/github/email_reply_parser |
|
Issues
20
| https://patch-diff.githubusercontent.com/github/email_reply_parser/issues |
|
Pull requests
8
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/github/email_reply_parser/actions |
|
Projects
0
| https://patch-diff.githubusercontent.com/github/email_reply_parser/projects |
|
Models
| https://patch-diff.githubusercontent.com/github/email_reply_parser/models |
|
Security
0
| https://patch-diff.githubusercontent.com/github/email_reply_parser/security |
|
Insights
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pulse |
|
Code
| https://patch-diff.githubusercontent.com/github/email_reply_parser |
|
Issues
| https://patch-diff.githubusercontent.com/github/email_reply_parser/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/github/email_reply_parser/actions |
|
Projects
| https://patch-diff.githubusercontent.com/github/email_reply_parser/projects |
|
Models
| https://patch-diff.githubusercontent.com/github/email_reply_parser/models |
|
Security
| https://patch-diff.githubusercontent.com/github/email_reply_parser/security |
|
Insights
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pulse |
| Sign up for GitHub
| https://patch-diff.githubusercontent.com/signup?return_to=%2Fgithub%2Femail_reply_parser%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=%2Fgithub%2Femail_reply_parser%2Fissues%2Fnew%2Fchoose |
| askehansen | https://patch-diff.githubusercontent.com/askehansen |
| github:master | https://patch-diff.githubusercontent.com/github/email_reply_parser/tree/master |
| askehansen:kind-regards-signature | https://patch-diff.githubusercontent.com/askehansen/email_reply_parser/tree/kind-regards-signature |
|
Conversation
7
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71 |
|
Commits
8
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits |
|
Checks
0
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/checks |
|
Files changed
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files |
| Please reload this page | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files |
|
Recognize Kind regards as a signature
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#top |
|
Show all changes
8 commits
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files |
|
3943b0e
added test for email with regards
askehansen Mar 22, 2019
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/3943b0e03ca118e001b157e894a8e915a07eb544 |
|
6f55573
added regards to to regex
askehansen Mar 22, 2019
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/6f555731c47a38494d371fb7e1bb0c7b1dcc6de5 |
|
59a09c9
accedentally removed EMPTY
askehansen Mar 22, 2019
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/59a09c98a9685b199f2f10f0d9e38b05c061b4f6 |
|
de92b4b
create a regards fragment
askehansen Apr 3, 2019
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/de92b4ba92af824b7f23313d8effabf8be7571df |
|
3d7e4b6
create regards regex from array and ignore case
askehansen Apr 3, 2019
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/3d7e4b691641c85893e67d2f13863b3d64d3cde1 |
|
cdb2aaf
added configuration class
askehansen Apr 3, 2019
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/cdb2aafb942244e5912ff8a08811d962adcf6df8 |
|
b9aeb3f
create regards regex at runtime
askehansen Apr 3, 2019
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/b9aeb3f4ac4947182b7b42b94861799af02f6619 |
|
8c8c036
rename test
askehansen Apr 3, 2019
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/8c8c036085d73b34b4b3744bb781232d244c516a |
|
Clear filters
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files |
| Please reload this page | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files |
| Please reload this page | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files |
|
email_reply_parser.gemspec
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-c6fb6d2afc194ac8daf24ca10900fae66abf946b694b01f4e93b3b53b6f316e3 |
|
email_reply_parser.rb
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba |
|
email_reply_parser_test.rb
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-91557b697038f1d833cde2214164cd904ac8c9e0da353a6d843afda1e2085903 |
|
email_with_kind_regards.txt
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-a2cf9c27d365dc456f32e04c4932a952374aca9ba2b309f29bffb18864d31267 |
| email_reply_parser.gemspec | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-c6fb6d2afc194ac8daf24ca10900fae66abf946b694b01f4e93b3b53b6f316e3 |
|
View file
| https://patch-diff.githubusercontent.com/github/email_reply_parser/blob/8c8c036085d73b34b4b3744bb781232d244c516a/email_reply_parser.gemspec |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-c6fb6d2afc194ac8daf24ca10900fae66abf946b694b01f4e93b3b53b6f316e3 |
|
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-c6fb6d2afc194ac8daf24ca10900fae66abf946b694b01f4e93b3b53b6f316e3 |
| lib/email_reply_parser.rb | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba |
|
View file
| https://patch-diff.githubusercontent.com/github/email_reply_parser/blob/8c8c036085d73b34b4b3744bb781232d244c516a/lib/email_reply_parser.rb |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba |
|
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba |
| mattyoho | https://patch-diff.githubusercontent.com/mattyoho |
| Apr 10, 2019 | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#r273757760 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files |
|
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba |
|
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba |
| mattyoho | https://patch-diff.githubusercontent.com/mattyoho |
| Apr 10, 2019 | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#r273758115 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files |
|
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba |
| mattyoho | https://patch-diff.githubusercontent.com/mattyoho |
| Apr 10, 2019 | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#r273758543 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files |
|
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba |
|
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba |
|
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba |
|
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba |
|
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba |
|
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba |
| test/email_reply_parser_test.rb | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-91557b697038f1d833cde2214164cd904ac8c9e0da353a6d843afda1e2085903 |
|
View file
| https://patch-diff.githubusercontent.com/github/email_reply_parser/blob/8c8c036085d73b34b4b3744bb781232d244c516a/test/email_reply_parser_test.rb |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-91557b697038f1d833cde2214164cd904ac8c9e0da353a6d843afda1e2085903 |
|
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-91557b697038f1d833cde2214164cd904ac8c9e0da353a6d843afda1e2085903 |
|
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-91557b697038f1d833cde2214164cd904ac8c9e0da353a6d843afda1e2085903 |
|
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-91557b697038f1d833cde2214164cd904ac8c9e0da353a6d843afda1e2085903 |
| test/emails/email_with_kind_regards.txt | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files#diff-a2cf9c27d365dc456f32e04c4932a952374aca9ba2b309f29bffb18864d31267 |
|
View file
| https://patch-diff.githubusercontent.com/github/email_reply_parser/blob/8c8c036085d73b34b4b3744bb781232d244c516a/test/emails/email_with_kind_regards.txt |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/{{ revealButtonHref }} |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |