| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5fc8bd7d-6f1e-bc0c-84c6-c91dbaeb30a9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B00E:B61A7:1729F9E:2012C75:6980CBC0 |
| html-safe-nonce | a2a3f2043c6951ec3d821494088c4fbe410015a82515795b7d9c2618be8e588d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDBFOkI2MUE3OjE3MjlGOUU6MjAxMkM3NTo2OTgwQ0JDMCIsInZpc2l0b3JfaWQiOiI4MDk1MDI4MTgzNzIxNjI2NTYwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 5e3f3040eeb8a739220cf76bc54639ac00f7adebe52a61e63ae0cf38cfe98372 |
| hovercard-subject-tag | pull_request:263600158 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/github/email_reply_parser/71/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e54bb088e707fa2d73b0037f9b5dbeddb7e38f805c54b2e9c4541a91f643773d/github/email_reply_parser/pull/71 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e54bb088e707fa2d73b0037f9b5dbeddb7e38f805c54b2e9c4541a91f643773d/github/email_reply_parser/pull/71 |
| og:image:alt | This pull request fixes #70
All I did was update the SIGNATURE regex to include multiple kind of "Kind regards", including one in danish:
Kind regards
Warm regards
Best regards
Med venlig... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | askehansen |
| hostname | github.com |
| expected-hostname | github.com |
| None | c940d5e308643c0003d2824389ea8281bcaae0a9a0d07438e3fb5e0bdc4fef12 |
| turbo-cache-control | no-preview |
| go-import | github.com/github/email_reply_parser git https://github.com/github/email_reply_parser.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 1400605 |
| octolytics-dimension-repository_nwo | github/email_reply_parser |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1400605 |
| octolytics-dimension-repository_network_root_nwo | github/email_reply_parser |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bb3d0fe9b8e408797775c5db420b1ee5ff06e4d0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Femail_reply_parser%2Fpull%2F71 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Femail_reply_parser%2Fpull%2F71 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=github%2Femail_reply_parser |
| Reload | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71 |
| Reload | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71 |
| Reload | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71 |
|
github
| https://patch-diff.githubusercontent.com/github |
| email_reply_parser | https://patch-diff.githubusercontent.com/github/email_reply_parser |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Fgithub%2Femail_reply_parser |
|
Fork
156
| https://patch-diff.githubusercontent.com/login?return_to=%2Fgithub%2Femail_reply_parser |
|
Star
701
| https://patch-diff.githubusercontent.com/login?return_to=%2Fgithub%2Femail_reply_parser |
|
Code
| https://patch-diff.githubusercontent.com/github/email_reply_parser |
|
Issues
20
| https://patch-diff.githubusercontent.com/github/email_reply_parser/issues |
|
Pull requests
8
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/github/email_reply_parser/actions |
|
Projects
0
| https://patch-diff.githubusercontent.com/github/email_reply_parser/projects |
|
Models
| https://patch-diff.githubusercontent.com/github/email_reply_parser/models |
|
Security
0
| https://patch-diff.githubusercontent.com/github/email_reply_parser/security |
|
Insights
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pulse |
|
Code
| https://patch-diff.githubusercontent.com/github/email_reply_parser |
|
Issues
| https://patch-diff.githubusercontent.com/github/email_reply_parser/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/github/email_reply_parser/actions |
|
Projects
| https://patch-diff.githubusercontent.com/github/email_reply_parser/projects |
|
Models
| https://patch-diff.githubusercontent.com/github/email_reply_parser/models |
|
Security
| https://patch-diff.githubusercontent.com/github/email_reply_parser/security |
|
Insights
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pulse |
| Sign up for GitHub
| https://patch-diff.githubusercontent.com/signup?return_to=%2Fgithub%2Femail_reply_parser%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=%2Fgithub%2Femail_reply_parser%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71#issue-comment-box |
| askehansen | https://patch-diff.githubusercontent.com/askehansen |
| github:master | https://patch-diff.githubusercontent.com/github/email_reply_parser/tree/master |
| askehansen:kind-regards-signature | https://patch-diff.githubusercontent.com/askehansen/email_reply_parser/tree/kind-regards-signature |
|
Recognize Kind regards as a signature
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71#top |
| askehansen | https://patch-diff.githubusercontent.com/askehansen |
| github:master | https://patch-diff.githubusercontent.com/github/email_reply_parser/tree/master |
| askehansen:kind-regards-signature | https://patch-diff.githubusercontent.com/askehansen/email_reply_parser/tree/kind-regards-signature |
|
Conversation
7
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71 |
|
Commits
8
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits |
|
Checks
0
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/checks |
|
Files changed
4
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/askehansen |
| askehansen | https://patch-diff.githubusercontent.com/askehansen |
| Mar 22, 2019 | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71#issue-424194283 |
| #70 | https://github.com/github/email_reply_parser/issues/70 |
| https://github.com/github/email_reply_parser/compare/master...askehansen:kind-regards-signature?expand=1#diff-240c7196a90b5bff539340e9dbb77926R135 | https://github.com/github/email_reply_parser/compare/master...askehansen:kind-regards-signature?expand=1#diff-240c7196a90b5bff539340e9dbb77926R135 |
| Please reload this page | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71 |
| askehansen | https://patch-diff.githubusercontent.com/askehansen |
| March 22, 2019 12:14 | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71#commits-pushed-3943b0e |
|
| https://patch-diff.githubusercontent.com/askehansen |
| added test for email with regards | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/3943b0e03ca118e001b157e894a8e915a07eb544 |
| 3943b0e | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/3943b0e03ca118e001b157e894a8e915a07eb544 |
|
| https://patch-diff.githubusercontent.com/askehansen |
| added regards to to regex | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/6f555731c47a38494d371fb7e1bb0c7b1dcc6de5 |
| 6f55573 | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/6f555731c47a38494d371fb7e1bb0c7b1dcc6de5 |
|
| https://patch-diff.githubusercontent.com/askehansen |
| accedentally removed EMPTY | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/59a09c98a9685b199f2f10f0d9e38b05c061b4f6 |
| 59a09c9 | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/59a09c98a9685b199f2f10f0d9e38b05c061b4f6 |
| https://patch-diff.githubusercontent.com/mattyoho |
| mattyoho | https://patch-diff.githubusercontent.com/mattyoho |
| Mar 22, 2019 | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71#issuecomment-475621001 |
| @askehansen | https://github.com/askehansen |
| Please reload this page | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71 |
| https://patch-diff.githubusercontent.com/askehansen |
| askehansen | https://patch-diff.githubusercontent.com/askehansen |
| Mar 26, 2019 | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71#issuecomment-476585570 |
| Please reload this page | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71 |
| askehansen | https://patch-diff.githubusercontent.com/askehansen |
| April 3, 2019 10:39 | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71#commits-pushed-de92b4b |
|
| https://patch-diff.githubusercontent.com/askehansen |
| create a regards fragment | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/de92b4ba92af824b7f23313d8effabf8be7571df |
| de92b4b | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/de92b4ba92af824b7f23313d8effabf8be7571df |
|
| https://patch-diff.githubusercontent.com/askehansen |
| create regards regex from array and ignore case | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/3d7e4b691641c85893e67d2f13863b3d64d3cde1 |
| 3d7e4b6 | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/3d7e4b691641c85893e67d2f13863b3d64d3cde1 |
|
| https://patch-diff.githubusercontent.com/askehansen |
| added configuration class | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/cdb2aafb942244e5912ff8a08811d962adcf6df8 |
| cdb2aaf | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/cdb2aafb942244e5912ff8a08811d962adcf6df8 |
|
| https://patch-diff.githubusercontent.com/askehansen |
| create regards regex at runtime | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/b9aeb3f4ac4947182b7b42b94861799af02f6619 |
| b9aeb3f | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/b9aeb3f4ac4947182b7b42b94861799af02f6619 |
|
| https://patch-diff.githubusercontent.com/askehansen |
| rename test | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/8c8c036085d73b34b4b3744bb781232d244c516a |
| 8c8c036 | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/commits/8c8c036085d73b34b4b3744bb781232d244c516a |
| https://patch-diff.githubusercontent.com/askehansen |
| askehansen | https://patch-diff.githubusercontent.com/askehansen |
| Apr 3, 2019 | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71#issuecomment-479425357 |
| @mattyoho | https://github.com/mattyoho |
| Please reload this page | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71 |
| https://patch-diff.githubusercontent.com/mattyoho |
| mattyoho | https://patch-diff.githubusercontent.com/mattyoho |
|
Apr 10, 2019
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71#pullrequestreview-224720437 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files/8c8c036085d73b34b4b3744bb781232d244c516a |
| mattyoho | https://patch-diff.githubusercontent.com/mattyoho |
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71#pullrequestreview-224720437 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @askehansen | https://github.com/askehansen |
| #72 | https://github.com/github/email_reply_parser/pull/72 |
| Please reload this page | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71 |
| lib/email_reply_parser.rb | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files/8c8c036085d73b34b4b3744bb781232d244c516a#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba |
| mattyoho | https://patch-diff.githubusercontent.com/mattyoho |
| Apr 10, 2019 | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71#discussion_r273757760 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71 |
| lib/email_reply_parser.rb | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files/8c8c036085d73b34b4b3744bb781232d244c516a#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba |
| mattyoho | https://patch-diff.githubusercontent.com/mattyoho |
| Apr 10, 2019 | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71#discussion_r273758115 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71 |
| lib/email_reply_parser.rb | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files/8c8c036085d73b34b4b3744bb781232d244c516a#diff-8e5f0fcbe5e81a6c3c86d435601eee300137cf5ef5f2f3aacdcc6a8de77840ba |
| mattyoho | https://patch-diff.githubusercontent.com/mattyoho |
| Apr 10, 2019 | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71#discussion_r273758543 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71 |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Femail_reply_parser%2Fpull%2F71 |
|
| https://patch-diff.githubusercontent.com/mattyoho |
|
mattyoho
| https://patch-diff.githubusercontent.com/mattyoho |
|
| https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71/files/8c8c036085d73b34b4b3744bb781232d244c516a |
|
Kind regards
| https://github.com/github/email_reply_parser/issues/70 |
| Please reload this page | https://patch-diff.githubusercontent.com/github/email_reply_parser/pull/71 |
|
| https://patch-diff.githubusercontent.com/askehansen |
|
| https://patch-diff.githubusercontent.com/mattyoho |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |