René's URL Explorer Experiment


Title: C++: Fix conflation in barrier guards by MathiasVP · Pull Request #21171 · github/codeql · GitHub

Open Graph Title: C++: Fix conflation in barrier guards by MathiasVP · Pull Request #21171 · github/codeql

X Title: C++: Fix conflation in barrier guards by MathiasVP · Pull Request #21171 · github/codeql

Description: While working on MaD support for barriers/barrier guards for C/C++ I discovered a bug related to indirect barrier guards. This PR fixes that bug at the cost of: Exposing a predicate that was priva...

Open Graph Description: While working on MaD support for barriers/barrier guards for C/C++ I discovered a bug related to indirect barrier guards. This PR fixes that bug at the cost of: Exposing a predicate that was priva...

X Description: While working on MaD support for barriers/barrier guards for C/C++ I discovered a bug related to indirect barrier guards. This PR fixes that bug at the cost of: Exposing a predicate that was priva...

Opengraph URL: https://github.com/github/codeql/pull/21171

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0fea8861-4afa-4716-2b13-7e9e9f7170ee
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id924E:2411E:7E39541:A5601BB:696DC9DE
html-safe-nonce7e4e559e2b8a4044569fffce87b41fe1702f21fa8d0a7148b2b8136b96e3ce7e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjRFOjI0MTFFOjdFMzk1NDE6QTU2MDFCQjo2OTZEQzlERSIsInZpc2l0b3JfaWQiOiIxMjY4OTA3NjQzNjY0OTc2MzUwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf3e9e2db27e2b0f1715ba030ec2eccbcda491549dce0326ff2d249ce2c2bcfd5
hovercard-subject-tagpull_request:3177026921
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/github/codeql/21171/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/18eabedb4db8a920b7cccfeff52b6a6249f4e85f10c4fb693fd9c4f6d54cda1f/github/codeql/pull/21171
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/18eabedb4db8a920b7cccfeff52b6a6249f4e85f10c4fb693fd9c4f6d54cda1f/github/codeql/pull/21171
og:image:altWhile working on MaD support for barriers/barrier guards for C/C++ I discovered a bug related to indirect barrier guards. This PR fixes that bug at the cost of: Exposing a predicate that was priva...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMathiasVP
hostnamegithub.com
expected-hostnamegithub.com
None4922b452d03cd8dbce479d866a11bc25b59ef6ee2da23aa9b0ddefa6bd4d0064
turbo-cache-controlno-preview
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7e5ae23c70136152637ceee8d6faceb35596ec46
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/github/codeql/pull/21171#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F21171
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F21171
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://patch-diff.githubusercontent.com/github/codeql/pull/21171
Reloadhttps://patch-diff.githubusercontent.com/github/codeql/pull/21171
Reloadhttps://patch-diff.githubusercontent.com/github/codeql/pull/21171
github https://patch-diff.githubusercontent.com/github
codeqlhttps://patch-diff.githubusercontent.com/github/codeql
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fgithub%2Fcodeql
Fork 1.9k https://patch-diff.githubusercontent.com/login?return_to=%2Fgithub%2Fcodeql
Star 9.1k https://patch-diff.githubusercontent.com/login?return_to=%2Fgithub%2Fcodeql
Code https://patch-diff.githubusercontent.com/github/codeql
Issues 918 https://patch-diff.githubusercontent.com/github/codeql/issues
Pull requests 368 https://patch-diff.githubusercontent.com/github/codeql/pulls
Discussions https://patch-diff.githubusercontent.com/github/codeql/discussions
Actions https://patch-diff.githubusercontent.com/github/codeql/actions
Projects 0 https://patch-diff.githubusercontent.com/github/codeql/projects
Models https://patch-diff.githubusercontent.com/github/codeql/models
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/github/codeql/security
Please reload this pagehttps://patch-diff.githubusercontent.com/github/codeql/pull/21171
Insights https://patch-diff.githubusercontent.com/github/codeql/pulse
Code https://patch-diff.githubusercontent.com/github/codeql
Issues https://patch-diff.githubusercontent.com/github/codeql/issues
Pull requests https://patch-diff.githubusercontent.com/github/codeql/pulls
Discussions https://patch-diff.githubusercontent.com/github/codeql/discussions
Actions https://patch-diff.githubusercontent.com/github/codeql/actions
Projects https://patch-diff.githubusercontent.com/github/codeql/projects
Models https://patch-diff.githubusercontent.com/github/codeql/models
Security https://patch-diff.githubusercontent.com/github/codeql/security
Insights https://patch-diff.githubusercontent.com/github/codeql/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/github/codeql/pull/21171#issue-comment-box
MathiasVPhttps://patch-diff.githubusercontent.com/MathiasVP
github:mainhttps://patch-diff.githubusercontent.com/github/codeql/tree/main
MathiasVP:fix-conflation-in-guardshttps://patch-diff.githubusercontent.com/MathiasVP/ql/tree/fix-conflation-in-guards
C++: Fix conflation in barrier guards https://patch-diff.githubusercontent.com/github/codeql/pull/21171#top
MathiasVPhttps://patch-diff.githubusercontent.com/MathiasVP
github:mainhttps://patch-diff.githubusercontent.com/github/codeql/tree/main
MathiasVP:fix-conflation-in-guardshttps://patch-diff.githubusercontent.com/MathiasVP/ql/tree/fix-conflation-in-guards
Conversation 4 https://patch-diff.githubusercontent.com/github/codeql/pull/21171
Commits 6 https://patch-diff.githubusercontent.com/github/codeql/pull/21171/commits
Checks 37 https://patch-diff.githubusercontent.com/github/codeql/pull/21171/checks
Files changed https://patch-diff.githubusercontent.com/github/codeql/pull/21171/files
Please reload this pagehttps://patch-diff.githubusercontent.com/github/codeql/pull/21171
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/github/codeql/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/MathiasVP
MathiasVPhttps://patch-diff.githubusercontent.com/MathiasVP
Jan 15, 2026https://patch-diff.githubusercontent.com/github/codeql/pull/21171#issue-3817202750
Please reload this pagehttps://patch-diff.githubusercontent.com/github/codeql/pull/21171
@aschackmullhttps://github.com/aschackmull
guardChecksInstrhttps://github.com/github/codeql/blob/d8061c17ccc7c887346add5c8d294243c2a1943f/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaImpl.qll#L1053-L1061
guardChecksDefhttps://github.com/github/codeql/blob/d8061c17ccc7c887346add5c8d294243c2a1943f/shared/controlflow/codeql/controlflow/Guards.qll#L1381-L1387
getAReadhttps://github.com/github/codeql/blob/d8061c17ccc7c887346add5c8d294243c2a1943f/shared/controlflow/codeql/controlflow/Guards.qll#L543
@aschackmullhttps://github.com/aschackmull
first commithttps://github.com/github/codeql/pull/21171/commits/27a437a5141953f21e39095aa5c9d5899a0cacf6
herehttps://github.com/github/codeql/blob/7c95fefd96ea6def505558b8a042210669f1137a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll#L1131-L1135
Please reload this pagehttps://patch-diff.githubusercontent.com/github/codeql/pull/21171
MathiasVPhttps://patch-diff.githubusercontent.com/MathiasVP
January 15, 2026 11:16https://patch-diff.githubusercontent.com/github/codeql/pull/21171#commits-pushed-27a437a
https://patch-diff.githubusercontent.com/MathiasVP
C++: Modify test to reveal a bug.https://patch-diff.githubusercontent.com/github/codeql/pull/21171/commits/27a437a5141953f21e39095aa5c9d5899a0cacf6
27a437ahttps://patch-diff.githubusercontent.com/github/codeql/pull/21171/commits/27a437a5141953f21e39095aa5c9d5899a0cacf6
https://patch-diff.githubusercontent.com/MathiasVP
C++: Fix bug and accept test changes.https://patch-diff.githubusercontent.com/github/codeql/pull/21171/commits/28681508f3ac1977309a3608268fd6b483757f15
2868150https://patch-diff.githubusercontent.com/github/codeql/pull/21171/commits/28681508f3ac1977309a3608268fd6b483757f15
https://patch-diff.githubusercontent.com/MathiasVP
MathiasVPhttps://patch-diff.githubusercontent.com/MathiasVP
Jan 15, 2026https://patch-diff.githubusercontent.com/github/codeql/pull/21171#event-22067703773
https://patch-diff.githubusercontent.com/apps/github-actions
github-actionshttps://patch-diff.githubusercontent.com/apps/github-actions
C++ https://patch-diff.githubusercontent.com/github/codeql/issues?q=state%3Aopen%20label%3AC%2B%2B
Jan 15, 2026https://patch-diff.githubusercontent.com/github/codeql/pull/21171#event-22067705302
https://patch-diff.githubusercontent.com/aschackmull
aschackmullhttps://patch-diff.githubusercontent.com/aschackmull
Jan 15, 2026https://patch-diff.githubusercontent.com/github/codeql/pull/21171#issuecomment-3754484364
Please reload this pagehttps://patch-diff.githubusercontent.com/github/codeql/pull/21171
https://patch-diff.githubusercontent.com/MathiasVP
C++: Add indirect barrier guard to 'cpp/unbounded-write' to prevent F…https://patch-diff.githubusercontent.com/github/codeql/pull/21171/commits/6da7890ff528b3e6b8221f2fa0e86475e763e57a
6da7890https://patch-diff.githubusercontent.com/github/codeql/pull/21171/commits/6da7890ff528b3e6b8221f2fa0e86475e763e57a
https://patch-diff.githubusercontent.com/MathiasVP
MathiasVPhttps://patch-diff.githubusercontent.com/MathiasVP
January 16, 2026 12:20https://patch-diff.githubusercontent.com/github/codeql/pull/21171#event-22094572673
https://patch-diff.githubusercontent.com/MathiasVP
MathiasVPhttps://patch-diff.githubusercontent.com/MathiasVP
code ownerhttps://patch-diff.githubusercontent.com/github/codeql/blob/7c95fefd96ea6def505558b8a042210669f1137a/CODEOWNERS#L26
January 16, 2026 12:20https://patch-diff.githubusercontent.com/github/codeql/pull/21171#event-22094572871
https://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
Copilothttps://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
January 16, 2026 12:20https://patch-diff.githubusercontent.com/github/codeql/pull/21171#event-22094572904
https://patch-diff.githubusercontent.com/MathiasVP
MathiasVPhttps://patch-diff.githubusercontent.com/MathiasVP
code ownerhttps://patch-diff.githubusercontent.com/github/codeql/blob/7c95fefd96ea6def505558b8a042210669f1137a/CODEOWNERS#L6
January 16, 2026 12:20https://patch-diff.githubusercontent.com/github/codeql/pull/21171#event-22094572906
started reviewinghttps://github.com/copilot/tasks/pull/PR_kwDOCIafrM69XZVp?session_id=7103dceb-47f1-4f27-bc0c-65599cdd8bb5
MathiasVPhttps://patch-diff.githubusercontent.com/MathiasVP
January 16, 2026 12:21https://patch-diff.githubusercontent.com/github/codeql/pull/21171#event-22094589967
View session https://github.com/copilot/tasks/pull/PR_kwDOCIafrM69XZVp?session_id=7103dceb-47f1-4f27-bc0c-65599cdd8bb5
https://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
Copilothttps://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
Jan 16, 2026 https://patch-diff.githubusercontent.com/github/codeql/pull/21171#pullrequestreview-3670643739
View reviewed changes https://patch-diff.githubusercontent.com/github/codeql/pull/21171/files/6da7890ff528b3e6b8221f2fa0e86475e763e57a
Copilothttps://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
https://patch-diff.githubusercontent.com/github/codeql/pull/21171#pullrequestreview-3670643739
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Add Copilot custom instructionshttps://patch-diff.githubusercontent.com/github/codeql/new/main/.github/instructions?filename=*.instructions.md
Learn how to get startedhttps://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot
Please reload this pagehttps://patch-diff.githubusercontent.com/github/codeql/pull/21171
cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qllhttps://patch-diff.githubusercontent.com/github/codeql/pull/21171/files/6da7890ff528b3e6b8221f2fa0e86475e763e57a#diff-e9e4c8dbaa54c9f16e1533c09bb66ff3ec456e747f98de139672cfa0412a463c
Please reload this pagehttps://patch-diff.githubusercontent.com/github/codeql/pull/21171
https://patch-diff.githubusercontent.com/MathiasVP
MathiasVPhttps://patch-diff.githubusercontent.com/MathiasVP
Jan 16, 2026https://patch-diff.githubusercontent.com/github/codeql/pull/21171#issuecomment-3759804912
6da7890https://github.com/github/codeql/commit/6da7890ff528b3e6b8221f2fa0e86475e763e57a
Please reload this pagehttps://patch-diff.githubusercontent.com/github/codeql/pull/21171
MathiasVPhttps://patch-diff.githubusercontent.com/MathiasVP
January 16, 2026 12:25https://patch-diff.githubusercontent.com/github/codeql/pull/21171#commits-pushed-5e9fd12
https://patch-diff.githubusercontent.com/MathiasVP
https://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
Update cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qllhttps://patch-diff.githubusercontent.com/github/codeql/pull/21171/commits/5e9fd12d8c71e428b361b56525c75663554e8ed1
5e9fd12https://patch-diff.githubusercontent.com/github/codeql/pull/21171/commits/5e9fd12d8c71e428b361b56525c75663554e8ed1
https://patch-diff.githubusercontent.com/MathiasVP
C++: Add change note.https://patch-diff.githubusercontent.com/github/codeql/pull/21171/commits/08a6b99cfd43a3dd6c35b23b4033ae9503291e38
08a6b99https://patch-diff.githubusercontent.com/github/codeql/pull/21171/commits/08a6b99cfd43a3dd6c35b23b4033ae9503291e38
https://patch-diff.githubusercontent.com/apps/github-actions
github-actionshttps://patch-diff.githubusercontent.com/apps/github-actions
documentation https://patch-diff.githubusercontent.com/github/codeql/issues?q=state%3Aopen%20label%3Adocumentation
Jan 16, 2026https://patch-diff.githubusercontent.com/github/codeql/pull/21171#event-22094959254
https://patch-diff.githubusercontent.com/MathiasVP
C++: Switch another 'DataFlowType' to 'Type'.https://patch-diff.githubusercontent.com/github/codeql/pull/21171/commits/f05bff01e464c22fe7ef2aa24c88a1950e567400
f05bff0https://patch-diff.githubusercontent.com/github/codeql/pull/21171/commits/f05bff01e464c22fe7ef2aa24c88a1950e567400
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F21171
Copilot code review https://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
Copilot https://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
https://patch-diff.githubusercontent.com/github/codeql/pull/21171/files/6da7890ff528b3e6b8221f2fa0e86475e763e57a
C++ https://patch-diff.githubusercontent.com/github/codeql/issues?q=state%3Aopen%20label%3AC%2B%2B
documentation https://patch-diff.githubusercontent.com/github/codeql/issues?q=state%3Aopen%20label%3Adocumentation
Please reload this pagehttps://patch-diff.githubusercontent.com/github/codeql/pull/21171
https://patch-diff.githubusercontent.com/MathiasVP
https://patch-diff.githubusercontent.com/aschackmull
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.