René's URL Explorer Experiment


Title: Rust: Remove restriction that blanket(-like) impls must have a constraint by hvitved · Pull Request #21168 · github/codeql · GitHub

Open Graph Title: Rust: Remove restriction that blanket(-like) impls must have a constraint by hvitved · Pull Request #21168 · github/codeql

X Title: Rust: Remove restriction that blanket(-like) impls must have a constraint by hvitved · Pull Request #21168 · github/codeql

Description: Before this PR, blanket implementations without constraints, such as impl From for T, were ignored, because they would give rise to too many calls with multiple call targets. This PR changes that, and avoids multiple targets by only allowing blanket targets when no compatible non-blanket targets exist (we already had this check in place for method calls). DCA looks good: Percentage of calls with call target increases by 1.5 % point and performance is more or less unchanged.

Open Graph Description: Before this PR, blanket implementations without constraints, such as impl<T> From<T> for T, were ignored, because they would give rise to too many calls with multiple call targets. This...

X Description: Before this PR, blanket implementations without constraints, such as impl&lt;T&gt; From&lt;T&gt; for T, were ignored, because they would give rise to too many calls with multiple ca...

Opengraph URL: https://github.com/github/codeql/pull/21168

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/:user_id/:repository/pull/:id/checks(.:format)
route-controllerpull_requests
route-actionchecks
fetch-noncev2:aaeb02ff-29be-e351-b5b8-5d5d0a8a91a3
current-catalog-service-hash87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a
request-idDD5A:E5B7D:254618:345EA0:696E2B07
html-safe-nonceef480aabd944b4ebc787d3455bf938e6a70489ac8bfa35ca40360b9b9922a18d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDVBOkU1QjdEOjI1NDYxODozNDVFQTA6Njk2RTJCMDciLCJ2aXNpdG9yX2lkIjoiNzk2MTExMTg2NzkzNTMwNDQ1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac39b3aba3f5725251ab58debadcd174331279669fb3f82cedad834de5ad12a5e9
hovercard-subject-tagpull_request:3176538036
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/checks
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github/codeql/pull/21168/checks
twitter:imagehttps://avatars.githubusercontent.com/u/3667920?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3667920?s=400&v=4
og:image:altBefore this PR, blanket implementations without constraints, such as impl<T> From<T> for T, were ignored, because they would give rise to too many calls with multiple call targets. This...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None878b142339d396b81902fd0c6d3f2f41511e1864f596c5a601660d91d0d60e59
turbo-cache-controlno-cache
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive full-width full-width-p-0
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release20fb42f07915f87665e5bccffc415f231d50cfac
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/github/codeql/pull/21168/checks#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F21168%2Fchecks
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F21168%2Fchecks
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fchecks&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://patch-diff.githubusercontent.com/github/codeql/pull/21168/checks
Reloadhttps://patch-diff.githubusercontent.com/github/codeql/pull/21168/checks
Reloadhttps://patch-diff.githubusercontent.com/github/codeql/pull/21168/checks
github https://patch-diff.githubusercontent.com/github
codeqlhttps://patch-diff.githubusercontent.com/github/codeql
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fgithub%2Fcodeql
Fork 1.9k https://patch-diff.githubusercontent.com/login?return_to=%2Fgithub%2Fcodeql
Star 9.1k https://patch-diff.githubusercontent.com/login?return_to=%2Fgithub%2Fcodeql
Code https://patch-diff.githubusercontent.com/github/codeql
Issues 918 https://patch-diff.githubusercontent.com/github/codeql/issues
Pull requests 368 https://patch-diff.githubusercontent.com/github/codeql/pulls
Discussions https://patch-diff.githubusercontent.com/github/codeql/discussions
Actions https://patch-diff.githubusercontent.com/github/codeql/actions
Projects 0 https://patch-diff.githubusercontent.com/github/codeql/projects
Models https://patch-diff.githubusercontent.com/github/codeql/models
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/github/codeql/security
Please reload this pagehttps://patch-diff.githubusercontent.com/github/codeql/pull/21168/checks
Insights https://patch-diff.githubusercontent.com/github/codeql/pulse
Code https://patch-diff.githubusercontent.com/github/codeql
Issues https://patch-diff.githubusercontent.com/github/codeql/issues
Pull requests https://patch-diff.githubusercontent.com/github/codeql/pulls
Discussions https://patch-diff.githubusercontent.com/github/codeql/discussions
Actions https://patch-diff.githubusercontent.com/github/codeql/actions
Projects https://patch-diff.githubusercontent.com/github/codeql/projects
Models https://patch-diff.githubusercontent.com/github/codeql/models
Security https://patch-diff.githubusercontent.com/github/codeql/security
Insights https://patch-diff.githubusercontent.com/github/codeql/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
hvitvedhttps://patch-diff.githubusercontent.com/hvitved
github:mainhttps://patch-diff.githubusercontent.com/github/codeql/tree/main
hvitved:rust/type-inference-remove-blanket-constraint-restrictionhttps://patch-diff.githubusercontent.com/hvitved/codeql/tree/rust/type-inference-remove-blanket-constraint-restriction
Conversation 5 https://patch-diff.githubusercontent.com/github/codeql/pull/21168
Commits 1 https://patch-diff.githubusercontent.com/github/codeql/pull/21168/commits
Checks 15 https://patch-diff.githubusercontent.com/github/codeql/pull/21168/checks
Files changed https://patch-diff.githubusercontent.com/github/codeql/pull/21168/files
Please reload this pagehttps://patch-diff.githubusercontent.com/github/codeql/pull/21168/checks
Please reload this pagehttps://patch-diff.githubusercontent.com/github/codeql/pull/21168/checks
Sign in for the full log viewhttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F21168%2Fchecks
Rust: Remove restriction that blanket(-like) impls must have a constraint https://patch-diff.githubusercontent.com/github/codeql/pull/21168/checks#top
Please reload this pagehttps://patch-diff.githubusercontent.com/github/codeql/pull/21168/checks
Check change note on: pull_request_target https://patch-diff.githubusercontent.com/github/codeql/actions/runs/21133811880
check-change-note https://patch-diff.githubusercontent.com/github/codeql/actions/runs/21133811880/job/60770991616?pr=21168
Pull Request Labeler on: pull_request_target https://patch-diff.githubusercontent.com/github/codeql/actions/runs/21133811886
triage https://patch-diff.githubusercontent.com/github/codeql/actions/runs/21133811886/job/60770991671?pr=21168
Check framework coverage changes on: pull_request https://patch-diff.githubusercontent.com/github/codeql/actions/runs/21133812308
Generate framework coverage artifacts https://patch-diff.githubusercontent.com/github/codeql/actions/runs/21133812308/job/60770992697?pr=21168
Check QLdoc coverage on: pull_request https://patch-diff.githubusercontent.com/github/codeql/actions/runs/21133812318
qldoc https://patch-diff.githubusercontent.com/github/codeql/actions/runs/21133812318/job/60770992748?pr=21168
Code scanning - Rust on: pull_request https://patch-diff.githubusercontent.com/github/codeql/actions/runs/21133812322
analyze (rust) https://patch-diff.githubusercontent.com/github/codeql/actions/runs/21133812322/job/60770992928?pr=21168
Run QL for QL on: pull_request https://patch-diff.githubusercontent.com/github/codeql/actions/runs/21133812333
analyze https://patch-diff.githubusercontent.com/github/codeql/actions/runs/21133812333/job/60770992827?pr=21168
Check synchronized files on: pull_request https://patch-diff.githubusercontent.com/github/codeql/actions/runs/21133812347
sync https://patch-diff.githubusercontent.com/github/codeql/actions/runs/21133812347/job/60770992908?pr=21168
Ruby: Run RTJO Language Tests on: pull_request https://patch-diff.githubusercontent.com/github/codeql/actions/runs/21133812350
qltest-rtjo https://patch-diff.githubusercontent.com/github/codeql/actions/runs/21133812350/job/60770993150?pr=21168
Compile all queries using the latest stable CodeQL CLI on: pull_request https://patch-diff.githubusercontent.com/github/codeql/actions/runs/21133812351
detect-changes https://patch-diff.githubusercontent.com/github/codeql/actions/runs/21133812351/job/60770992910?pr=21168
compile-queries (rust) https://patch-diff.githubusercontent.com/github/codeql/actions/runs/21133812351/job/60771024809?pr=21168
Rust on: pull_request https://patch-diff.githubusercontent.com/github/codeql/actions/runs/21133812372
rust-ast-generator https://patch-diff.githubusercontent.com/github/codeql/actions/runs/21133812372/job/60770993191?pr=21168
rust-code https://patch-diff.githubusercontent.com/github/codeql/actions/runs/21133812372/job/60770993187?pr=21168
rust-codegen https://patch-diff.githubusercontent.com/github/codeql/actions/runs/21133812372/job/60770993177?pr=21168
Check overlay annotations on: pull_request https://patch-diff.githubusercontent.com/github/codeql/actions/runs/21133812384
sync https://patch-diff.githubusercontent.com/github/codeql/actions/runs/21133812384/job/60770993018?pr=21168
CodeQL https://patch-diff.githubusercontent.com/github/codeql/pull/21168/checks?check_run_id=60771286064
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.