René's URL Explorer Experiment

Title: Scripts: be more robust when parsing test logs by owen-mc · Pull Request #21160 · github/codeql · GitHub

Open Graph Title: Scripts: be more robust when parsing test logs by owen-mc · Pull Request #21160 · github/codeql

X Title: Scripts: be more robust when parsing test logs by owen-mc · Pull Request #21160 · github/codeql

Description: The script was falling over on this log, I believe because of the unexpected getSignatureParameterName line in this section: --- expected +++ actual @@ -135,6 +135,7 @@ | stl.h:678:33:678:38 | format | std | (format_string,Args &&) | | format | 0 | | stl.h:678:33:678:38 | format | std | (format_string,Args &&) | | format | 1 | | stl.h:678:33:678:38 | format | std | (format_string,Args &&) | | format | 1 | +| taint.cpp:735:7:735:12 | malloc | | (size_t) | | malloc | 0 | | taint.cpp:847:5:847:11 | toupper | | (int) | | toupper | 0 | | taint.cpp:848:5:848:11 | tolower | | (int) | | tolower | 0 | getSignatureParameterName Error: [3/3] [1477/2812 comp 17.7s eval 3.9s] FAILED(RESULT) /home/runner/work/semmle-code/semmle-code/ql/cpp/ql/test/library-tests/dataflow/taint-tests/test_mad-signatures.ql The terminal output was as follow: INFO: 'Java Language Tests Linux': Making patches INFO: 'CPP Language Tests Linux': Making patches Traceback (most recent call last): File "/Users/owen-mc/workspace/code/ql/misc/scripts/accept-expected-changes-from-ci.py", line 504, in main(pr_number, override_sha, force=args.force, wait_for_ci=args.wait_for_ci) ~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/owen-mc/workspace/code/ql/misc/scripts/accept-expected-changes-from-ci.py", line 392, in main patches = make_patches_from_log_file(log_content.splitlines()) File "/Users/owen-mc/workspace/code/ql/misc/scripts/accept-expected-changes-from-ci.py", line 132, in make_patches_from_log_file error_line = parse_log_line(next(lines)) ~~~~^^^^^^^ StopIteration I asked copilot to fix it and it added this try-except block so that at least other patches could be produced. Now when I run the script I get this output: INFO: 'Java Language Tests Linux': Making patches INFO: 'CPP Language Tests Linux': Making patches WARNING: Encountered unexpected end of logs while parsing failure block. INFO: 'C# Language Tests Linux': Making patches INFO: 'Go Language Tests Linux': Making patches (And then a C# patch failed to apply, but I assume that's unrelated.)

Open Graph Description: The script was falling over on this log, I believe because of the unexpected getSignatureParameterName line in this section: --- expected +++ actual @@ -135,6 +135,7 @@ | stl.h:678:33:678:38 | for...

X Description: The script was falling over on this log, I believe because of the unexpected getSignatureParameterName line in this section: --- expected +++ actual @@ -135,6 +135,7 @@ | stl.h:678:33:678:38 | for...

Opengraph URL: https://github.com/github/codeql/pull/21160

X: @github

direct link

Domain: patch-diff.githubusercontent.com

Links:

Viewport: width=device-width