René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Code Refactoring based on SOLID Principles","articleBody":"Hi developers\r\nI was looking through your code and found some SOLID principles that were being violated, here are my suggestions on how to fix it: \r\n\r\nIn Cloud.java, the interface had too many responsibilities, so it's better if you separate each responsibility in one interface on its own: \r\n`public interface Loggin {\r\n    public boolean login(String userName, String password);\r\n}`\r\n\r\n`public interface Upload {\r\n    public void upload(String file); \r\n}`\r\n\r\n`public interface Download {\r\n    public String download(String file);\r\n}`\r\n\r\nLeaving Cloud just handeling the files, like this: \r\n`public interface Cloud {\r\n    public void listFiles();\r\n}`\r\n\r\nNow in Fly.java, interface that implements Bird, the main issue is Penguin causing the method fly() throw an error, since penguins cannot fly, instead I suggest the next model: \r\n\r\nUML Diagram\r\n![image](https://github.com/user-attachments/assets/d042df40-ae3b-48d8-b983-525c92486ab2)\r\n\r\nAnd finally in CaoCloaud.java you're using a direct object of CloudImp, taking advantage of the interfaces i suggested to creat in the problem with Cloud, we can fix it using your own class AbstractClouad.java and the interfaces, adding a new interface for FastDownload, something like this: \r\n\r\nUML Diagram \r\n![image](https://github.com/user-attachments/assets/eb644bf0-1ecc-4c03-b326-90e8131c028f)\r\n\r\nThat would be all, thanks for reading and I hope this helps a little :)\r\n\r\n\r\n","author":{"url":"https://github.com/eimmy-o","@type":"Person","name":"eimmy-o"},"datePublished":"2024-11-12T22:59:41.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/6/java-workshop/issues/6"}