Title: fix: enhance missing methods to handle missing keys more explicitly i… by t4m4k0ty4 · Pull Request #59 · fluentpython/example-code-2e · GitHub
Open Graph Title: fix: enhance missing methods to handle missing keys more explicitly i… by t4m4k0ty4 · Pull Request #59 · fluentpython/example-code-2e
X Title: fix: enhance missing methods to handle missing keys more explicitly i… by t4m4k0ty4 · Pull Request #59 · fluentpython/example-code-2e
Description: Description This PR improves the implementation of missing methods across several mapping subclasses to ensure safer and more predictable behavior when attempting to access keys in a case-insensitive manner. Problem In the original version, calls to self[_upper(key)] were made without checking if the transformed key actually exists. This could result in unhandled KeyErrors or unintended recursion, especially in dictionary-like structures where missing is automatically called upon a missing key. Impact of my solution This change enhances code clarity and error safety, making the behavior of custom mappings more robust and closer to Python’s expectations for missing.
Open Graph Description: Description This PR improves the implementation of missing methods across several mapping subclasses to ensure safer and more predictable behavior when attempting to access keys in a case-insensiti...
X Description: Description This PR improves the implementation of missing methods across several mapping subclasses to ensure safer and more predictable behavior when attempting to access keys in a case-insensiti...
Opengraph URL: https://github.com/fluentpython/example-code-2e/pull/59
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:928c07c1-a72a-713d-05df-d4274667668b |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | A85C:BB87C:44F520C:5DA39E6:6972FA1B |
| html-safe-nonce | 56f6ff9216152e1305f0568214d40f95036391a6cd2496771910151b4e378f3c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODVDOkJCODdDOjQ0RjUyMEM6NURBMzlFNjo2OTcyRkExQiIsInZpc2l0b3JfaWQiOiI0MzgzNjgxMTQ4NjQzMTEzNDk5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 1779fded0ec92d1029998232f8484e372bceb5fbd3f13e58e56d552cdf21511e |
| hovercard-subject-tag | pull_request:2661024864 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/fluentpython/example-code-2e/pull/59/checks |
| twitter:image | https://avatars.githubusercontent.com/u/194794071?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/194794071?s=400&v=4 |
| og:image:alt | Description This PR improves the implementation of missing methods across several mapping subclasses to ensure safer and more predictable behavior when attempting to access keys in a case-insensiti... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9946c12a4847916f32068429cb2ad536f7d8450fc8b70730d0e9aa7861057db8 |
| turbo-cache-control | no-preview |
| go-import | github.com/fluentpython/example-code-2e git https://github.com/fluentpython/example-code-2e.git |
| octolytics-dimension-user_id | 9216311 |
| octolytics-dimension-user_login | fluentpython |
| octolytics-dimension-repository_id | 176997413 |
| octolytics-dimension-repository_nwo | fluentpython/example-code-2e |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 176997413 |
| octolytics-dimension-repository_network_root_nwo | fluentpython/example-code-2e |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f92f1208f12997e73ccb28d2f389b2adab0c98a3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width