René's URL Explorer Experiment


Title: Why using synchronous get in flags_asyncio.py · Issue #40 · fluentpython/example-code-2e · GitHub

Open Graph Title: Why using synchronous get in flags_asyncio.py · Issue #40 · fluentpython/example-code-2e

X Title: Why using synchronous get in flags_asyncio.py · Issue #40 · fluentpython/example-code-2e

Description: When downloading the flags in async def get_flag(client: AsyncClient, cc: str) -> bytes: 4 url = f'{BASE_URL}/{cc}/{cc}.gif'.lower() resp = await client.get(url, timeout=6.1, follow_redirects=True) 5 return resp.read() 6 it seems that we...

Open Graph Description: When downloading the flags in async def get_flag(client: AsyncClient, cc: str) -> bytes: 4 url = f'{BASE_URL}/{cc}/{cc}.gif'.lower() resp = await client.get(url, timeout=6.1, follow_redirects=True)...

X Description: When downloading the flags in async def get_flag(client: AsyncClient, cc: str) -> bytes: 4 url = f'{BASE_URL}/{cc}/{cc}.gif'.lower() resp = await client.get(url, timeout=6.1, follow_redi...

Opengraph URL: https://github.com/fluentpython/example-code-2e/issues/40

X: @github

direct link

Domain: patch-diff.githubusercontent.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Why using synchronous get in flags_asyncio.py","articleBody":"When downloading the flags in \r\n```\r\nasync def get_flag(client: AsyncClient, cc: str) -\u003e bytes:  4\r\n    url = f'{BASE_URL}/{cc}/{cc}.gif'.lower()\r\n    resp = await client.get(url, timeout=6.1,\r\n                                  follow_redirects=True)  5\r\n    return resp.read()  6\r\n```\r\nit seems that we read the response using .read() which is synchronous, why don't we \r\n```\r\nreturn await resp.aread()\r\n```\r\ninstead? \r\n\r\nThe explanation seems to be for client.get() where it is doing network IO asynchrnously provided by httpx. But not for read()\r\n```\r\n6\r\n\r\n    Network I/O operations are implemented as coroutine methods, so they are driven asynchronously by the asyncio event loop.\r\n```","author":{"url":"https://github.com/ngokchaoho","@type":"Person","name":"ngokchaoho"},"datePublished":"2023-12-13T06:54:05.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/40/example-code-2e/issues/40"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:9882f10f-12dd-c6ce-58ce-9912c564a6aa
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idAEB8:23F8A8:2EF64E7:3EBFDF3:69705B64
html-safe-noncef6c9e9de14fb9d8ef1a2099bccce6d2adbe4dc27b3aa40ddee81982f476ba6ae
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUI4OjIzRjhBODoyRUY2NEU3OjNFQkZERjM6Njk3MDVCNjQiLCJ2aXNpdG9yX2lkIjoiOTA0MjYzODI5MzEzMDUxNDkyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd4978f0eb2b0e42f370c152a1cc7577b802fe7810c30c71c1894f0f35781f274
hovercard-subject-tagissue:2039071838
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/fluentpython/example-code-2e/40/issue_layout
twitter:imagehttps://opengraph.githubassets.com/b66b9349445db1fa100e1f5d44790cbb56c44540383b7fcf1f62e627748d8e91/fluentpython/example-code-2e/issues/40
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b66b9349445db1fa100e1f5d44790cbb56c44540383b7fcf1f62e627748d8e91/fluentpython/example-code-2e/issues/40
og:image:altWhen downloading the flags in async def get_flag(client: AsyncClient, cc: str) -> bytes: 4 url = f'{BASE_URL}/{cc}/{cc}.gif'.lower() resp = await client.get(url, timeout=6.1, follow_redirects=True)...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamengokchaoho
hostnamegithub.com
expected-hostnamegithub.com
None9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2
turbo-cache-controlno-preview
go-importgithub.com/fluentpython/example-code-2e git https://github.com/fluentpython/example-code-2e.git
octolytics-dimension-user_id9216311
octolytics-dimension-user_loginfluentpython
octolytics-dimension-repository_id176997413
octolytics-dimension-repository_nwofluentpython/example-code-2e
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id176997413
octolytics-dimension-repository_network_root_nwofluentpython/example-code-2e
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7d6181066430cc06553c8396ca201e194ae33cb9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/fluentpython/example-code-2e/issues/40#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffluentpython%2Fexample-code-2e%2Fissues%2F40
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffluentpython%2Fexample-code-2e%2Fissues%2F40
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=fluentpython%2Fexample-code-2e
Reloadhttps://patch-diff.githubusercontent.com/fluentpython/example-code-2e/issues/40
Reloadhttps://patch-diff.githubusercontent.com/fluentpython/example-code-2e/issues/40
Reloadhttps://patch-diff.githubusercontent.com/fluentpython/example-code-2e/issues/40
fluentpython https://patch-diff.githubusercontent.com/fluentpython
example-code-2ehttps://patch-diff.githubusercontent.com/fluentpython/example-code-2e
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Ffluentpython%2Fexample-code-2e
Fork 1.1k https://patch-diff.githubusercontent.com/login?return_to=%2Ffluentpython%2Fexample-code-2e
Star 3.9k https://patch-diff.githubusercontent.com/login?return_to=%2Ffluentpython%2Fexample-code-2e
Code https://patch-diff.githubusercontent.com/fluentpython/example-code-2e
Issues 13 https://patch-diff.githubusercontent.com/fluentpython/example-code-2e/issues
Pull requests 9 https://patch-diff.githubusercontent.com/fluentpython/example-code-2e/pulls
Actions https://patch-diff.githubusercontent.com/fluentpython/example-code-2e/actions
Projects 0 https://patch-diff.githubusercontent.com/fluentpython/example-code-2e/projects
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/fluentpython/example-code-2e/security
Please reload this pagehttps://patch-diff.githubusercontent.com/fluentpython/example-code-2e/issues/40
Insights https://patch-diff.githubusercontent.com/fluentpython/example-code-2e/pulse
Code https://patch-diff.githubusercontent.com/fluentpython/example-code-2e
Issues https://patch-diff.githubusercontent.com/fluentpython/example-code-2e/issues
Pull requests https://patch-diff.githubusercontent.com/fluentpython/example-code-2e/pulls
Actions https://patch-diff.githubusercontent.com/fluentpython/example-code-2e/actions
Projects https://patch-diff.githubusercontent.com/fluentpython/example-code-2e/projects
Security https://patch-diff.githubusercontent.com/fluentpython/example-code-2e/security
Insights https://patch-diff.githubusercontent.com/fluentpython/example-code-2e/pulse
New issuehttps://patch-diff.githubusercontent.com/login?return_to=https://github.com/fluentpython/example-code-2e/issues/40
New issuehttps://patch-diff.githubusercontent.com/login?return_to=https://github.com/fluentpython/example-code-2e/issues/40
Why using synchronous get in flags_asyncio.pyhttps://patch-diff.githubusercontent.com/fluentpython/example-code-2e/issues/40#top
https://github.com/ngokchaoho
https://github.com/ngokchaoho
ngokchaohohttps://github.com/ngokchaoho
on Dec 13, 2023https://github.com/fluentpython/example-code-2e/issues/40#issue-2039071838
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.