Title: Firebase Admin not retried on auth request connection error · Issue #852 · firebase/firebase-admin-python · GitHub
Open Graph Title: Firebase Admin not retried on auth request connection error · Issue #852 · firebase/firebase-admin-python
X Title: Firebase Admin not retried on auth request connection error · Issue #852 · firebase/firebase-admin-python
Description: Even though DEFAULT_RETRY_CONFIG is good enough DEFAULT_RETRY_CONFIG = retry.Retry( connect=1, read=1, status=4, status_forcelist=[500, 503], raise_on_status=False, backoff_factor=0.5, **_ANY_METHOD) I'm still periodically getting ('Conn...
Open Graph Description: Even though DEFAULT_RETRY_CONFIG is good enough DEFAULT_RETRY_CONFIG = retry.Retry( connect=1, read=1, status=4, status_forcelist=[500, 503], raise_on_status=False, backoff_factor=0.5, **_ANY_METHO...
X Description: Even though DEFAULT_RETRY_CONFIG is good enough DEFAULT_RETRY_CONFIG = retry.Retry( connect=1, read=1, status=4, status_forcelist=[500, 503], raise_on_status=False, backoff_factor=0.5, **_ANY_METHO...
Opengraph URL: https://github.com/firebase/firebase-admin-python/issues/852
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Firebase Admin not retried on auth request connection error","articleBody":"Even though `DEFAULT_RETRY_CONFIG` is good enough\n```py\nDEFAULT_RETRY_CONFIG = retry.Retry(\n connect=1, read=1, status=4, status_forcelist=[500, 503],\n raise_on_status=False, backoff_factor=0.5, **_ANY_METHOD)\n```\nI'm still periodically getting `('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))`. I started thinking it is very weird, because it seems that this connection error should be retried, no? It turned out, that this connection error occurs not in the request itself, which properly retries connection errors. It happens inside `AuthorizedSession.credentials.before_request`, which for auth requests instead of `DEFAULT_RETRY_CONFIG` uses\n```py\nretry_adapter = requests.adapters.HTTPAdapter(max_retries=3)\n```\n\nI think the right approach would be to form `auth_request` manually with the correct retry config in `HttpClient.__init__` and pass it to `AuthorizedSession` on creation.\n\nWhat are your thoughts?","author":{"url":"https://github.com/al-muammar","@type":"Person","name":"al-muammar"},"datePublished":"2025-01-16T18:47:55.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/852/firebase-admin-python/issues/852"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:68532e1d-bc3a-2064-2350-7c7d8d2c2b1f |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A56E:53D23:18F49C:20CA82:698E622D |
| html-safe-nonce | 51fc48c981cca450d27361c6d0059ce112bcce818492440b3067ca8a20b2a8fa |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTZFOjUzRDIzOjE4RjQ5QzoyMENBODI6Njk4RTYyMkQiLCJ2aXNpdG9yX2lkIjoiNTYxOTExMzcyMDk0Njc3ODY3MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a349263244b839dca0fc8a4bc1a330be11c0936c8f6b87a58ee23ba834a2110b |
| hovercard-subject-tag | issue:2793504871 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/firebase/firebase-admin-python/852/issue_layout |
| twitter:image | https://opengraph.githubassets.com/83c9c52dbf1b39610d59d6adb73905b75a8a9e7ecf1c371c7b383cd90b72e723/firebase/firebase-admin-python/issues/852 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/83c9c52dbf1b39610d59d6adb73905b75a8a9e7ecf1c371c7b383cd90b72e723/firebase/firebase-admin-python/issues/852 |
| og:image:alt | Even though DEFAULT_RETRY_CONFIG is good enough DEFAULT_RETRY_CONFIG = retry.Retry( connect=1, read=1, status=4, status_forcelist=[500, 503], raise_on_status=False, backoff_factor=0.5, **_ANY_METHO... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | al-muammar |
| hostname | github.com |
| expected-hostname | github.com |
| None | 666e30cc1de8ebdf458084bf731e95deba4f074a5008f91b50803aa9a71e3725 |
| turbo-cache-control | no-preview |
| go-import | github.com/firebase/firebase-admin-python git https://github.com/firebase/firebase-admin-python.git |
| octolytics-dimension-user_id | 1335026 |
| octolytics-dimension-user_login | firebase |
| octolytics-dimension-repository_id | 84979152 |
| octolytics-dimension-repository_nwo | firebase/firebase-admin-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 84979152 |
| octolytics-dimension-repository_network_root_nwo | firebase/firebase-admin-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f2d67bd549813f8aceb31f205ebdb434e9d46d38 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width