Title: [Python] Parameter getter of `EquationOfState` crashes kernel for parameters that cannot be parsed to `f64` · Issue #318 · feos-org/feos · GitHub
Open Graph Title: [Python] Parameter getter of `EquationOfState` crashes kernel for parameters that cannot be parsed to `f64` · Issue #318 · feos-org/feos
X Title: [Python] Parameter getter of `EquationOfState` crashes kernel for parameters that cannot be parsed to `f64` · Issue #318 · feos-org/feos
Description: The parameter getter can cause kernel crashes when a model's parameters cannot be parsed into arrays/matrices of f64 since the mappings use unwraps. This is annoying because it can happen e.g. by tapping TAB in a notebook on a model for ...
Open Graph Description: The parameter getter can cause kernel crashes when a model's parameters cannot be parsed into arrays/matrices of f64 since the mappings use unwraps. This is annoying because it can happen e.g. by t...
X Description: The parameter getter can cause kernel crashes when a model's parameters cannot be parsed into arrays/matrices of f64 since the mappings use unwraps. This is annoying because it can happen e.g. ...
Opengraph URL: https://github.com/feos-org/feos/issues/318
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[Python] Parameter getter of `EquationOfState` crashes kernel for parameters that cannot be parsed to `f64`","articleBody":"The [parameter getter](https://github.com/feos-org/feos/blob/main/py-feos/src/eos/mod.rs#L37) can cause kernel crashes when a model's parameters cannot be parsed into arrays/matrices of `f64` since the mappings use `unwrap`s. This is annoying because it can happen e.g. by tapping TAB in a notebook on a model for auto-completion.\n\nQuick fix: remove `getter`. If the method is called (and not used as getter), PyO3 will wrap the panic in an error which keeps the kernel alive.\n\nLonger term: create a better way to retrieve parameters from a model.","author":{"url":"https://github.com/g-bauer","@type":"Person","name":"g-bauer"},"datePublished":"2025-11-12T14:05:02.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/318/feos/issues/318"}| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:8e3ca61b-3aef-e8c3-13da-b2068f536272 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BB34:41DF6:15392F:1C82EE:698EC9B8 |
| html-safe-nonce | eb7c3005094b03c01ef93a1498cb50aa0702871dcde05ebdc6a2ad17125c0c27 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjM0OjQxREY2OjE1MzkyRjoxQzgyRUU6Njk4RUM5QjgiLCJ2aXNpdG9yX2lkIjoiNDU4NDM4MDcxNDA3NDQyNTc4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 40ec7c484ce63fc151b698bb26e7db2627d2acce18f06bff62e4e980442ef8cf |
| hovercard-subject-tag | issue:3616713140 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feos-org/feos/318/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c227c4ed104335646787debadaf1a7c178c230d7358bd79687fce98e2b81d191/feos-org/feos/issues/318 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c227c4ed104335646787debadaf1a7c178c230d7358bd79687fce98e2b81d191/feos-org/feos/issues/318 |
| og:image:alt | The parameter getter can cause kernel crashes when a model's parameters cannot be parsed into arrays/matrices of f64 since the mappings use unwraps. This is annoying because it can happen e.g. by t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | g-bauer |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb2828a801ee6b7be618f3ac76fbf55def35bbc30f053a9c41bf90210b8b72ba |
| turbo-cache-control | no-preview |
| go-import | github.com/feos-org/feos git https://github.com/feos-org/feos.git |
| octolytics-dimension-user_id | 87855701 |
| octolytics-dimension-user_login | feos-org |
| octolytics-dimension-repository_id | 424905104 |
| octolytics-dimension-repository_nwo | feos-org/feos |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 424905104 |
| octolytics-dimension-repository_network_root_nwo | feos-org/feos |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6b91a7e6e46287d26887e3fb7a4161657bab8f7 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width