René's URL Explorer Experiment


Title: Extending EoS capabilities · Issue #280 · feos-org/feos · GitHub

Open Graph Title: Extending EoS capabilities · Issue #280 · feos-org/feos

X Title: Extending EoS capabilities · Issue #280 · feos-org/feos

Description: Dear all, I am a PhD in the Engineering Thermodynamics group at the TU Delft. We mostly work on molecular simulations with Monte Carlo and molecular dynamics simulations in Fortran and C++. In my free time, I am learning Rust (I just fin...

Open Graph Description: Dear all, I am a PhD in the Engineering Thermodynamics group at the TU Delft. We mostly work on molecular simulations with Monte Carlo and molecular dynamics simulations in Fortran and C++. In my f...

X Description: Dear all, I am a PhD in the Engineering Thermodynamics group at the TU Delft. We mostly work on molecular simulations with Monte Carlo and molecular dynamics simulations in Fortran and C++. In my f...

Opengraph URL: https://github.com/feos-org/feos/issues/280

X: @github

direct link

Domain: patch-diff.githubusercontent.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Extending EoS capabilities","articleBody":"Dear all,\nI am a PhD in the Engineering Thermodynamics group at the TU Delft. We mostly work on molecular simulations with Monte Carlo and molecular dynamics simulations in Fortran and C++. In my free time, I am learning Rust (I just finished coding my own LJ Monte Carlo program for fun) and came across this package because an office mate was using FeOs. He is using FeOs (from the python side) for phase equilibrium predictions of multi-component mixtures, where he computes among others spinodal lines.\n\nBesides FeOs he is using Refprop and the GERG-2008 EoS (doi: 10.1021/je300655b) and asked me if it would be possible to implement this EoS as well into FeOs. I looked into the Peng-Robinson implementation (python example in the tutorial and the Rust code in the feos-core crate) and in the half hour I spend on it, it seems that FeOs requires Helmholtz free energy functions for correct predictions of its state. This is similar to GERG-2008, although that is a multivariable empirical relation instead of something as elegant and simple as the already implemented PR EoS. I propose the following process, as I have mediocre experience in Rust:\n\n- I implement and test the cubic equations of states first in python to check if I have proper understanding of what I am doing.\n- I implement additional cubic equation of states first to get some Rust practice. I went through the code and expect that I would not have too many problems in implementing the VdW and SRK EoSs for single and multi-component fluids.\n- When that is implemented and merged successfully in the main FeOs branch, I will start on implementing empirical Helmholtz free energy models such as GERG-2008 and maybe IAPWS95.\n\nFor this, I would need the following from the FeOs maintainers:\n- Some instructions on structure, styling, and testing guidelines in FeOs (as to integrate it well).\n- Are there other dependencies and requirements besides those mentioned on the prerequisite page in the documentation or included in the Cargo.toml files? (maybe there is some C++ Makefile trauma speaking here :) .)\n- Besides the: feos/crates/feos-core/src/cubic.rs, which other files should be changed to produce all required python bindings and such?\n- And connected to that. Why are the cubic EoS rust files in the src root directory and not in the equation_of_state subdirectory like the ideal gas law?\n- While I have some ideas already on how VdW and SRK can be implemented, I expect more issues with the GERG model. Do you foresee pitfalls for such empirical models, and can you give some advises on how to approach it?\n\nI believe that FeOs would get the following gains from this proposal:\n- Having extensive, fast cubic EoS support might attract CFD crates to use FeOs for the prediction of fluid properties during simulations. Compressible CFD simulations require good and most of all fast EoS predictions for density, heat capacity and viscosity. I believe that FeOs can be attractive for such programs when there are more cubic equations of state to choose from.\n- When GERG-2008 is implemented, FeOs can claim that it can compute fluid properties compliant with the ISO 20765-2/3 standard. Scientifically, I do not see too much value in this, however, it might make FeOs suitable for usage in industry.\n\nI cannot work on this project professionally, as my PhD is about computing transport properties in complex aqueous salt mixtures and I do not intend to use FeOs for my own projects. However, I think I can learn aplenty from this side project (especially regarding traits) and I am willing to spend some evenings on it.\n\nWould you guys be interested in such extensions to FeOs?\nKind regards,\nJelle Lagerweij","author":{"url":"https://github.com/JelleLagerweij","@type":"Person","name":"JelleLagerweij"},"datePublished":"2025-05-14T21:20:13.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":17},"url":"https://github.com/280/feos/issues/280"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:5ec2579d-1afb-71d1-c61d-219e9b476dc1
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB65C:142C6C:6920AC:8FA926:698EFB82
html-safe-nonce36af383ad895e2c39de957dbe3945105ee9ff9c5593e9ca9dd43a2518f1431ea
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjVDOjE0MkM2Qzo2OTIwQUM6OEZBOTI2OjY5OEVGQjgyIiwidmlzaXRvcl9pZCI6IjQ3NDkwMzI3Nzc5MDIzOTAxNDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf32149ab8138185fc8684e66a66f0bfba4ee27aba133ad875e69c96a48964f44
hovercard-subject-tagissue:3064305082
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feos-org/feos/280/issue_layout
twitter:imagehttps://opengraph.githubassets.com/0fa572b6d096fe7fa2dfff4c638f8c3bb355488a781120fb67d5b81863ca08c6/feos-org/feos/issues/280
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0fa572b6d096fe7fa2dfff4c638f8c3bb355488a781120fb67d5b81863ca08c6/feos-org/feos/issues/280
og:image:altDear all, I am a PhD in the Engineering Thermodynamics group at the TU Delft. We mostly work on molecular simulations with Monte Carlo and molecular dynamics simulations in Fortran and C++. In my f...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJelleLagerweij
hostnamegithub.com
expected-hostnamegithub.com
None7f7bf82d8907f81525d95af82e60354b419d083df9534c8631d06bb9c0bf07ac
turbo-cache-controlno-preview
go-importgithub.com/feos-org/feos git https://github.com/feos-org/feos.git
octolytics-dimension-user_id87855701
octolytics-dimension-user_loginfeos-org
octolytics-dimension-repository_id424905104
octolytics-dimension-repository_nwofeos-org/feos
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id424905104
octolytics-dimension-repository_network_root_nwofeos-org/feos
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release29d97d94d5b31f96c01179273264722362f058e7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/feos-org/feos/issues/280#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeos-org%2Ffeos%2Fissues%2F280
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeos-org%2Ffeos%2Fissues%2F280
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=feos-org%2Ffeos
Reloadhttps://patch-diff.githubusercontent.com/feos-org/feos/issues/280
Reloadhttps://patch-diff.githubusercontent.com/feos-org/feos/issues/280
Reloadhttps://patch-diff.githubusercontent.com/feos-org/feos/issues/280
feos-org https://patch-diff.githubusercontent.com/feos-org
feoshttps://patch-diff.githubusercontent.com/feos-org/feos
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Ffeos-org%2Ffeos
Fork 30 https://patch-diff.githubusercontent.com/login?return_to=%2Ffeos-org%2Ffeos
Star 177 https://patch-diff.githubusercontent.com/login?return_to=%2Ffeos-org%2Ffeos
Code https://patch-diff.githubusercontent.com/feos-org/feos
Issues 22 https://patch-diff.githubusercontent.com/feos-org/feos/issues
Pull requests 5 https://patch-diff.githubusercontent.com/feos-org/feos/pulls
Discussions https://patch-diff.githubusercontent.com/feos-org/feos/discussions
Actions https://patch-diff.githubusercontent.com/feos-org/feos/actions
Projects 0 https://patch-diff.githubusercontent.com/feos-org/feos/projects
Security 0 https://patch-diff.githubusercontent.com/feos-org/feos/security
Insights https://patch-diff.githubusercontent.com/feos-org/feos/pulse
Code https://patch-diff.githubusercontent.com/feos-org/feos
Issues https://patch-diff.githubusercontent.com/feos-org/feos/issues
Pull requests https://patch-diff.githubusercontent.com/feos-org/feos/pulls
Discussions https://patch-diff.githubusercontent.com/feos-org/feos/discussions
Actions https://patch-diff.githubusercontent.com/feos-org/feos/actions
Projects https://patch-diff.githubusercontent.com/feos-org/feos/projects
Security https://patch-diff.githubusercontent.com/feos-org/feos/security
Insights https://patch-diff.githubusercontent.com/feos-org/feos/pulse
New issuehttps://patch-diff.githubusercontent.com/login?return_to=https://github.com/feos-org/feos/issues/280
New issuehttps://patch-diff.githubusercontent.com/login?return_to=https://github.com/feos-org/feos/issues/280
Extending EoS capabilitieshttps://patch-diff.githubusercontent.com/feos-org/feos/issues/280#top
https://github.com/JelleLagerweij
https://github.com/JelleLagerweij
JelleLagerweijhttps://github.com/JelleLagerweij
on May 14, 2025https://github.com/feos-org/feos/issues/280#issue-3064305082
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.