Title: core_dual_numbers example - confusion with units and references · Issue #105 · feos-org/feos · GitHub
Open Graph Title: core_dual_numbers example - confusion with units and references · Issue #105 · feos-org/feos
X Title: core_dual_numbers example - confusion with units and references · Issue #105 · feos-org/feos
Description: hi, I was reading and trying the first example 'core_dual_numbers' and got confused with some aspects: (some of which apply to the example "core_user_defined_eos.ipynb as well") see attachment notebook examples.zip in the rev1 attachment...
Open Graph Description: hi, I was reading and trying the first example 'core_dual_numbers' and got confused with some aspects: (some of which apply to the example "core_user_defined_eos.ipynb as well") see attachment note...
X Description: hi, I was reading and trying the first example 'core_dual_numbers' and got confused with some aspects: (some of which apply to the example "core_user_defined_eos.ipynb as well") s...
Opengraph URL: https://github.com/feos-org/feos/issues/105
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"core_dual_numbers example - confusion with units and references","articleBody":"hi,\r\nI was reading and trying the first example 'core_dual_numbers'\r\nand got confused with some aspects:\r\n(some of which apply to the example \"core_user_defined_eos.ipynb as well\")\r\n\u003e see attachment notebook [examples.zip](https://github.com/feos-org/feos/files/10396795/examples.zip)\r\n\r\nin the rev1 attachment i highlight some points of confusion\r\nin the rev2 attachment i try to refactor the Helmholtz function of the EOS to S.I. and Reid/Poling/Prausnitz notation, and try to get the same results as before for the dimensionless results (a_kt)\r\n\r\nmain issues:\r\n1) results for a_kt of the pyfunc and a_kt of the \"state.helmholtz_energy()/(KB*300*KELVIN)\" method does not seem to match - what does that mean?\r\n\u003e see values in the attachment\r\n\r\n2) the reference of the chemical potential, and its relation with fugacity coefficient is not clear for me,\r\nalso lnphi and lnphi_pure do not seem to match, what does that mean? \r\n(in my opinion the chemical potential / lnphi is a very motivating application for autodiffing)\r\n\u003e see values in the attachment\r\n\r\n3) i observed that the pyobject STATE, in the notebook body, contains quantities with units,\r\nbut the type of the object state that arrives at the Helmholtz function of the class is of the type \"\u003cclass 'builtins.StateF'\u003e\"\r\nand contains floats with implicit units - that also caused me some confusion when trying to take advantage of the units system inside the Helmholtz function, perhaps rename the argument of the \"def helmholtz_energy(self, state):\" to\r\n\"def helmholtz_energy(self, state_floats):\" / warn in the docstring of the class in the example that the received object contains only floats and array of floats (mol fracs)\r\n\r\nsuggestions:\r\n1) the example represents a bulk system (no confinement), but the values used for the example are of few angstrom**3 and few molecules size\r\n\u003e please see suggestion of macroscopic values\r\n\r\n2) the example uses values inside the helmholtz energy not in S.I., and with nonstandard notation for the a and a/(bt) or a/(brt) term\r\n\u003e please see suggestion of my attempt at an eos reprogrammed in S.I. and with notation from reid/poling/prausnitz\r\n\u003e where a has R**2 instead of R and helmholtz uses a term like a/(brt) instead of a/(bt)\r\n\r\nthanks for your attention","author":{"url":"https://github.com/iurisegtovich","@type":"Person","name":"iurisegtovich"},"datePublished":"2023-01-12T00:09:43.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/105/feos/issues/105"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:3c79dc7e-844c-9228-0b0c-943f9d92517c |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9E78:1648C7:1491B4C:1AEB82B:698FCF14 |
| html-safe-nonce | 07cc9b477c1e29f1b4f0b364252911968a377b3b0db49f5f97eb55ab51d8b9d6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTc4OjE2NDhDNzoxNDkxQjRDOjFBRUI4MkI6Njk4RkNGMTQiLCJ2aXNpdG9yX2lkIjoiNzY1MjUxMzQyMTEzMzMzNjM0MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 179bd14d6b3ccb5e4330faf9aa291fa526ab81c6330467ea04126938a89e443b |
| hovercard-subject-tag | issue:1529895218 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feos-org/feos/105/issue_layout |
| twitter:image | https://opengraph.githubassets.com/7c6bef07636042878d157572ca60c509edcb620347e7116458f7ba9396b6c71e/feos-org/feos/issues/105 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7c6bef07636042878d157572ca60c509edcb620347e7116458f7ba9396b6c71e/feos-org/feos/issues/105 |
| og:image:alt | hi, I was reading and trying the first example 'core_dual_numbers' and got confused with some aspects: (some of which apply to the example "core_user_defined_eos.ipynb as well") see attachment note... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | iurisegtovich |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-preview |
| go-import | github.com/feos-org/feos git https://github.com/feos-org/feos.git |
| octolytics-dimension-user_id | 87855701 |
| octolytics-dimension-user_login | feos-org |
| octolytics-dimension-repository_id | 424905104 |
| octolytics-dimension-repository_nwo | feos-org/feos |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 424905104 |
| octolytics-dimension-repository_network_root_nwo | feos-org/feos |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 00bbb8945a3943b287e04c68aff13cb5878ddde7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width