Title: Fix memory safety issues in KeyCodeConverter by PekingSpades · Pull Request #2 · fe9lix/CodingKeys · GitHub
Open Graph Title: Fix memory safety issues in KeyCodeConverter by PekingSpades · Pull Request #2 · fe9lix/CodingKeys
X Title: Fix memory safety issues in KeyCodeConverter by PekingSpades · Pull Request #2 · fe9lix/CodingKeys
Description: Summary Fix memory safety issues in KeyCodeConverter.m: Add NULL checks for CFStringCreateWithCharacters return value Add NULL checks for TISCopyCurrentKeyboardInputSource and TISGetInputSourceProperty return values to prevent crashes Fix pointer size mismatch in CFDictionaryGetValueIfPresent call that could cause stack corruption on 64-bit systems Problem The keyCodeForChar function has a critical bug: it passes a pointer to CGKeyCode (which is uint16_t, 2 bytes) to CFDictionaryGetValueIfPresent, but this function writes a pointer-sized value (8 bytes on 64-bit systems). This causes stack overflow and corrupts adjacent memory. Additionally, several CoreFoundation functions that can return NULL were not checked before use, which could lead to crashes. Changes keyCodeForChar function: Added NULL check for charStr after CFStringCreateWithCharacters Changed from (const void **)&code to using a proper pointer-sized variable codeValue, then safely casting to CGKeyCode createStringForKey function: Added NULL check for TISCopyCurrentKeyboardInputSource return value Added NULL check for TISGetInputSourceProperty return value with proper cleanup of currentKeyboard References Apple CF/CFDictionary.h - Documents that CFDictionaryGetValueIfPresent value parameter receives "the pointer-sized value" Apple Developer Forums - TISGetInputSourceProperty - Discusses NULL return cases for TIS functions Apple Developer Documentation - Investigating memory access crashes
Open Graph Description: Summary Fix memory safety issues in KeyCodeConverter.m: Add NULL checks for CFStringCreateWithCharacters return value Add NULL checks for TISCopyCurrentKeyboardInputSource and TISGetInputSourcePro...
X Description: Summary Fix memory safety issues in KeyCodeConverter.m: Add NULL checks for CFStringCreateWithCharacters return value Add NULL checks for TISCopyCurrentKeyboardInputSource and TISGetInputSourcePro...
Opengraph URL: https://github.com/fe9lix/CodingKeys/pull/2
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:8641fb60-4a68-d4ea-ef0c-43785026a530 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E26A:13E973:9366AD:CA4B78:698EFD12 |
| html-safe-nonce | 7d1bf176ecb9870f261b0636754a2294c5b9e3a2fb810e956c89bacfae6e86ce |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjZBOjEzRTk3Mzo5MzY2QUQ6Q0E0Qjc4OjY5OEVGRDEyIiwidmlzaXRvcl9pZCI6IjMzNTMxNTI2NTcwNTczMTYxMTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | fa6ad04ff1ad0070509d3874932a16df78d6356f2aff3c732118b641e2e3e6e3 |
| hovercard-subject-tag | pull_request:3138966338 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/fe9lix/CodingKeys/pull/2/files |
| twitter:image | https://avatars.githubusercontent.com/u/180665176?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/180665176?s=400&v=4 |
| og:image:alt | Summary Fix memory safety issues in KeyCodeConverter.m: Add NULL checks for CFStringCreateWithCharacters return value Add NULL checks for TISCopyCurrentKeyboardInputSource and TISGetInputSourcePro... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7f7bf82d8907f81525d95af82e60354b419d083df9534c8631d06bb9c0bf07ac |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/fe9lix/CodingKeys git https://github.com/fe9lix/CodingKeys.git |
| octolytics-dimension-user_id | 213498 |
| octolytics-dimension-user_login | fe9lix |
| octolytics-dimension-repository_id | 14282422 |
| octolytics-dimension-repository_nwo | fe9lix/CodingKeys |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 14282422 |
| octolytics-dimension-repository_network_root_nwo | fe9lix/CodingKeys |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 29d97d94d5b31f96c01179273264722362f058e7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width