Title: Review the CorrectFactor · Issue #788 · ev3dev-lang-java/ev3dev-lang-java · GitHub
Open Graph Title: Review the CorrectFactor · Issue #788 · ev3dev-lang-java/ev3dev-lang-java
X Title: Review the CorrectFactor · Issue #788 · ev3dev-lang-java/ev3dev-lang-java
Description: Reviewing the GenericMode, I made few questions: Is it necessary the CorrectFactor? Is it necessary to return 0? https://github.com/ev3dev-lang-java/ev3dev-lang-java/blob/master/src/main/java/ev3dev/sensors/GenericMode.java reading *= co...
Open Graph Description: Reviewing the GenericMode, I made few questions: Is it necessary the CorrectFactor? Is it necessary to return 0? https://github.com/ev3dev-lang-java/ev3dev-lang-java/blob/master/src/main/java/ev3de...
X Description: Reviewing the GenericMode, I made few questions: Is it necessary the CorrectFactor? Is it necessary to return 0? https://github.com/ev3dev-lang-java/ev3dev-lang-java/blob/master/src/main/java/ev3de...
Opengraph URL: https://github.com/ev3dev-lang-java/ev3dev-lang-java/issues/788
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Review the CorrectFactor","articleBody":"Reviewing the GenericMode, I made few questions:\r\n\r\n- Is it necessary the CorrectFactor?\r\n- Is it necessary to return 0?\r\n\r\nhttps://github.com/ev3dev-lang-java/ev3dev-lang-java/blob/master/src/main/java/ev3dev/sensors/GenericMode.java\r\n\r\n```java\r\n reading *= correctFactor;\r\n if (reading \u003c correctMin) {\r\n reading = 0;\r\n } else if (reading \u003e= correctMax) {\r\n reading = Float.POSITIVE_INFINITY;\r\n }\r\n```\r\n\r\n- [ ] Review consumers and the effect to remove correctFactor \u0026 return reading = Float.NEGATIVE_INFINITY\r\n\r\n\r\n","author":{"url":"https://github.com/jabrena","@type":"Person","name":"jabrena"},"datePublished":"2021-01-08T20:30:13.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/788/ev3dev-lang-java/issues/788"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:baa0fe92-e21e-7fc9-ec4d-c9423de0fb88 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 844C:2946F1:5A7962A:7A0E552:696E24EA |
| html-safe-nonce | 9e20e6a28bd5eeda397e5a1c86479ae37de4334ae3571f5e63b68b0310e43918 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDRDOjI5NDZGMTo1QTc5NjJBOjdBMEU1NTI6Njk2RTI0RUEiLCJ2aXNpdG9yX2lkIjoiMjkxMTUwNTAxODI5ODE4MDg0MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 38934872eacbb6bb0d064efd25248635b92040e900f0158dcf2775efce0c4a58 |
| hovercard-subject-tag | issue:782378225 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/ev3dev-lang-java/ev3dev-lang-java/788/issue_layout |
| twitter:image | https://opengraph.githubassets.com/84461cbde34181e621d15b78dd71645c6c76a0462be966a0722b166cc578119f/ev3dev-lang-java/ev3dev-lang-java/issues/788 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/84461cbde34181e621d15b78dd71645c6c76a0462be966a0722b166cc578119f/ev3dev-lang-java/ev3dev-lang-java/issues/788 |
| og:image:alt | Reviewing the GenericMode, I made few questions: Is it necessary the CorrectFactor? Is it necessary to return 0? https://github.com/ev3dev-lang-java/ev3dev-lang-java/blob/master/src/main/java/ev3de... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jabrena |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2fbe8cba5e260284c10af515699ff9bb2d6ace05ab6c2e2e585b71d93b2812c3 |
| turbo-cache-control | no-preview |
| go-import | github.com/ev3dev-lang-java/ev3dev-lang-java git https://github.com/ev3dev-lang-java/ev3dev-lang-java.git |
| octolytics-dimension-user_id | 17526590 |
| octolytics-dimension-user_login | ev3dev-lang-java |
| octolytics-dimension-repository_id | 45205585 |
| octolytics-dimension-repository_nwo | ev3dev-lang-java/ev3dev-lang-java |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45205585 |
| octolytics-dimension-repository_network_root_nwo | ev3dev-lang-java/ev3dev-lang-java |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7fb3bc5c995a876085291706b75cf9b08900c338 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width