René's URL Explorer Experiment


Title: DocList raises exception for type object. · Issue #1828 · docarray/docarray · GitHub

Open Graph Title: DocList raises exception for type object. · Issue #1828 · docarray/docarray

X Title: DocList raises exception for type object. · Issue #1828 · docarray/docarray

Description: Initial Checks I have read and followed the docs and still think this is a bug Description This commit introduced a check to verify that DocList is not used with an object: if ( isinstance(item, object) and not is_typevar(item) and not i...

Open Graph Description: Initial Checks I have read and followed the docs and still think this is a bug Description This commit introduced a check to verify that DocList is not used with an object: if ( isinstance(item, ob...

X Description: Initial Checks I have read and followed the docs and still think this is a bug Description This commit introduced a check to verify that DocList is not used with an object: if ( isinstance(item, ob...

Opengraph URL: https://github.com/docarray/docarray/issues/1828

X: @github

direct link

Domain: patch-diff.githubusercontent.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"DocList raises exception for type object.","articleBody":"### Initial Checks\r\n\r\n- [X] I have read and followed [the docs](https://docs.docarray.org/) and still think this is a bug\r\n\r\n### Description\r\n\r\nThis [commit](https://github.com/docarray/docarray/commit/2f3b85e333446cfa9b8c4877c4ccf9ae49cae660) introduced a check to verify that DocList is not used with an object: \r\n```\r\n        if (\r\n            isinstance(item, object)\r\n            and not is_typevar(item)\r\n            and not isinstance(item, str)\r\n            and item is not Any\r\n        ):\r\n               raise TypeError('Expecting a type, got object instead')\r\n ```\r\n\r\nThis is quite a broad condition (it breaks things like `DocList[TorchTensor]`, or nested `DocList[DocList[...]]` for me for instance) as:\r\n- Almost everything will be an object so the first line if almost a catch-all. \r\n- `is_typevar` only checks for TypeVar objects.\r\n\r\nShould this not check as well for something `not isinstance(item, type)` instead of `not is_typevar` to allow for classes ?\r\nThis way only non class objects (like instances of class object that are not classes themselves) will raise the `TypeError`. \r\n\r\n### Example Code\r\n\r\n```Python\r\nfrom docarray import DocList\r\nfrom docarray.typing import TorchTensor\r\ntest = DocList[TorchTensor]\r\n```\r\n\r\n\r\n### Python, DocArray \u0026 OS Version\r\n\r\n```Text\r\n0.39.1\r\n```\r\n\r\n\r\n### Affected Components\r\n\r\n- [ ] [Vector Database / Index](https://docs.docarray.org/user_guide/storing/docindex/)\r\n- [X] [Representing](https://docs.docarray.org/user_guide/representing/first_step)\r\n- [ ] [Sending](https://docs.docarray.org/user_guide/sending/first_step/)\r\n- [ ] [storing](https://docs.docarray.org/user_guide/storing/first_step/)\r\n- [X] [multi modal data type](https://docs.docarray.org/data_types/first_steps/)","author":{"url":"https://github.com/corentinmarek","@type":"Person","name":"corentinmarek"},"datePublished":"2023-10-30T19:17:54.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/1828/docarray/issues/1828"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:b9956972-ac02-09ef-61e4-c7fc26e9e0e2
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDE62:16196:47D89:62500:6982FFC1
html-safe-nonce7168e4e388ca862042314bc77072edae80db612c035ccf1e62797ea9b8f7fc71
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTYyOjE2MTk2OjQ3RDg5OjYyNTAwOjY5ODJGRkMxIiwidmlzaXRvcl9pZCI6IjU5NDk5ODY0ODk2NjkzODU2MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac35df988d4d950df1c3ef0319d57efeffb2620c3a3dc7cae950cae9acac710ccd
hovercard-subject-tagissue:1969052553
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/docarray/docarray/1828/issue_layout
twitter:imagehttps://opengraph.githubassets.com/55abe305b4c42c3a8f1c7e54e61e36bad7095de38d79f60d3f203b0a828998bd/docarray/docarray/issues/1828
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/55abe305b4c42c3a8f1c7e54e61e36bad7095de38d79f60d3f203b0a828998bd/docarray/docarray/issues/1828
og:image:altInitial Checks I have read and followed the docs and still think this is a bug Description This commit introduced a check to verify that DocList is not used with an object: if ( isinstance(item, ob...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecorentinmarek
hostnamegithub.com
expected-hostnamegithub.com
Nonec6741528aa4d4ba81c57bbff8f8cc0de0e9115cb2993431dc9dac8d489f7b4ee
turbo-cache-controlno-preview
go-importgithub.com/docarray/docarray git https://github.com/docarray/docarray.git
octolytics-dimension-user_id117445116
octolytics-dimension-user_logindocarray
octolytics-dimension-repository_id438303578
octolytics-dimension-repository_nwodocarray/docarray
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id438303578
octolytics-dimension-repository_network_root_nwodocarray/docarray
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedf2a3cea9cc9adaf422cd462f5351935c407af4d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/docarray/docarray/issues/1828#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdocarray%2Fdocarray%2Fissues%2F1828
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdocarray%2Fdocarray%2Fissues%2F1828
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=docarray%2Fdocarray
Reloadhttps://patch-diff.githubusercontent.com/docarray/docarray/issues/1828
Reloadhttps://patch-diff.githubusercontent.com/docarray/docarray/issues/1828
Reloadhttps://patch-diff.githubusercontent.com/docarray/docarray/issues/1828
docarray https://patch-diff.githubusercontent.com/docarray
docarrayhttps://patch-diff.githubusercontent.com/docarray/docarray
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fdocarray%2Fdocarray
Fork 234 https://patch-diff.githubusercontent.com/login?return_to=%2Fdocarray%2Fdocarray
Star 3.1k https://patch-diff.githubusercontent.com/login?return_to=%2Fdocarray%2Fdocarray
Code https://patch-diff.githubusercontent.com/docarray/docarray
Issues 68 https://patch-diff.githubusercontent.com/docarray/docarray/issues
Pull requests 36 https://patch-diff.githubusercontent.com/docarray/docarray/pulls
Discussions https://patch-diff.githubusercontent.com/docarray/docarray/discussions
Actions https://patch-diff.githubusercontent.com/docarray/docarray/actions
Security 0 https://patch-diff.githubusercontent.com/docarray/docarray/security
Insights https://patch-diff.githubusercontent.com/docarray/docarray/pulse
Code https://patch-diff.githubusercontent.com/docarray/docarray
Issues https://patch-diff.githubusercontent.com/docarray/docarray/issues
Pull requests https://patch-diff.githubusercontent.com/docarray/docarray/pulls
Discussions https://patch-diff.githubusercontent.com/docarray/docarray/discussions
Actions https://patch-diff.githubusercontent.com/docarray/docarray/actions
Security https://patch-diff.githubusercontent.com/docarray/docarray/security
Insights https://patch-diff.githubusercontent.com/docarray/docarray/pulse
New issuehttps://patch-diff.githubusercontent.com/login?return_to=https://github.com/docarray/docarray/issues/1828
New issuehttps://patch-diff.githubusercontent.com/login?return_to=https://github.com/docarray/docarray/issues/1828
#1829https://github.com/docarray/docarray/pull/1829
DocList raises exception for type object.https://patch-diff.githubusercontent.com/docarray/docarray/issues/1828#top
#1829https://github.com/docarray/docarray/pull/1829
https://github.com/corentinmarek
https://github.com/corentinmarek
corentinmarekhttps://github.com/corentinmarek
on Oct 30, 2023https://github.com/docarray/docarray/issues/1828#issue-1969052553
the docshttps://docs.docarray.org/
commithttps://github.com/docarray/docarray/commit/2f3b85e333446cfa9b8c4877c4ccf9ae49cae660
Vector Database / Indexhttps://docs.docarray.org/user_guide/storing/docindex/
Representinghttps://docs.docarray.org/user_guide/representing/first_step
Sendinghttps://docs.docarray.org/user_guide/sending/first_step/
storinghttps://docs.docarray.org/user_guide/storing/first_step/
multi modal data typehttps://docs.docarray.org/data_types/first_steps/
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.