Title: Add option to save both morph and difference curve · Issue #238 · diffpy/diffpy.morph · GitHub
Open Graph Title: Add option to save both morph and difference curve · Issue #238 · diffpy/diffpy.morph
X Title: Add option to save both morph and difference curve · Issue #238 · diffpy/diffpy.morph
Description: Problem Currently, post #237, we only have either the option to save the morph or difference curve, not both. Proposed solution This requires a conversation about what the file names should be, and how the return of the morph function sh...
Open Graph Description: Problem Currently, post #237, we only have either the option to save the morph or difference curve, not both. Proposed solution This requires a conversation about what the file names should be, and...
X Description: Problem Currently, post #237, we only have either the option to save the morph or difference curve, not both. Proposed solution This requires a conversation about what the file names should be, and...
Opengraph URL: https://github.com/diffpy/diffpy.morph/issues/238
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Add option to save both morph and difference curve","articleBody":"### Problem\n\nCurrently, post #237, we only have either the option to save the morph or difference curve, not both.\n\n### Proposed solution\n\nThis requires a conversation about what the file names should be, and how the return of the morph function should be handled.\n\nIn `diffpy.utils`, we have the option to return either the header information or the data table, but not both. This was the result of a conversation where we did not want to confuse the user with a changing shape of returns given options.\n\nFor `morph`, I do think it is fast enough to recompute the diff/morph using the `apply` since the only real roadblock to computation time is refining. I.e. once you do `morph_params, diff_table = morph(..., get_diff=False)`, you can just insert the `morph_params` into the new call `_, morph_table = morph(..., **morph_params, get_diff=True, apply=True)` to quickly obtain the morph.\n\nAs such, #237 will maintain the either or return until after we have this discussion.","author":{"url":"https://github.com/Sparks29032","@type":"Person","name":"Sparks29032"},"datePublished":"2025-07-12T15:13:42.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/238/diffpy.morph/issues/238"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:a9b85116-7266-687d-ed80-10d83e938ee8 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A8CA:3FCC83:13AE1E:18DE1D:697421EE |
| html-safe-nonce | 9f708fbbac526a09bc7bd7294da15de5ffac464f608ad67359aa7cc594b25491 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOENBOjNGQ0M4MzoxM0FFMUU6MThERTFEOjY5NzQyMUVFIiwidmlzaXRvcl9pZCI6IjI4NjcyNjM1MDUwNzUyODI0MTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 6c097b62a7e0f7af2765ed5a8cf8bd7bb00981fe6272adc865155293204c82c1 |
| hovercard-subject-tag | issue:3225469513 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/diffpy/diffpy.morph/238/issue_layout |
| twitter:image | https://opengraph.githubassets.com/786120a4e629753a013a8b9dff60adbec97ef9ba1b10b43036472a625bc4d27c/diffpy/diffpy.morph/issues/238 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/786120a4e629753a013a8b9dff60adbec97ef9ba1b10b43036472a625bc4d27c/diffpy/diffpy.morph/issues/238 |
| og:image:alt | Problem Currently, post #237, we only have either the option to save the morph or difference curve, not both. Proposed solution This requires a conversation about what the file names should be, and... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Sparks29032 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 447dc9917c3d68d647a01abfdefe55ec7ee1785922136c1d8395dbb3ab6d57b9 |
| turbo-cache-control | no-preview |
| go-import | github.com/diffpy/diffpy.morph git https://github.com/diffpy/diffpy.morph.git |
| octolytics-dimension-user_id | 5612611 |
| octolytics-dimension-user_login | diffpy |
| octolytics-dimension-repository_id | 116579729 |
| octolytics-dimension-repository_nwo | diffpy/diffpy.morph |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 116579729 |
| octolytics-dimension-repository_network_root_nwo | diffpy/diffpy.morph |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8dad7bdfecbe3eaa97ac4e632d6b47e2b23e81d9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width