Title: Clean up shared test functions, ensure coverage of edge cases · Issue #233 · diffpy/diffpy.morph · GitHub
Open Graph Title: Clean up shared test functions, ensure coverage of edge cases · Issue #233 · diffpy/diffpy.morph
X Title: Clean up shared test functions, ensure coverage of edge cases · Issue #233 · diffpy/diffpy.morph
Description: If any code is reused in tests, put it all in a function. If a particular function is shared across multiple test files, put it in the conftest. Rethink names of functions (e.g. isfloat -> is_float, are_files_same -> files_same). This is...
Open Graph Description: If any code is reused in tests, put it all in a function. If a particular function is shared across multiple test files, put it in the conftest. Rethink names of functions (e.g. isfloat -> is_float...
X Description: If any code is reused in tests, put it all in a function. If a particular function is shared across multiple test files, put it in the conftest. Rethink names of functions (e.g. isfloat -> is_fl...
Opengraph URL: https://github.com/diffpy/diffpy.morph/issues/233
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Clean up shared test functions, ensure coverage of edge cases","articleBody":"- [ ] If any code is reused in tests, put it all in a function. If a particular function is shared across multiple test files, put it in the conftest.\n - Rethink names of functions (e.g. isfloat -\u003e is_float, are_files_same -\u003e files_same). This is to mirror `numpy`'s `all_close` function naming.\n - [ ] Think up edge cases and cover them. One important one: `smear-pdf` when the target and objective `g(r)` functions are on different grids. This has not been covered in our tests.\n - [ ] Need tests for interfacing plotting and `morphapp`.","author":{"url":"https://github.com/Sparks29032","@type":"Person","name":"Sparks29032"},"datePublished":"2025-07-09T21:50:54.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/233/diffpy.morph/issues/233"}| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:31a3334c-16ff-b12a-4e21-8a4084c5a27d |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BCB0:327374:5BA5DB2:7CD2E71:69733D1A |
| html-safe-nonce | 5a8e1fa049c01e25ee2172d3edda7fb7ec17802c0aadd33fe1d4f342a504514a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQ0IwOjMyNzM3NDo1QkE1REIyOjdDRDJFNzE6Njk3MzNEMUEiLCJ2aXNpdG9yX2lkIjoiMzI5MTQ2NTI2NTg0ODcyODg1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | df0addc0c1da6af5d4004256cd1ffba75e9fa88d7f2a510048f51db6e7e27a80 |
| hovercard-subject-tag | issue:3217245536 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/diffpy/diffpy.morph/233/issue_layout |
| twitter:image | https://opengraph.githubassets.com/ffc51dd433e9611bf82c249d716f778559f89c3dd73106a878566a9661c18271/diffpy/diffpy.morph/issues/233 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ffc51dd433e9611bf82c249d716f778559f89c3dd73106a878566a9661c18271/diffpy/diffpy.morph/issues/233 |
| og:image:alt | If any code is reused in tests, put it all in a function. If a particular function is shared across multiple test files, put it in the conftest. Rethink names of functions (e.g. isfloat -> is_float... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Sparks29032 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 44ab3188c1dcfe3be0f9c3feca2e04e14fb79f120939ce2395e4f15ab96ec1d4 |
| turbo-cache-control | no-preview |
| go-import | github.com/diffpy/diffpy.morph git https://github.com/diffpy/diffpy.morph.git |
| octolytics-dimension-user_id | 5612611 |
| octolytics-dimension-user_login | diffpy |
| octolytics-dimension-repository_id | 116579729 |
| octolytics-dimension-repository_nwo | diffpy/diffpy.morph |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 116579729 |
| octolytics-dimension-repository_network_root_nwo | diffpy/diffpy.morph |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 75e56b01124e79ebbaa7864231f25e58fc1b5f25 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width