| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4a2dfe48-400e-7c81-24e0-5205d6fd7477 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C998:22A113:B7E3FA:F07F8F:6991FC9F |
| html-safe-nonce | b85d370fb5e5e09433837240f4883906e002df994508ac8124936cf486a9ad8b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTk4OjIyQTExMzpCN0UzRkE6RjA3RjhGOjY5OTFGQzlGIiwidmlzaXRvcl9pZCI6IjUxMjk1MzkxMTc2NTk1ODU2OTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 674af7da1dcd9c2756dd049f55b1c0d6d35cf792a831240a85334a7285858d8c |
| hovercard-subject-tag | pull_request:347534672 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/developit/unistore/182/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/85e4130bf3f9442f7a8ee7dadd94753758ac360cab9df585a97b01f71f8c3a84/developit/unistore/pull/182 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/85e4130bf3f9442f7a8ee7dadd94753758ac360cab9df585a97b01f71f8c3a84/developit/unistore/pull/182 |
| og:image:alt | This PR rethinks actions and action creators. An action now simply becomes an
unbound function with two arguments, state and store (or only store, see
discussion below). More commonly a user will u... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lkmill |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/developit/unistore git https://github.com/developit/unistore.git |
| octolytics-dimension-user_id | 105127 |
| octolytics-dimension-user_login | developit |
| octolytics-dimension-repository_id | 113351554 |
| octolytics-dimension-repository_nwo | developit/unistore |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 113351554 |
| octolytics-dimension-repository_network_root_nwo | developit/unistore |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/developit/unistore/pull/182#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdevelopit%2Funistore%2Fpull%2F182 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdevelopit%2Funistore%2Fpull%2F182 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=developit%2Funistore |
| Reload | https://patch-diff.githubusercontent.com/developit/unistore/pull/182 |
| Reload | https://patch-diff.githubusercontent.com/developit/unistore/pull/182 |
| Reload | https://patch-diff.githubusercontent.com/developit/unistore/pull/182 |
|
developit
| https://patch-diff.githubusercontent.com/developit |
| unistore | https://patch-diff.githubusercontent.com/developit/unistore |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Fdevelopit%2Funistore |
|
Fork
137
| https://patch-diff.githubusercontent.com/login?return_to=%2Fdevelopit%2Funistore |
|
Star
2.9k
| https://patch-diff.githubusercontent.com/login?return_to=%2Fdevelopit%2Funistore |
|
Code
| https://patch-diff.githubusercontent.com/developit/unistore |
|
Issues
36
| https://patch-diff.githubusercontent.com/developit/unistore/issues |
|
Pull requests
10
| https://patch-diff.githubusercontent.com/developit/unistore/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/developit/unistore/actions |
|
Projects
0
| https://patch-diff.githubusercontent.com/developit/unistore/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/developit/unistore/wiki |
|
Security
0
| https://patch-diff.githubusercontent.com/developit/unistore/security |
|
Insights
| https://patch-diff.githubusercontent.com/developit/unistore/pulse |
|
Code
| https://patch-diff.githubusercontent.com/developit/unistore |
|
Issues
| https://patch-diff.githubusercontent.com/developit/unistore/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/developit/unistore/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/developit/unistore/actions |
|
Projects
| https://patch-diff.githubusercontent.com/developit/unistore/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/developit/unistore/wiki |
|
Security
| https://patch-diff.githubusercontent.com/developit/unistore/security |
|
Insights
| https://patch-diff.githubusercontent.com/developit/unistore/pulse |
| lkmill | https://patch-diff.githubusercontent.com/lkmill |
| developit:master | https://patch-diff.githubusercontent.com/developit/unistore/tree/master |
| lkmill:feature/new-action-creators | https://patch-diff.githubusercontent.com/lkmill/unistore/tree/feature/new-action-creators |
| Conversation | https://patch-diff.githubusercontent.com/developit/unistore/pull/182 |
| Commits18 (18) | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits |
| Checks | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/checks |
| Files changed | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/files |
| WIP Rethinking actions and action creation | https://patch-diff.githubusercontent.com/developit/unistore/pull/182#top |
| lkmill | https://patch-diff.githubusercontent.com/lkmill |
| developit:master | https://patch-diff.githubusercontent.com/developit/unistore/tree/master |
| lkmill:feature/new-action-creators | https://patch-diff.githubusercontent.com/lkmill/unistore/tree/feature/new-action-creators |
|
| https://patch-diff.githubusercontent.com/lkmill |
| lkmill | https://patch-diff.githubusercontent.com/lkmill |
| Dec 2, 2019 | https://patch-diff.githubusercontent.com/developit/unistore/pull/182#issue-531015706 |
| Please reload this page | https://patch-diff.githubusercontent.com/developit/unistore/pull/182 |
| https://jsperf.com/binding-vs-action-creators | https://jsperf.com/binding-vs-action-creators |
| Please reload this page | https://patch-diff.githubusercontent.com/developit/unistore/pull/182 |
| lkmill | https://patch-diff.githubusercontent.com/lkmill |
| December 1, 2019 19:30 | https://patch-diff.githubusercontent.com/developit/unistore/pull/182#commits-pushed-4d862dc |
|
| https://patch-diff.githubusercontent.com/lkmill |
| Implement new action creator logic | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/4d862dc216450f8ead1426d1ed9465dcd9af73e9 |
| 4d862dc | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/4d862dc216450f8ead1426d1ed9465dcd9af73e9 |
|
| https://patch-diff.githubusercontent.com/lkmill |
| Update tests to work with new action creators | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/7214734a50ea662627e165cd9fed3946daba87e1 |
| 7214734 | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/7214734a50ea662627e165cd9fed3946daba87e1 |
|
| https://patch-diff.githubusercontent.com/lkmill |
| Update types to match new action logic | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/5e058170f6fbe18d323cd25520544304539639d1 |
| 5e05817 | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/5e058170f6fbe18d323cd25520544304539639d1 |
|
| https://patch-diff.githubusercontent.com/lkmill |
| Pass update object to listeners | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/5f629f7a30437bd8f90a07f7a101e64a0e5fc3d9 |
| 5f629f7 | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/5f629f7a30437bd8f90a07f7a101e64a0e5fc3d9 |
|
| https://patch-diff.githubusercontent.com/lkmill |
| Pass update object to devtools on action | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/c90747d1d97b83a98e38dc02041b8d3f03181af7 |
| c90747d | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/c90747d1d97b83a98e38dc02041b8d3f03181af7 |
|
| https://patch-diff.githubusercontent.com/lkmill |
| Differentiate between unnamed actions and direct setState calls in de… | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/9f22c9cca5872c89153fd17c4f64de061ea265dc |
| 9f22c9c | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/9f22c9cca5872c89153fd17c4f64de061ea265dc |
|
| https://patch-diff.githubusercontent.com/lkmill |
| Update tests to handle update argument in listeners | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/3b1e5b9ff06e673020d596c899754586c5057890 |
| 3b1e5b9 | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/3b1e5b9ff06e673020d596c899754586c5057890 |
|
| https://patch-diff.githubusercontent.com/lkmill |
| Prefer action.type over action.name | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/e856053acabdb4a6c59276f975798f9256e0e1fd |
| e856053 | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/e856053acabdb4a6c59276f975798f9256e0e1fd |
| https://patch-diff.githubusercontent.com/lkmill |
| lkmill | https://patch-diff.githubusercontent.com/lkmill |
|
Dec 4, 2019
| https://patch-diff.githubusercontent.com/developit/unistore/pull/182#ref-pullrequest-531030267 |
|
WIP Pass extra argument to actions
#183
| https://patch-diff.githubusercontent.com/developit/unistore/pull/183 |
| https://patch-diff.githubusercontent.com/lkmill |
| lkmill | https://patch-diff.githubusercontent.com/lkmill |
| Dec 5, 2019 | https://patch-diff.githubusercontent.com/developit/unistore/pull/182#event-2857720844 |
| https://patch-diff.githubusercontent.com/lkmill |
| lkmill | https://patch-diff.githubusercontent.com/lkmill |
| Dec 6, 2019 | https://patch-diff.githubusercontent.com/developit/unistore/pull/182#event-2862614100 |
|
Save 2 bytes
#180
| https://patch-diff.githubusercontent.com/developit/unistore/pull/180 |
|
Micro-optimize action binding by preallocating arguments array
#179
| https://patch-diff.githubusercontent.com/developit/unistore/pull/179 |
|
fix #171 - remove warnings about deprecated hook on react 16.9.0^
#172
| https://patch-diff.githubusercontent.com/developit/unistore/pull/172 |
| https://patch-diff.githubusercontent.com/lkmill |
| lkmill | https://patch-diff.githubusercontent.com/lkmill |
| Jan 3, 2020 | https://patch-diff.githubusercontent.com/developit/unistore/pull/182#issuecomment-570681627 |
| @developit | https://github.com/developit |
| Please reload this page | https://patch-diff.githubusercontent.com/developit/unistore/pull/182 |
| https://patch-diff.githubusercontent.com/Akiyamka |
| Akiyamka | https://patch-diff.githubusercontent.com/Akiyamka |
| Jan 4, 2020 | https://patch-diff.githubusercontent.com/developit/unistore/pull/182#issuecomment-570762039 |
| Please reload this page | https://patch-diff.githubusercontent.com/developit/unistore/pull/182 |
| https://patch-diff.githubusercontent.com/lkmill |
| lkmill | https://patch-diff.githubusercontent.com/lkmill |
| Jan 4, 2020 | https://patch-diff.githubusercontent.com/developit/unistore/pull/182#issuecomment-570803855 |
| Please reload this page | https://patch-diff.githubusercontent.com/developit/unistore/pull/182 |
| @Akiyamka | https://github.com/Akiyamka |
| Please reload this page | https://patch-diff.githubusercontent.com/developit/unistore/pull/182 |
| lkmill | https://patch-diff.githubusercontent.com/lkmill |
| April 6, 2020 00:07 | https://patch-diff.githubusercontent.com/developit/unistore/pull/182#commits-pushed-91ad719 |
|
| https://patch-diff.githubusercontent.com/lkmill |
| Pass store.getState and store.action to action functions | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/91ad7198c0524df2ae2460d43c538742081b2c84 |
| 91ad719 | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/91ad7198c0524df2ae2460d43c538742081b2c84 |
|
| https://patch-diff.githubusercontent.com/lkmill |
| Split Action type into separate AsyncAction and SyncAction | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/203dc79ef32bcf83ab7e649cadbad9c49da974c6 |
| 203dc79 | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/203dc79ef32bcf83ab7e649cadbad9c49da974c6 |
|
| https://patch-diff.githubusercontent.com/lkmill |
| Update Action and MappedAction object types | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/a682ffd2a9ab46b6ae1129b9ae3a77b92390b57c |
| a682ffd | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/a682ffd2a9ab46b6ae1129b9ae3a77b92390b57c |
|
| https://patch-diff.githubusercontent.com/lkmill |
| Allow null mapStateToProps | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/49c4f8785be28e2f58199cc61440caeef420eba8 |
| 49c4f87 | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/49c4f8785be28e2f58199cc61440caeef420eba8 |
|
| https://patch-diff.githubusercontent.com/lkmill |
| Use correct type letter for store state | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/4dc3fde41558ddba0f1491eb87deac9476196cb2 |
| 4dc3fde | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/4dc3fde41558ddba0f1491eb87deac9476196cb2 |
| https://patch-diff.githubusercontent.com/lkmill |
| lkmill | https://patch-diff.githubusercontent.com/lkmill |
| force-pushed | https://patch-diff.githubusercontent.com/developit/unistore/compare/06663cb747e28c1622917783e9fc6f302d9d344f..4dc3fde41558ddba0f1491eb87deac9476196cb2 |
| 06663cb | https://patch-diff.githubusercontent.com/developit/unistore/commit/06663cb747e28c1622917783e9fc6f302d9d344f |
| 4dc3fde | https://patch-diff.githubusercontent.com/developit/unistore/commit/4dc3fde41558ddba0f1491eb87deac9476196cb2 |
|
Compare
| https://patch-diff.githubusercontent.com/developit/unistore/compare/06663cb747e28c1622917783e9fc6f302d9d344f..4dc3fde41558ddba0f1491eb87deac9476196cb2 |
| April 6, 2020 15:51 | https://patch-diff.githubusercontent.com/developit/unistore/pull/182#event-3206034498 |
| lkmill | https://patch-diff.githubusercontent.com/lkmill |
| April 6, 2020 18:23 | https://patch-diff.githubusercontent.com/developit/unistore/pull/182#commits-pushed-c246282 |
|
| https://patch-diff.githubusercontent.com/lkmill |
| Rename store.action to store.dispatch | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/c24628295486deebc575c3ea97764efc503bfd45 |
| c246282 | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/c24628295486deebc575c3ea97764efc503bfd45 |
|
| https://patch-diff.githubusercontent.com/lkmill |
| Move out dispatch and getState to fix this reference errors | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/f38838996bb7da4af53937dd3f2b5043bb34c129 |
| f388389 | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/f38838996bb7da4af53937dd3f2b5043bb34c129 |
|
| https://patch-diff.githubusercontent.com/lkmill |
| Update tests to pass new logic | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/f53452e7446e1a0de641775acd680c852fd0c2fb |
| f53452e | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/f53452e7446e1a0de641775acd680c852fd0c2fb |
|
| https://patch-diff.githubusercontent.com/lkmill |
| Print state properties that have changed in unnamed actions and setState | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/4361a8319f3e7ac2eb71b3a92e529bf4148d40ae |
| 4361a83 | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/4361a8319f3e7ac2eb71b3a92e529bf4148d40ae |
|
| https://patch-diff.githubusercontent.com/lkmill |
| Set update to empty object if not supplied | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/ac1f2caab584068d6cd0aebf4118dcdb1a033a70 |
| ac1f2ca | https://patch-diff.githubusercontent.com/developit/unistore/pull/182/commits/ac1f2caab584068d6cd0aebf4118dcdb1a033a70 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/developit/unistore/pull/{{ revealButtonHref }} |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdevelopit%2Funistore%2Fpull%2F182 |
| Please reload this page | https://patch-diff.githubusercontent.com/developit/unistore/pull/182 |
|
| https://patch-diff.githubusercontent.com/lkmill |
|
| https://patch-diff.githubusercontent.com/Akiyamka |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |