René's URL Explorer Experiment


Title: Typings for function binding an action does not allow async · Issue #198 · developit/unistore · GitHub

Open Graph Title: Typings for function binding an action does not allow async · Issue #198 · developit/unistore

X Title: Typings for function binding an action does not allow async · Issue #198 · developit/unistore

Description: When binding a function manually.... import createStore from 'unistore' const store = createStore({ count: 0, stuff: [] }) const myAsyncAction = async (state, store) => { await somethingAsync() .... }; ...and do the actual binding const ...

Open Graph Description: When binding a function manually.... import createStore from 'unistore' const store = createStore({ count: 0, stuff: [] }) const myAsyncAction = async (state, store) => { await somethingAsync() ......

X Description: When binding a function manually.... import createStore from 'unistore' const store = createStore({ count: 0, stuff: [] }) const myAsyncAction = async (state, store) => { await something...

Opengraph URL: https://github.com/developit/unistore/issues/198

X: @github

direct link

Domain: patch-diff.githubusercontent.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Typings for function binding an action does not allow async","articleBody":"When binding a function manually....\r\n\r\n```js\r\nimport createStore from 'unistore'\r\n\r\nconst store = createStore({ count: 0, stuff: [] })\r\n\r\nconst myAsyncAction = async (state, store) =\u003e {\r\n  await somethingAsync()\r\n  ....\r\n};\r\n```\r\n...and do the actual binding\r\n```js\r\nconst myBoundAsyncAction = store.action(myAsyncAction)\r\n```\r\nIt will result in..\r\n`Promise returned in function argument where a void return was expected.eslint[@typescript-eslint/no-misused-promises](https://typescript-eslint.io/rules/no-misused-promises)`\r\n...because [the typings](https://github.com/developit/unistore/blob/f3a4e99d4c62b27773fa2e520998e55f129f3819/index.d.ts#L8) does not allow for an async function.\r\n\r\nA suggested fix would be to type `Action` the same way as `ActionFn` but with the addition of `Promise\u003cvoid\u003e` (which should also be added to ActionFn i guess). Ie:\r\n\r\n```js\r\nexport type Action\u003cK\u003e = (state: K, ...args: any[]) =\u003e Promise\u003cPartial\u003cK\u003e\u003e | Partial\u003cK\u003e | Promise\u003cvoid\u003e | void;\r\n```","author":{"url":"https://github.com/jschill","@type":"Person","name":"jschill"},"datePublished":"2022-10-07T09:45:39.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/198/unistore/issues/198"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:73c8570a-25c6-d291-b339-91e9ba7debb2
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8FFE:1DE5:567C80:6CA3E0:6990C774
html-safe-noncec4793ce81fcdb0e682a520b5e8842fba3484ee80764946753b12282c2a5b9c45
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RkZFOjFERTU6NTY3QzgwOjZDQTNFMDo2OTkwQzc3NCIsInZpc2l0b3JfaWQiOiIzNTI4NTE1MjI2ODYwMzA4MzQwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac741e253420b61fc4d59678c20d8c0b8af0eab84cafc90c71e1660cbc340b0e02
hovercard-subject-tagissue:1400907786
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/developit/unistore/198/issue_layout
twitter:imagehttps://opengraph.githubassets.com/b07fb1c82dacbdecdf9559812ee94366033a91660c86a821b8526a9d0d791ea9/developit/unistore/issues/198
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b07fb1c82dacbdecdf9559812ee94366033a91660c86a821b8526a9d0d791ea9/developit/unistore/issues/198
og:image:altWhen binding a function manually.... import createStore from 'unistore' const store = createStore({ count: 0, stuff: [] }) const myAsyncAction = async (state, store) => { await somethingAsync() ......
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejschill
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-preview
go-importgithub.com/developit/unistore git https://github.com/developit/unistore.git
octolytics-dimension-user_id105127
octolytics-dimension-user_logindevelopit
octolytics-dimension-repository_id113351554
octolytics-dimension-repository_nwodevelopit/unistore
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id113351554
octolytics-dimension-repository_network_root_nwodevelopit/unistore
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/developit/unistore/issues/198#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdevelopit%2Funistore%2Fissues%2F198
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fdevelopit%2Funistore%2Fissues%2F198
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=developit%2Funistore
Reloadhttps://patch-diff.githubusercontent.com/developit/unistore/issues/198
Reloadhttps://patch-diff.githubusercontent.com/developit/unistore/issues/198
Reloadhttps://patch-diff.githubusercontent.com/developit/unistore/issues/198
developit https://patch-diff.githubusercontent.com/developit
unistorehttps://patch-diff.githubusercontent.com/developit/unistore
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fdevelopit%2Funistore
Fork 137 https://patch-diff.githubusercontent.com/login?return_to=%2Fdevelopit%2Funistore
Star 2.9k https://patch-diff.githubusercontent.com/login?return_to=%2Fdevelopit%2Funistore
Code https://patch-diff.githubusercontent.com/developit/unistore
Issues 36 https://patch-diff.githubusercontent.com/developit/unistore/issues
Pull requests 10 https://patch-diff.githubusercontent.com/developit/unistore/pulls
Actions https://patch-diff.githubusercontent.com/developit/unistore/actions
Projects 0 https://patch-diff.githubusercontent.com/developit/unistore/projects
Wiki https://patch-diff.githubusercontent.com/developit/unistore/wiki
Security 0 https://patch-diff.githubusercontent.com/developit/unistore/security
Insights https://patch-diff.githubusercontent.com/developit/unistore/pulse
Code https://patch-diff.githubusercontent.com/developit/unistore
Issues https://patch-diff.githubusercontent.com/developit/unistore/issues
Pull requests https://patch-diff.githubusercontent.com/developit/unistore/pulls
Actions https://patch-diff.githubusercontent.com/developit/unistore/actions
Projects https://patch-diff.githubusercontent.com/developit/unistore/projects
Wiki https://patch-diff.githubusercontent.com/developit/unistore/wiki
Security https://patch-diff.githubusercontent.com/developit/unistore/security
Insights https://patch-diff.githubusercontent.com/developit/unistore/pulse
New issuehttps://patch-diff.githubusercontent.com/login?return_to=https://github.com/developit/unistore/issues/198
New issuehttps://patch-diff.githubusercontent.com/login?return_to=https://github.com/developit/unistore/issues/198
Typings for function binding an action does not allow asynchttps://patch-diff.githubusercontent.com/developit/unistore/issues/198#top
https://github.com/jschill
https://github.com/jschill
jschillhttps://github.com/jschill
on Oct 7, 2022https://github.com/developit/unistore/issues/198#issue-1400907786
the typingshttps://github.com/developit/unistore/blob/f3a4e99d4c62b27773fa2e520998e55f129f3819/index.d.ts#L8
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.