| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0545ab12-db87-7a66-f777-aea390cd1946 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DF76:2B060B:17A0A1F:1FD4904:696EAB84 |
| html-safe-nonce | 6c33323748226f97e81e71bb410622820cbae9bb6dc387d86e405c864a022238 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjc2OjJCMDYwQjoxN0EwQTFGOjFGRDQ5MDQ6Njk2RUFCODQiLCJ2aXNpdG9yX2lkIjoiNDcyODkwNTU5NzgxODQxNzk2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d87a276eb89c23ed82ed31d567900fa8215e477188ac2186b07708833b5fddaa |
| hovercard-subject-tag | pull_request:135011913 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/derek73/python-nameparser/61/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ab6dc8f9a1131aac79b481cb21a6f23e9adc78a0939876bb19a2ea6b953145e3/derek73/python-nameparser/pull/61 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ab6dc8f9a1131aac79b481cb21a6f23e9adc78a0939876bb19a2ea6b953145e3/derek73/python-nameparser/pull/61 |
| og:image:alt | This PR takes all "simple" unit tests, and puts them into a single JSON file to help clean things up.
The result is tests.py reduced to 814 lines, and an easier way to bulk-add new names ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | MilesCranmer |
| hostname | github.com |
| expected-hostname | github.com |
| None | fdad15fd2ad43212aa8b8be5f2c2725550f8374ceeeb154a999ad9145b43f3f7 |
| turbo-cache-control | no-preview |
| go-import | github.com/derek73/python-nameparser git https://github.com/derek73/python-nameparser.git |
| octolytics-dimension-user_id | 18306 |
| octolytics-dimension-user_login | derek73 |
| octolytics-dimension-repository_id | 18353524 |
| octolytics-dimension-repository_nwo | derek73/python-nameparser |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 18353524 |
| octolytics-dimension-repository_network_root_nwo | derek73/python-nameparser |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 27b23bc056eb973d350fc95afc848757edb9e7a9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fderek73%2Fpython-nameparser%2Fpull%2F61 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fderek73%2Fpython-nameparser%2Fpull%2F61 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=derek73%2Fpython-nameparser |
| Reload | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61 |
| Reload | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61 |
| Reload | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61 |
|
derek73
| https://patch-diff.githubusercontent.com/derek73 |
| python-nameparser | https://patch-diff.githubusercontent.com/derek73/python-nameparser |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Fderek73%2Fpython-nameparser |
|
Fork
106
| https://patch-diff.githubusercontent.com/login?return_to=%2Fderek73%2Fpython-nameparser |
|
Star
701
| https://patch-diff.githubusercontent.com/login?return_to=%2Fderek73%2Fpython-nameparser |
|
Code
| https://patch-diff.githubusercontent.com/derek73/python-nameparser |
|
Issues
30
| https://patch-diff.githubusercontent.com/derek73/python-nameparser/issues |
|
Pull requests
8
| https://patch-diff.githubusercontent.com/derek73/python-nameparser/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/derek73/python-nameparser/actions |
|
Projects
0
| https://patch-diff.githubusercontent.com/derek73/python-nameparser/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/derek73/python-nameparser/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://patch-diff.githubusercontent.com/derek73/python-nameparser/security |
| Please reload this page | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61 |
|
Insights
| https://patch-diff.githubusercontent.com/derek73/python-nameparser/pulse |
|
Code
| https://patch-diff.githubusercontent.com/derek73/python-nameparser |
|
Issues
| https://patch-diff.githubusercontent.com/derek73/python-nameparser/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/derek73/python-nameparser/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/derek73/python-nameparser/actions |
|
Projects
| https://patch-diff.githubusercontent.com/derek73/python-nameparser/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/derek73/python-nameparser/wiki |
|
Security
| https://patch-diff.githubusercontent.com/derek73/python-nameparser/security |
|
Insights
| https://patch-diff.githubusercontent.com/derek73/python-nameparser/pulse |
| Sign up for GitHub
| https://patch-diff.githubusercontent.com/signup?return_to=%2Fderek73%2Fpython-nameparser%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=%2Fderek73%2Fpython-nameparser%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61#issue-comment-box |
| MilesCranmer | https://patch-diff.githubusercontent.com/MilesCranmer |
| derek73:master | https://patch-diff.githubusercontent.com/derek73/python-nameparser/tree/master |
| MilesCranmer:master | https://patch-diff.githubusercontent.com/MilesCranmer/python-nameparser/tree/master |
|
Move all simple unit tests into JSON file
| https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61#top |
| MilesCranmer | https://patch-diff.githubusercontent.com/MilesCranmer |
| derek73:master | https://patch-diff.githubusercontent.com/derek73/python-nameparser/tree/master |
| MilesCranmer:master | https://patch-diff.githubusercontent.com/MilesCranmer/python-nameparser/tree/master |
|
Conversation
6
| https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61 |
|
Commits
9
| https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61/commits |
|
Checks
0
| https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61/checks |
|
Files changed
| https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61/files |
| Please reload this page | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/MilesCranmer |
| MilesCranmer | https://patch-diff.githubusercontent.com/MilesCranmer |
| Aug 9, 2017 | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61#issue-249190196 |
| Please reload this page | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61 |
| MilesCranmer | https://patch-diff.githubusercontent.com/MilesCranmer |
| August 9, 2017 22:59 | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61#commits-pushed-2356edc |
|
| https://patch-diff.githubusercontent.com/MilesCranmer |
| Remove all simple test and put in JSON | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61/commits/2356edcccd198d34783897ad6bfd68cba638cdd9 |
| 2356edc | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61/commits/2356edcccd198d34783897ad6bfd68cba638cdd9 |
|
| https://patch-diff.githubusercontent.com/MilesCranmer |
| Clean up residual newlines after scrape | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61/commits/3b35ed71925f2d6312c4cf35659aa343c8889caa |
| 3b35ed7 | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61/commits/3b35ed71925f2d6312c4cf35659aa343c8889caa |
|
| https://patch-diff.githubusercontent.com/MilesCranmer |
| Fix JSON testnames by making everything a string | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61/commits/a0005279c3f302bedf65969f539bc2ad951e4154 |
| a000527 | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61/commits/a0005279c3f302bedf65969f539bc2ad951e4154 |
|
| https://patch-diff.githubusercontent.com/MilesCranmer |
| Move escaped UTF-8 back to python tests.py | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61/commits/cb23c314fc5d24d1692c603274f9813d88cbde0b |
| cb23c31 | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61/commits/cb23c314fc5d24d1692c603274f9813d88cbde0b |
|
| https://patch-diff.githubusercontent.com/MilesCranmer |
| Fix single quotes in JSON testnames file | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61/commits/d86b4ef14ccd375fe55d5ced7d27b531b80547f6 |
| d86b4ef | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61/commits/d86b4ef14ccd375fe55d5ced7d27b531b80547f6 |
|
| https://patch-diff.githubusercontent.com/MilesCranmer |
| Fix blank name JSON entry | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61/commits/26e28cfa3e5fcea12f42d3d461ecced2820201c0 |
| 26e28cf | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61/commits/26e28cfa3e5fcea12f42d3d461ecced2820201c0 |
|
| https://patch-diff.githubusercontent.com/MilesCranmer |
| Fix duplicate test name in testnames.json | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61/commits/5cae192708bc1a7d42cf4b4a0e313f04d316ff05 |
| 5cae192 | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61/commits/5cae192708bc1a7d42cf4b4a0e313f04d316ff05 |
|
| https://patch-diff.githubusercontent.com/MilesCranmer |
| Add HumanNameTestBase to test all names in JSON | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61/commits/9618741b5712a1ee09e5bd6bbbc9f3e3a6b8f30c |
| 9618741 | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61/commits/9618741b5712a1ee09e5bd6bbbc9f3e3a6b8f30c |
| https://patch-diff.githubusercontent.com/MilesCranmer |
| MilesCranmer | https://patch-diff.githubusercontent.com/MilesCranmer |
| Aug 9, 2017 | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61#issuecomment-321412558 |
| https://www.ssa.gov/oact/babynames/limits.html | https://www.ssa.gov/oact/babynames/limits.html |
| https://www.census.gov/topics/population/genealogy/data/2000_surnames.html | https://www.census.gov/topics/population/genealogy/data/2000_surnames.html |
| Please reload this page | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61 |
| https://patch-diff.githubusercontent.com/derek73 |
| derek73 | https://patch-diff.githubusercontent.com/derek73 |
| Aug 10, 2017 | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61#issuecomment-321432745 |
| Please reload this page | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61 |
|
| https://patch-diff.githubusercontent.com/MilesCranmer |
| Fix JSON tests not running by changing class name | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61/commits/5a6857ecc005588848aacb3f9df46cb544281d4a |
| 5a6857e | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61/commits/5a6857ecc005588848aacb3f9df46cb544281d4a |
| https://patch-diff.githubusercontent.com/MilesCranmer |
| MilesCranmer | https://patch-diff.githubusercontent.com/MilesCranmer |
| Aug 10, 2017 | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61#issuecomment-321570977 |
| @derek73 | https://github.com/derek73 |
| Please reload this page | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61 |
| https://patch-diff.githubusercontent.com/MilesCranmer |
| MilesCranmer | https://patch-diff.githubusercontent.com/MilesCranmer |
| Aug 10, 2017 | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61#issuecomment-321574553 |
| Please reload this page | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61 |
| https://patch-diff.githubusercontent.com/derek73 |
| derek73 | https://patch-diff.githubusercontent.com/derek73 |
| Aug 11, 2017 | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61#issuecomment-321719525 |
| Please reload this page | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61 |
| Please reload this page | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61 |
| https://patch-diff.githubusercontent.com/derek73 |
| derek73 | https://patch-diff.githubusercontent.com/derek73 |
|
enhancement
| https://patch-diff.githubusercontent.com/derek73/python-nameparser/issues?q=state%3Aopen%20label%3Aenhancement |
| Aug 11, 2017 | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61#event-1201994018 |
| https://patch-diff.githubusercontent.com/derek73 |
| derek73 | https://patch-diff.githubusercontent.com/derek73 |
| v1.0 | https://patch-diff.githubusercontent.com/derek73/python-nameparser/milestone/21 |
| Aug 11, 2017 | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61#event-1201994042 |
| https://patch-diff.githubusercontent.com/derek73 |
| derek73 | https://patch-diff.githubusercontent.com/derek73 |
| Aug 11, 2017 | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61#issuecomment-321727059 |
| Please reload this page | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61 |
| https://patch-diff.githubusercontent.com/derek73 |
| derek73 | https://patch-diff.githubusercontent.com/derek73 |
| v1.0 | https://patch-diff.githubusercontent.com/derek73/python-nameparser/milestone/21 |
| Aug 31, 2018 | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61#event-1821234111 |
| https://patch-diff.githubusercontent.com/vaneseltine |
| vaneseltine | https://patch-diff.githubusercontent.com/vaneseltine |
|
Aug 1, 2019
| https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61#ref-pullrequest-475889383 |
|
Introduce parameterized pytest suite
#91
| https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/91 |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fderek73%2Fpython-nameparser%2Fpull%2F61 |
|
enhancement
| https://patch-diff.githubusercontent.com/derek73/python-nameparser/issues?q=state%3Aopen%20label%3Aenhancement |
| Please reload this page | https://patch-diff.githubusercontent.com/derek73/python-nameparser/pull/61 |
|
| https://patch-diff.githubusercontent.com/MilesCranmer |
|
| https://patch-diff.githubusercontent.com/derek73 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |