René's URL Explorer Experiment


Title: Add return type annotation for Construct.sizeof by laomaiweng · Pull Request #1117 · construct/construct · GitHub

Open Graph Title: Add return type annotation for Construct.sizeof by laomaiweng · Pull Request #1117 · construct/construct

X Title: Add return type annotation for Construct.sizeof by laomaiweng · Pull Request #1117 · construct/construct

Description: The default implementation of Construct.sizeof unconditionally raises a SizeofError, because it is meant to be overridden in subclasses. This confuses some type checkers (e.g., pyright) which incor...

Open Graph Description: The default implementation of Construct.sizeof unconditionally raises a SizeofError, because it is meant to be overridden in subclasses. This confuses some type checkers (e.g., pyright) which incor...

X Description: The default implementation of Construct.sizeof unconditionally raises a SizeofError, because it is meant to be overridden in subclasses. This confuses some type checkers (e.g., pyright) which incor...

Opengraph URL: https://github.com/construct/construct/pull/1117

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d77cd565-9380-ef01-0ec8-1d80135b6805
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id87D6:1587BA:6EDD171:916429C:696DB395
html-safe-nonce8dec5ea14c76499fe1586e9de324ce47cdbeaf648ef6713dad994eb5cc8859b2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4N0Q2OjE1ODdCQTo2RUREMTcxOjkxNjQyOUM6Njk2REIzOTUiLCJ2aXNpdG9yX2lkIjoiOTEyMDI0OTI0MjQ4NjQyMDM3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd3c4b03063d420db702ca62d1c4fa57a70d8257ca9cf1071206bfb6a087ff45d
hovercard-subject-tagpull_request:2702168031
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/construct/construct/1117/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f40c273bbe7bb60f103f62ada21cadc58157b953c34f772ca4c1cbc1fa08e3a7/construct/construct/pull/1117
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f40c273bbe7bb60f103f62ada21cadc58157b953c34f772ca4c1cbc1fa08e3a7/construct/construct/pull/1117
og:image:altThe default implementation of Construct.sizeof unconditionally raises a SizeofError, because it is meant to be overridden in subclasses. This confuses some type checkers (e.g., pyright) which incor...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelaomaiweng
hostnamegithub.com
expected-hostnamegithub.com
None4922b452d03cd8dbce479d866a11bc25b59ef6ee2da23aa9b0ddefa6bd4d0064
turbo-cache-controlno-preview
go-importgithub.com/construct/construct git https://github.com/construct/construct.git
octolytics-dimension-user_id1703836
octolytics-dimension-user_loginconstruct
octolytics-dimension-repository_id4218694
octolytics-dimension-repository_nwoconstruct/construct
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id1196772
octolytics-dimension-repository_parent_nwoMostAwesomeDude/construct
octolytics-dimension-repository_network_root_id1196772
octolytics-dimension-repository_network_root_nwoMostAwesomeDude/construct
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7e5ae23c70136152637ceee8d6faceb35596ec46
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/construct/construct/pull/1117#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fconstruct%2Fconstruct%2Fpull%2F1117
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fconstruct%2Fconstruct%2Fpull%2F1117
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=construct%2Fconstruct
Reloadhttps://patch-diff.githubusercontent.com/construct/construct/pull/1117
Reloadhttps://patch-diff.githubusercontent.com/construct/construct/pull/1117
Reloadhttps://patch-diff.githubusercontent.com/construct/construct/pull/1117
construct https://patch-diff.githubusercontent.com/construct
constructhttps://patch-diff.githubusercontent.com/construct/construct
MostAwesomeDude/constructhttps://patch-diff.githubusercontent.com/MostAwesomeDude/construct
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fconstruct%2Fconstruct
Fork 165 https://patch-diff.githubusercontent.com/login?return_to=%2Fconstruct%2Fconstruct
Star 994 https://patch-diff.githubusercontent.com/login?return_to=%2Fconstruct%2Fconstruct
Code https://patch-diff.githubusercontent.com/construct/construct
Issues 12 https://patch-diff.githubusercontent.com/construct/construct/issues
Pull requests 19 https://patch-diff.githubusercontent.com/construct/construct/pulls
Actions https://patch-diff.githubusercontent.com/construct/construct/actions
Projects 0 https://patch-diff.githubusercontent.com/construct/construct/projects
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/construct/construct/security
Please reload this pagehttps://patch-diff.githubusercontent.com/construct/construct/pull/1117
Insights https://patch-diff.githubusercontent.com/construct/construct/pulse
Code https://patch-diff.githubusercontent.com/construct/construct
Issues https://patch-diff.githubusercontent.com/construct/construct/issues
Pull requests https://patch-diff.githubusercontent.com/construct/construct/pulls
Actions https://patch-diff.githubusercontent.com/construct/construct/actions
Projects https://patch-diff.githubusercontent.com/construct/construct/projects
Security https://patch-diff.githubusercontent.com/construct/construct/security
Insights https://patch-diff.githubusercontent.com/construct/construct/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fconstruct%2Fconstruct%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fconstruct%2Fconstruct%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/construct/construct/pull/1117#issue-comment-box
laomaiwenghttps://patch-diff.githubusercontent.com/laomaiweng
construct:masterhttps://patch-diff.githubusercontent.com/construct/construct/tree/master
laomaiweng:patch-1https://patch-diff.githubusercontent.com/laomaiweng/construct/tree/patch-1
Add return type annotation for Construct.sizeof https://patch-diff.githubusercontent.com/construct/construct/pull/1117#top
laomaiwenghttps://patch-diff.githubusercontent.com/laomaiweng
construct:masterhttps://patch-diff.githubusercontent.com/construct/construct/tree/master
laomaiweng:patch-1https://patch-diff.githubusercontent.com/laomaiweng/construct/tree/patch-1
Conversation 0 https://patch-diff.githubusercontent.com/construct/construct/pull/1117
Commits 1 https://patch-diff.githubusercontent.com/construct/construct/pull/1117/commits
Checks 0 https://patch-diff.githubusercontent.com/construct/construct/pull/1117/checks
Files changed https://patch-diff.githubusercontent.com/construct/construct/pull/1117/files
Please reload this pagehttps://patch-diff.githubusercontent.com/construct/construct/pull/1117
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/construct/construct/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/laomaiweng
laomaiwenghttps://patch-diff.githubusercontent.com/laomaiweng
Jul 28, 2025https://patch-diff.githubusercontent.com/construct/construct/pull/1117#issue-3271442579
Please reload this pagehttps://patch-diff.githubusercontent.com/construct/construct/pull/1117
https://patch-diff.githubusercontent.com/laomaiweng
Add return type annotation for Construct.sizeofhttps://patch-diff.githubusercontent.com/construct/construct/pull/1117/commits/0068b015f452f0a5ece4e2fa75539c81aaaaeb2a
0068b01https://patch-diff.githubusercontent.com/construct/construct/pull/1117/commits/0068b015f452f0a5ece4e2fa75539c81aaaaeb2a
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fconstruct%2Fconstruct%2Fpull%2F1117
Please reload this pagehttps://patch-diff.githubusercontent.com/construct/construct/pull/1117
https://patch-diff.githubusercontent.com/laomaiweng
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.