| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:de44ace9-ab53-1cbc-49ca-c3170f563249 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C5DE:199F7E:1D67B49:295815D:6970E564 |
| html-safe-nonce | 327c78f0485bd7fd0e6afa6b4b0ee84ecac023721142a3e400ffb2238c830992 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNURFOjE5OUY3RToxRDY3QjQ5OjI5NTgxNUQ6Njk3MEU1NjQiLCJ2aXNpdG9yX2lkIjoiMTQxNjg3NjAxNDQwNjAwMjAyMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3288cd437884a23330ce67f6584d5602c1380d7f30bcf701b68f241c640cab82 |
| hovercard-subject-tag | pull_request:1958860558 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/codejive/java-properties/24/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a21314170c8668784ff5d716cf4abd254db499e3d2b7da1857f717e388224d45/codejive/java-properties/pull/24 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a21314170c8668784ff5d716cf4abd254db499e3d2b7da1857f717e388224d45/codejive/java-properties/pull/24 |
| og:image:alt | This fixes the store method taking an OutputStream by flushing and closing the writer created to wrap it.
It also introduces ApprovalTests (https://approvaltests.com/) to open a diff window when co... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gastaldi |
| hostname | github.com |
| expected-hostname | github.com |
| None | a8b3a33ad16bd33428ccc7800d4ea7bfc6b4990584847afdcb92b020b61a949b |
| turbo-cache-control | no-preview |
| go-import | github.com/codejive/java-properties git https://github.com/codejive/java-properties.git |
| octolytics-dimension-user_id | 56220728 |
| octolytics-dimension-user_login | codejive |
| octolytics-dimension-repository_id | 429250253 |
| octolytics-dimension-repository_nwo | codejive/java-properties |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 429250253 |
| octolytics-dimension-repository_network_root_nwo | codejive/java-properties |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b8a8c883a585a3dc6cb57fa8b7997b70c86a696c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcodejive%2Fjava-properties%2Fpull%2F24 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcodejive%2Fjava-properties%2Fpull%2F24 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=codejive%2Fjava-properties |
| Reload | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24 |
| Reload | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24 |
| Reload | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24 |
|
codejive
| https://patch-diff.githubusercontent.com/codejive |
| java-properties | https://patch-diff.githubusercontent.com/codejive/java-properties |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Fcodejive%2Fjava-properties |
|
Fork
3
| https://patch-diff.githubusercontent.com/login?return_to=%2Fcodejive%2Fjava-properties |
|
Star
11
| https://patch-diff.githubusercontent.com/login?return_to=%2Fcodejive%2Fjava-properties |
|
Code
| https://patch-diff.githubusercontent.com/codejive/java-properties |
|
Issues
1
| https://patch-diff.githubusercontent.com/codejive/java-properties/issues |
|
Pull requests
11
| https://patch-diff.githubusercontent.com/codejive/java-properties/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/codejive/java-properties/actions |
|
Projects
0
| https://patch-diff.githubusercontent.com/codejive/java-properties/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://patch-diff.githubusercontent.com/codejive/java-properties/security |
| Please reload this page | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24 |
|
Insights
| https://patch-diff.githubusercontent.com/codejive/java-properties/pulse |
|
Code
| https://patch-diff.githubusercontent.com/codejive/java-properties |
|
Issues
| https://patch-diff.githubusercontent.com/codejive/java-properties/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/codejive/java-properties/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/codejive/java-properties/actions |
|
Projects
| https://patch-diff.githubusercontent.com/codejive/java-properties/projects |
|
Security
| https://patch-diff.githubusercontent.com/codejive/java-properties/security |
|
Insights
| https://patch-diff.githubusercontent.com/codejive/java-properties/pulse |
| Sign up for GitHub
| https://patch-diff.githubusercontent.com/signup?return_to=%2Fcodejive%2Fjava-properties%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=%2Fcodejive%2Fjava-properties%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24#issue-comment-box |
| quintesse | https://patch-diff.githubusercontent.com/quintesse |
| codejive:main | https://patch-diff.githubusercontent.com/codejive/java-properties/tree/main |
| gastaldi:fix_os | https://patch-diff.githubusercontent.com/gastaldi/java-properties/tree/fix_os |
|
Fix Properties.store(OutputStream os, String comment)
| https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24#top |
| quintesse | https://patch-diff.githubusercontent.com/quintesse |
| codejive:main | https://patch-diff.githubusercontent.com/codejive/java-properties/tree/main |
| gastaldi:fix_os | https://patch-diff.githubusercontent.com/gastaldi/java-properties/tree/fix_os |
|
Conversation
7
| https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24 |
|
Commits
1
| https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24/commits |
|
Checks
0
| https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24/checks |
|
Files changed
| https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24/files |
| Please reload this page | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/codejive/java-properties/pull/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/gastaldi |
| gastaldi | https://patch-diff.githubusercontent.com/gastaldi |
| Jul 8, 2024 | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24#issue-2396787518 |
| Please reload this page | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24 |
| https://approvaltests.com/ | https://approvaltests.com/ |
| Properties#store(OutputStream) doesn't flush the output to the OutputStream #23 | https://github.com/codejive/java-properties/issues/23 |
| Please reload this page | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24 |
| https://patch-diff.githubusercontent.com/quintesse |
| quintesse | https://patch-diff.githubusercontent.com/quintesse |
| Jul 9, 2024 | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24#issuecomment-2215837248 |
| Please reload this page | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24 |
| https://patch-diff.githubusercontent.com/gastaldi |
| gastaldi | https://patch-diff.githubusercontent.com/gastaldi |
| Jul 9, 2024 | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24#issuecomment-2216069386 |
| Please reload this page | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24 |
| Please reload this page | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24 |
| https://patch-diff.githubusercontent.com/gastaldi |
| gastaldi | https://patch-diff.githubusercontent.com/gastaldi |
| force-pushed | https://patch-diff.githubusercontent.com/codejive/java-properties/compare/49df1005114fb80de51d06e5e5ca718d2fc19e2d..7de7d02aa79ebb6c275103e56f688214e6373a28 |
| 49df100 | https://patch-diff.githubusercontent.com/codejive/java-properties/commit/49df1005114fb80de51d06e5e5ca718d2fc19e2d |
| 7de7d02 | https://patch-diff.githubusercontent.com/codejive/java-properties/commit/7de7d02aa79ebb6c275103e56f688214e6373a28 |
|
Compare
| https://patch-diff.githubusercontent.com/codejive/java-properties/compare/49df1005114fb80de51d06e5e5ca718d2fc19e2d..7de7d02aa79ebb6c275103e56f688214e6373a28 |
| July 9, 2024 01:39 | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24#event-13431908364 |
| https://patch-diff.githubusercontent.com/gastaldi |
| gastaldi | https://patch-diff.githubusercontent.com/gastaldi |
|
Jul 9, 2024
| https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24#pullrequestreview-2164737034 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24/files |
| src/main/java/org/codejive/properties/Properties.java | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24/files#diff-cdbda3f9781ef7f769f54bda319f6fe76a2894724aeb652e65fb6edc61fa34b2 |
| Please reload this page | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24 |
| https://patch-diff.githubusercontent.com/quintesse |
| quintesse | https://patch-diff.githubusercontent.com/quintesse |
| Jul 9, 2024 | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24#issuecomment-2217158786 |
| Please reload this page | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24 |
| https://patch-diff.githubusercontent.com/quintesse |
| quintesse | https://patch-diff.githubusercontent.com/quintesse |
| July 9, 2024 09:33 | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24#event-13436851562 |
| https://patch-diff.githubusercontent.com/quintesse |
| quintesse | https://patch-diff.githubusercontent.com/quintesse |
|
Jul 9, 2024
| https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24#pullrequestreview-2165683129 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24/files |
| quintesse | https://patch-diff.githubusercontent.com/quintesse |
| https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24#pullrequestreview-2165683129 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24 |
|
| https://patch-diff.githubusercontent.com/gastaldi |
| Fix Properties.store(OutputStream os, String comment) | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24/commits/d219226383a4eaecc1c92ffd5cc4b1187245e3f3 |
| d219226 | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24/commits/d219226383a4eaecc1c92ffd5cc4b1187245e3f3 |
| https://patch-diff.githubusercontent.com/gastaldi |
| gastaldi | https://patch-diff.githubusercontent.com/gastaldi |
| force-pushed | https://patch-diff.githubusercontent.com/codejive/java-properties/compare/7de7d02aa79ebb6c275103e56f688214e6373a28..d219226383a4eaecc1c92ffd5cc4b1187245e3f3 |
| 7de7d02 | https://patch-diff.githubusercontent.com/codejive/java-properties/commit/7de7d02aa79ebb6c275103e56f688214e6373a28 |
| d219226 | https://patch-diff.githubusercontent.com/codejive/java-properties/commit/d219226383a4eaecc1c92ffd5cc4b1187245e3f3 |
|
Compare
| https://patch-diff.githubusercontent.com/codejive/java-properties/compare/7de7d02aa79ebb6c275103e56f688214e6373a28..d219226383a4eaecc1c92ffd5cc4b1187245e3f3 |
| July 9, 2024 13:12 | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24#event-13440071753 |
| https://patch-diff.githubusercontent.com/gastaldi |
| gastaldi | https://patch-diff.githubusercontent.com/gastaldi |
| quintesse | https://patch-diff.githubusercontent.com/quintesse |
| July 9, 2024 13:14 | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24#event-13440111050 |
| https://patch-diff.githubusercontent.com/gastaldi |
| gastaldi | https://patch-diff.githubusercontent.com/gastaldi |
| Jul 9, 2024 | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24#issuecomment-2217720029 |
| #26 | https://github.com/codejive/java-properties/pull/26 |
| Please reload this page | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24 |
| https://patch-diff.githubusercontent.com/quintesse |
| quintesse | https://patch-diff.githubusercontent.com/quintesse |
|
Jul 9, 2024
| https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24#pullrequestreview-2166973663 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24/files/d219226383a4eaecc1c92ffd5cc4b1187245e3f3 |
| https://patch-diff.githubusercontent.com/quintesse |
| quintesse | https://patch-diff.githubusercontent.com/quintesse |
| 2d98a64 | https://patch-diff.githubusercontent.com/codejive/java-properties/commit/2d98a6467741a24ef23da0bc32667fdd97368a8a |
| Jul 9, 2024 | https://github.com/codejive/java-properties/pull/24#event-13444037809 |
| https://patch-diff.githubusercontent.com/quintesse |
| quintesse | https://patch-diff.githubusercontent.com/quintesse |
| Jul 9, 2024 | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24#issuecomment-2218289688 |
| Please reload this page | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24 |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcodejive%2Fjava-properties%2Fpull%2F24 |
|
| https://patch-diff.githubusercontent.com/quintesse |
|
quintesse
| https://patch-diff.githubusercontent.com/quintesse |
|
| https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24/files/d219226383a4eaecc1c92ffd5cc4b1187245e3f3 |
|
Properties#store(OutputStream) doesn't flush the output to the OutputStream
| https://github.com/codejive/java-properties/issues/23 |
| Please reload this page | https://patch-diff.githubusercontent.com/codejive/java-properties/pull/24 |
|
| https://patch-diff.githubusercontent.com/gastaldi |
|
| https://patch-diff.githubusercontent.com/quintesse |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |