René's URL Explorer Experiment


Title: Code smells by BouaoudMalik · Pull Request #1007 · code4craft/webmagic · GitHub

Open Graph Title: Code smells by BouaoudMalik · Pull Request #1007 · code4craft/webmagic

X Title: Code smells by BouaoudMalik · Pull Request #1007 · code4craft/webmagic

Description: Hello ! this in this pull request, Im correcting and deleting Code smells, but also refactoring some methods for a better readability.

Open Graph Description: Hello ! this in this pull request, Im correcting and deleting Code smells, but also refactoring some methods for a better readability.

X Description: Hello ! this in this pull request, Im correcting and deleting Code smells, but also refactoring some methods for a better readability.

Opengraph URL: https://github.com/code4craft/webmagic/pull/1007

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:950f4cdc-31ee-4f19-45a4-e4324a1316f9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD04C:FD0CD:126F484:19908A1:696F4707
html-safe-nonce2e877ea17294144f1ef975679d7eabe7610cd7b140a329c03af00142fecbe392
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDRDOkZEMENEOjEyNkY0ODQ6MTk5MDhBMTo2OTZGNDcwNyIsInZpc2l0b3JfaWQiOiI3MTE4MTgyODk2Mzg3NDQyNDM5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc80c98b136c7fb6814c5d711f2c815758378c9a2e240c72ebc5313a2fb2031f1
hovercard-subject-tagpull_request:598756323
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/code4craft/webmagic/1007/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/860adb3dcd24844b4ef0e45d3e82217229ad780c2d38b5d6cf4ca3ef011c8f81/code4craft/webmagic/pull/1007
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/860adb3dcd24844b4ef0e45d3e82217229ad780c2d38b5d6cf4ca3ef011c8f81/code4craft/webmagic/pull/1007
og:image:altHello ! this in this pull request, Im correcting and deleting Code smells, but also refactoring some methods for a better readability.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBouaoudMalik
hostnamegithub.com
expected-hostnamegithub.com
Noneb278ad162d35332b6de714dfb005de04386c4d92df6475522bef910f491a35ee
turbo-cache-controlno-preview
go-importgithub.com/code4craft/webmagic git https://github.com/code4craft/webmagic.git
octolytics-dimension-user_id1351884
octolytics-dimension-user_logincode4craft
octolytics-dimension-repository_id9623064
octolytics-dimension-repository_nwocode4craft/webmagic
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id9623064
octolytics-dimension-repository_network_root_nwocode4craft/webmagic
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release39aed5006635ab6f45e6b77d23e73b08a00272a3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcode4craft%2Fwebmagic%2Fpull%2F1007
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcode4craft%2Fwebmagic%2Fpull%2F1007
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=code4craft%2Fwebmagic
Reloadhttps://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007
Reloadhttps://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007
Reloadhttps://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007
code4craft https://patch-diff.githubusercontent.com/code4craft
webmagichttps://patch-diff.githubusercontent.com/code4craft/webmagic
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fcode4craft%2Fwebmagic
Fork 4.2k https://patch-diff.githubusercontent.com/login?return_to=%2Fcode4craft%2Fwebmagic
Star 11.7k https://patch-diff.githubusercontent.com/login?return_to=%2Fcode4craft%2Fwebmagic
Code https://patch-diff.githubusercontent.com/code4craft/webmagic
Issues 337 https://patch-diff.githubusercontent.com/code4craft/webmagic/issues
Pull requests 30 https://patch-diff.githubusercontent.com/code4craft/webmagic/pulls
Actions https://patch-diff.githubusercontent.com/code4craft/webmagic/actions
Projects 0 https://patch-diff.githubusercontent.com/code4craft/webmagic/projects
Wiki https://patch-diff.githubusercontent.com/code4craft/webmagic/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/code4craft/webmagic/security
Please reload this pagehttps://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007
Insights https://patch-diff.githubusercontent.com/code4craft/webmagic/pulse
Code https://patch-diff.githubusercontent.com/code4craft/webmagic
Issues https://patch-diff.githubusercontent.com/code4craft/webmagic/issues
Pull requests https://patch-diff.githubusercontent.com/code4craft/webmagic/pulls
Actions https://patch-diff.githubusercontent.com/code4craft/webmagic/actions
Projects https://patch-diff.githubusercontent.com/code4craft/webmagic/projects
Wiki https://patch-diff.githubusercontent.com/code4craft/webmagic/wiki
Security https://patch-diff.githubusercontent.com/code4craft/webmagic/security
Insights https://patch-diff.githubusercontent.com/code4craft/webmagic/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fcode4craft%2Fwebmagic%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fcode4craft%2Fwebmagic%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007#issue-comment-box
BouaoudMalikhttps://patch-diff.githubusercontent.com/BouaoudMalik
code4craft:develophttps://patch-diff.githubusercontent.com/code4craft/webmagic/tree/develop
BouaoudMalik:code_smellshttps://patch-diff.githubusercontent.com/BouaoudMalik/webmagic/tree/code_smells
Code smells https://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007#top
BouaoudMalikhttps://patch-diff.githubusercontent.com/BouaoudMalik
code4craft:develophttps://patch-diff.githubusercontent.com/code4craft/webmagic/tree/develop
BouaoudMalik:code_smellshttps://patch-diff.githubusercontent.com/BouaoudMalik/webmagic/tree/code_smells
Conversation 0 https://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007
Commits 8 https://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007/commits
Checks 0 https://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007/checks
Files changed https://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007/files
Please reload this pagehttps://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/code4craft/webmagic/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/BouaoudMalik
BouaoudMalikhttps://patch-diff.githubusercontent.com/BouaoudMalik
Mar 23, 2021https://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007#issue-838602450
Please reload this pagehttps://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007
Please reload this pagehttps://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007
March 18, 2021 21:50https://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007#commits-pushed-7d753cc
re interrupting reinterrupting waitNewUrl and sleep after the interru…https://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007/commits/7d753cce690823eddf7a37577b364fff78edd91d
7d753cchttps://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007/commits/7d753cce690823eddf7a37577b364fff78edd91d
adding a nullPointerException that could be thrown by the IPUtils methodhttps://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007/commits/8d3c73ac675d159480cd66799089532c07fb41f0
8d3c73ahttps://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007/commits/8d3c73ac675d159480cd66799089532c07fb41f0
refactoring on constructors and settershttps://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007/commits/13f9840b573b8c7305bf30d8f010fb3bc5817ac4
13f9840https://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007/commits/13f9840b573b8c7305bf30d8f010fb3bc5817ac4
removing some code smells in Page from webmagic corehttps://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007/commits/246526b35238baa8fe7e957cba5cadfeafd6d02d
246526bhttps://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007/commits/246526b35238baa8fe7e957cba5cadfeafd6d02d
correcting and removing some code smell in spider from webmagic corehttps://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007/commits/de34155b532cbfca07a587a7eb413bc15c74aad8
de34155https://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007/commits/de34155b532cbfca07a587a7eb413bc15c74aad8
deleting deprecated method created 8 years agohttps://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007/commits/1946b3f899f92903f7797a56f907c9ffb7f00625
1946b3fhttps://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007/commits/1946b3f899f92903f7797a56f907c9ffb7f00625
adding the deprecated methods to validate the pull requesthttps://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007/commits/42c326bc9ecbff168cb1efa254a64b0c8c6c349e
42c326bhttps://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007/commits/42c326bc9ecbff168cb1efa254a64b0c8c6c349e
refactoring on the select method with remooving continue statement a…https://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007/commits/5ae70799b4e6e716be50146c64251bd77ac5562a
5ae7079https://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007/commits/5ae70799b4e6e716be50146c64251bd77ac5562a
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcode4craft%2Fwebmagic%2Fpull%2F1007
Please reload this pagehttps://patch-diff.githubusercontent.com/code4craft/webmagic/pull/1007
https://patch-diff.githubusercontent.com/BouaoudMalik
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.