Title: A failing test doesn't fail the build · Issue #227 · browserstack/browserstack-runner · GitHub
Open Graph Title: A failing test doesn't fail the build · Issue #227 · browserstack/browserstack-runner
X Title: A failing test doesn't fail the build · Issue #227 · browserstack/browserstack-runner
Description: Expected Behavior If a browser fails to spawn or a test fails in one of the browsers, the process should exit with code different than 0. Actual Behavior The process always exits with code 0. Steps to Reproduce the Problem git clone git@...
Open Graph Description: Expected Behavior If a browser fails to spawn or a test fails in one of the browsers, the process should exit with code different than 0. Actual Behavior The process always exits with code 0. Steps...
X Description: Expected Behavior If a browser fails to spawn or a test fails in one of the browsers, the process should exit with code different than 0. Actual Behavior The process always exits with code 0. Steps...
Opengraph URL: https://github.com/browserstack/browserstack-runner/issues/227
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"A failing test doesn't fail the build","articleBody":"\u003c!--- Provide a general summary of the issue in the Title above --\u003e\r\n\r\n## Expected Behavior\r\n\u003c!--- Tell us what should happen --\u003e\r\n\r\nIf a browser fails to spawn or a test fails in one of the browsers, the process should exit with code different than 0.\r\n\r\n## Actual Behavior\r\n\u003c!--- Tell us what happens instead of the expected behavior --\u003e\r\n\r\nThe process always exits with code 0.\r\n\r\n## Steps to Reproduce the Problem\r\n\r\n 1. `git clone git@github.com:jquery/jquery-color.git`\r\n 2. `npm install`\r\n 3. Now, modify one of the test cases in `test/unit/color.js` so that it fails, e.g. by changing one 255 to 254.\r\n 4. Run `npm run browserstack; echo $?`\r\n\r\nYou should see a failure \u0026 a number different than 0 as the last output. 0 is printed instead.\r\n\r\n## browserstack.json\r\n\u003c!-- Provide your browserstack.json, remember to exclude your browserstack username and access key.--\u003e\r\n\r\n## Platform details\r\n \r\n 1. browserstack-runner version: 0.9.1\r\n 2. node version: v12.16.3\r\n 3. os type and version: macOS 10.15.4 (19E287)\r\n\r\n## Details\r\n\u003c!--- Provide a detailed description of the issue that you are facing. --\u003e\r\n\r\nThis is quite a critical bug to me as it can mask errors by exiting the CI successfully. If one doesn't notice, this may lead to releasing a broken version of a project.","author":{"url":"https://github.com/mgol","@type":"Person","name":"mgol"},"datePublished":"2020-05-08T09:18:31.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/227/browserstack-runner/issues/227"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:bfe1e105-c7ff-aa92-fdf3-d05041741ad7 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D8BC:1D63DE:690356:8F3EB6:696E7B67 |
| html-safe-nonce | b5f0b670e84fe7279fd54abafa2ceee17b76e8a534e876fbab194386aba722a1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOEJDOjFENjNERTo2OTAzNTY6OEYzRUI2OjY5NkU3QjY3IiwidmlzaXRvcl9pZCI6IjY3MDc0MTA4Nzk4NzMxODY2NjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | efc0bb426236e95b9834b81966b8a2a02a97ddde9638ae6038be9556ae1e0ed8 |
| hovercard-subject-tag | issue:614620246 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/browserstack/browserstack-runner/227/issue_layout |
| twitter:image | https://opengraph.githubassets.com/106cda77886ad34e2b1707fdbffa8de9e767944c389e9ae489ef58fb12d0a8d4/browserstack/browserstack-runner/issues/227 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/106cda77886ad34e2b1707fdbffa8de9e767944c389e9ae489ef58fb12d0a8d4/browserstack/browserstack-runner/issues/227 |
| og:image:alt | Expected Behavior If a browser fails to spawn or a test fails in one of the browsers, the process should exit with code different than 0. Actual Behavior The process always exits with code 0. Steps... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mgol |
| hostname | github.com |
| expected-hostname | github.com |
| None | fdad15fd2ad43212aa8b8be5f2c2725550f8374ceeeb154a999ad9145b43f3f7 |
| turbo-cache-control | no-preview |
| go-import | github.com/browserstack/browserstack-runner git https://github.com/browserstack/browserstack-runner.git |
| octolytics-dimension-user_id | 1119453 |
| octolytics-dimension-user_login | browserstack |
| octolytics-dimension-repository_id | 11685362 |
| octolytics-dimension-repository_nwo | browserstack/browserstack-runner |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 11685362 |
| octolytics-dimension-repository_network_root_nwo | browserstack/browserstack-runner |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 27b23bc056eb973d350fc95afc848757edb9e7a9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width