René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"On names and parameter orders of coodinates","articleBody":"Hi,\r\nIt is my first time to use python-pathfinding, it's nice but sth make me confused...\r\nTo be brief, I am writing a bot to play a game, this is what I try to do tonight:\r\n```python\r\n   def ParseMap(map:List[Map]) -\u003e (List[List[Map]], List[List[List[tuple]]], tuple):\r\n    parsedMap = [[Map() for i in range(MapEdgeLength)] for j in range(MapEdgeLength)]\r\n    paths = [[[] for i in range(MapEdgeLength)] for j in range(MapEdgeLength)]\r\n    accessableNow = [[1 for i in range(MapEdgeLength)] for j in range(MapEdgeLength)]\r\n    playerPosition = None\r\n    for grid in map:\r\n        parsedMap[grid.x][grid.y] = grid\r\n        for obj in grid.objs:\r\n            if obj.type == ObjType.Player and obj.property.player_id != gContext[\"playerID\"] and playerPosition is None:\r\n                playerPosition = (grid.x, grid.y)\r\n            if obj.type == ObjType.Block or obj.type == ObjType.Bomb:\r\n                accessableNow[grid.x][grid.y] = 0 # (a)\r\n    # pfGrid: an abbreviation of pathfinding grid\r\n    pfGrid = Grid(matrix=accessableNow)\r\n    for grid in map:\r\n        pfGrid.cleanup()\r\n        finder = AStarFinder(diagonal_movement=DiagonalMovement.never)\r\n        newPath, _ = finder.find_path(pfGrid.node(playerPosition[0], playerPosition[1]),\r\n                                        pfGrid.node(grid.x, grid.y, pfGrid) #(b)\r\n        myNewPath = [(newPath[i].x, newPath[i].y) for i in range(len(newPath))]\r\n        paths[grid.x][grid.y] = myNewPath\r\n    return parsedMap, paths, playerPosition\r\n```\r\nSome names of variables in the code above are provided by the organizer of the contest I am taking part in. \r\nMy code above failed to get correct answer until I rewite `(a)` as:\r\n```python\r\n accessableNow[grid.y][grid.x] = 0\r\n```\r\nor rewrite `(b)` as:\r\n```python\r\n newPath, _ = finder.find_path(pfGrid.node(playerPosition[1], playerPosition[0]),\r\n                                        pfGrid.node(grid.y, grid.x, pfGrid) #(b)\r\n```\r\nLater, I refer to the `docs` but find nothing about parameter order.\r\nAs I look into the grid.py i found:\r\n```python\r\n       def node(self, x, y) -\u003e GridNode:\r\n        \"\"\"\r\n            get node at position\r\n            :param x: x pos\r\n            :param y: y pos\r\n            :return:\r\n        \"\"\"\r\n        return self.nodes[y][x]\r\n```\r\nBelow is what I suggest: Rearrangeing parameters `x` and `y` as the order they appear in the List indexes:\r\n```python\r\n       def node(self, y, x) -\u003e GridNode:\r\n           return self.nodes[y][x]\r\n```\r\nor rename them to the form `xi` where `i` is the order they appear in the indexes:\r\n```python\r\n       def node(self, x1, x2) -\u003e GridNode:\r\n           return self.nodes[x1][x2]\r\n```\r\nso that People who use the `pathfinding` can access a `node` not according to a specific name convention, but the order they pass parameters to these functions before. ","author":{"url":"https://github.com/XinyiLiu577086410","@type":"Person","name":"XinyiLiu577086410"},"datePublished":"2023-11-17T15:47:25.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/50/python-pathfinding/issues/50"}