René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":" avoid using print() function","articleBody":"This is just a copy of connect_serial() method from brping/device.py (ver 0.1.5)\r\n\r\n```py\r\ndef connect_serial(self, device_name: str, baudrate: int =115200):\r\n    if device_name is None:\r\n        print(\"Device name is required\")\r\n        return\r\n\r\n    try:\r\n        print(\"Opening %s at %d bps\" % (device_name, baudrate))\r\n\r\n        ## Serial object for device communication\r\n        # write_timeout fixes it getting stuck forever atempting to write to\r\n        # /dev/ttyAMA0 on Raspberry Pis, this raises an exception instead.\r\n        self.iodev = serial.Serial(device_name, baudrate, write_timeout=1.0)\r\n        self.iodev.send_break()\r\n        time.sleep(0.001)\r\n        self.iodev.write(\"U\".encode(\"ascii\"))\r\n\r\n    except Exception as exception:\r\n        raise Exception(\"Failed to open the given serial port: {0}\".format(exception))\r\n```\r\n\r\nThe request here is:\r\nKindly avoid using the `print` function in a library like this. If the device name is required, it should be handled as an exception, not with a `print` and `return`:\r\n\r\n```py\r\nraise ValueError(\"Device name is required\")\r\n```\r\n\r\nAnd the next `print` is indeed a logging:\r\n\r\n```py\r\nlogger.info(\"Opening %s at %d bps\", device_name, baudrate)\r\n```\r\n\r\nI've had to use workarounds to prevent these `print`s from being sent to my app's stdout:\r\n\r\n```py\r\ndef brping_muted_print(*args, **kw):\r\n    if len(args) == 1:\r\n        args = args[0]\r\n    log('brping: %s', args)\r\n# brping module uses raw print statements for logging\r\n# with this trick, we turn them into proper logs\r\nbrping.device.print = brping_muted_print\r\n```\r\n\r\nThanks","author":{"url":"https://github.com/gowhari","@type":"Person","name":"gowhari"},"datePublished":"2024-08-19T15:06:36.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/141/ping-python/issues/141"}