Title: Int64 unpack fixes by loughmiller · Pull Request #4 · binaryjs/node-binarypack · GitHub
Open Graph Title: Int64 unpack fixes by loughmiller · Pull Request #4 · binaryjs/node-binarypack
X Title: Int64 unpack fixes by loughmiller · Pull Request #4 · binaryjs/node-binarypack
Description: Added unit tests to reproduce the issues, as well as fixes. The unit tests will not pass without a simple fix to BufferCursor that I also submitted. The unit tests for integers could probably be improved, but this is a reasonable start.
Open Graph Description: Added unit tests to reproduce the issues, as well as fixes. The unit tests will not pass without a simple fix to BufferCursor that I also submitted. The unit tests for integers could probably be ...
X Description: Added unit tests to reproduce the issues, as well as fixes. The unit tests will not pass without a simple fix to BufferCursor that I also submitted. The unit tests for integers could probably be ...
Opengraph URL: https://github.com/binaryjs/node-binarypack/pull/4
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:bbad90f5-2974-5b50-bee0-4151bf625baf |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A896:2309BF:50276D:71AC6B:696FA872 |
| html-safe-nonce | 86d02aca1d0b5ec02c30e771623c46f63d1be966bd0c34d038e4be36ee8b9ac9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODk2OjIzMDlCRjo1MDI3NkQ6NzFBQzZCOjY5NkZBODcyIiwidmlzaXRvcl9pZCI6IjM3OTA0Mzg1MzMxODQ4NTgyMjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 0ea1d98f1724ae070c04a755d134536994d50f62fe06d4eb184e6f5240ec991f |
| hovercard-subject-tag | pull_request:8190472 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/binaryjs/node-binarypack/pull/4/files |
| twitter:image | https://avatars.githubusercontent.com/u/5171559?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/5171559?s=400&v=4 |
| og:image:alt | Added unit tests to reproduce the issues, as well as fixes. The unit tests will not pass without a simple fix to BufferCursor that I also submitted. The unit tests for integers could probably be ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0ca8d8c65612640b9a1a588b3eed68222ca723ed2d028b18fe81b28936d535eb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/binaryjs/node-binarypack git https://github.com/binaryjs/node-binarypack.git |
| octolytics-dimension-user_id | 1905132 |
| octolytics-dimension-user_login | binaryjs |
| octolytics-dimension-repository_id | 5010696 |
| octolytics-dimension-repository_nwo | binaryjs/node-binarypack |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 5010696 |
| octolytics-dimension-repository_network_root_nwo | binaryjs/node-binarypack |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 95f60616ce2765d1114fe6da4af405a58c6d26d2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width