René's URL Explorer Experiment


Title: Int64 unpack fixes by loughmiller · Pull Request #4 · binaryjs/node-binarypack · GitHub

Open Graph Title: Int64 unpack fixes by loughmiller · Pull Request #4 · binaryjs/node-binarypack

X Title: Int64 unpack fixes by loughmiller · Pull Request #4 · binaryjs/node-binarypack

Description: Added unit tests to reproduce the issues, as well as fixes. The unit tests will not pass without a simple fix to BufferCursor that I also submitted. The unit tests for integers could probably be ...

Open Graph Description: Added unit tests to reproduce the issues, as well as fixes. The unit tests will not pass without a simple fix to BufferCursor that I also submitted. The unit tests for integers could probably be ...

X Description: Added unit tests to reproduce the issues, as well as fixes. The unit tests will not pass without a simple fix to BufferCursor that I also submitted. The unit tests for integers could probably be ...

Opengraph URL: https://github.com/binaryjs/node-binarypack/pull/4

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4a5b5902-573a-14da-13b9-3a718147b3ca
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB7AC:35CDB1:896AA3:C2A571:696F8C32
html-safe-nonced5f457556d635a5a998705e87bfc5c989151f5d0d303751a61d6d92b73570dc2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCN0FDOjM1Q0RCMTo4OTZBQTM6QzJBNTcxOjY5NkY4QzMyIiwidmlzaXRvcl9pZCI6Ijc2MTUxNDk4NTU2NTA4NDM2OTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac35b084c4cf2dc36ab1afbe90bc27e6fedfce5eb948fa26f8c418a324320b1945
hovercard-subject-tagpull_request:8190472
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/binaryjs/node-binarypack/4/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e8e7f9dcba234f14bbcf9ababfce35f11865add602f1e8fbe4c264ef0dff2430/binaryjs/node-binarypack/pull/4
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e8e7f9dcba234f14bbcf9ababfce35f11865add602f1e8fbe4c264ef0dff2430/binaryjs/node-binarypack/pull/4
og:image:altAdded unit tests to reproduce the issues, as well as fixes. The unit tests will not pass without a simple fix to BufferCursor that I also submitted. The unit tests for integers could probably be ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameloughmiller
hostnamegithub.com
expected-hostnamegithub.com
None0ca8d8c65612640b9a1a588b3eed68222ca723ed2d028b18fe81b28936d535eb
turbo-cache-controlno-preview
go-importgithub.com/binaryjs/node-binarypack git https://github.com/binaryjs/node-binarypack.git
octolytics-dimension-user_id1905132
octolytics-dimension-user_loginbinaryjs
octolytics-dimension-repository_id5010696
octolytics-dimension-repository_nwobinaryjs/node-binarypack
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id5010696
octolytics-dimension-repository_network_root_nwobinaryjs/node-binarypack
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release95f60616ce2765d1114fe6da4af405a58c6d26d2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pull/4#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbinaryjs%2Fnode-binarypack%2Fpull%2F4
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbinaryjs%2Fnode-binarypack%2Fpull%2F4
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=binaryjs%2Fnode-binarypack
Reloadhttps://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pull/4
Reloadhttps://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pull/4
Reloadhttps://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pull/4
binaryjs https://patch-diff.githubusercontent.com/binaryjs
node-binarypackhttps://patch-diff.githubusercontent.com/binaryjs/node-binarypack
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fbinaryjs%2Fnode-binarypack
Fork 16 https://patch-diff.githubusercontent.com/login?return_to=%2Fbinaryjs%2Fnode-binarypack
Star 24 https://patch-diff.githubusercontent.com/login?return_to=%2Fbinaryjs%2Fnode-binarypack
Code https://patch-diff.githubusercontent.com/binaryjs/node-binarypack
Issues 1 https://patch-diff.githubusercontent.com/binaryjs/node-binarypack/issues
Pull requests 1 https://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pulls
Actions https://patch-diff.githubusercontent.com/binaryjs/node-binarypack/actions
Projects 0 https://patch-diff.githubusercontent.com/binaryjs/node-binarypack/projects
Wiki https://patch-diff.githubusercontent.com/binaryjs/node-binarypack/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/binaryjs/node-binarypack/security
Please reload this pagehttps://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pull/4
Insights https://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pulse
Code https://patch-diff.githubusercontent.com/binaryjs/node-binarypack
Issues https://patch-diff.githubusercontent.com/binaryjs/node-binarypack/issues
Pull requests https://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pulls
Actions https://patch-diff.githubusercontent.com/binaryjs/node-binarypack/actions
Projects https://patch-diff.githubusercontent.com/binaryjs/node-binarypack/projects
Wiki https://patch-diff.githubusercontent.com/binaryjs/node-binarypack/wiki
Security https://patch-diff.githubusercontent.com/binaryjs/node-binarypack/security
Insights https://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fbinaryjs%2Fnode-binarypack%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fbinaryjs%2Fnode-binarypack%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pull/4#issue-comment-box
loughmillerhttps://patch-diff.githubusercontent.com/loughmiller
binaryjs:masterhttps://patch-diff.githubusercontent.com/binaryjs/node-binarypack/tree/master
loughmiller:int64-unpack-fixeshttps://patch-diff.githubusercontent.com/loughmiller/node-binarypack/tree/int64-unpack-fixes
Int64 unpack fixes https://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pull/4#top
loughmillerhttps://patch-diff.githubusercontent.com/loughmiller
binaryjs:masterhttps://patch-diff.githubusercontent.com/binaryjs/node-binarypack/tree/master
loughmiller:int64-unpack-fixeshttps://patch-diff.githubusercontent.com/loughmiller/node-binarypack/tree/int64-unpack-fixes
Conversation 0 https://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pull/4
Commits 4 https://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pull/4/commits
Checks 0 https://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pull/4/checks
Files changed https://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pull/4/files
Please reload this pagehttps://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pull/4
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/loughmiller
loughmillerhttps://patch-diff.githubusercontent.com/loughmiller
Sep 9, 2013https://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pull/4#issue-19220431
Please reload this pagehttps://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pull/4
September 9, 2013 13:09https://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pull/4#commits-pushed-13c93b6
add unit tests to reproduce int64 bugshttps://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pull/4/commits/13c93b674d460faad634854e5471f0cb645c6438
13c93b6https://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pull/4/commits/13c93b674d460faad634854e5471f0cb645c6438
readUInt64 - refence buffer array inside object returned from slicehttps://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pull/4/commits/5a369c97a0e589481e89ed6ab910cfeabcacecc2
5a369c9https://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pull/4/commits/5a369c97a0e589481e89ed6ab910cfeabcacecc2
readInt64 should call readUInt64, not itself recursivelyhttps://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pull/4/commits/8ca8fe7271b3361556e0ca48a198b2db07e0d7c1
8ca8fe7https://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pull/4/commits/8ca8fe7271b3361556e0ca48a198b2db07e0d7c1
use patched buffercursorhttps://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pull/4/commits/03ccc029e13fa9942f4ece46e1f72ba50a01ba1e
03ccc02https://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pull/4/commits/03ccc029e13fa9942f4ece46e1f72ba50a01ba1e
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbinaryjs%2Fnode-binarypack%2Fpull%2F4
Please reload this pagehttps://patch-diff.githubusercontent.com/binaryjs/node-binarypack/pull/4
https://patch-diff.githubusercontent.com/loughmiller
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.