René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Chapter 8 - Battleship game.  ","articleBody":"I am trying to hard code the ships and try to hit and sunk them, but the message that Ships were either, hit, or sunk, or were missed is not displaying on the webpage. Instead, it's displaying as Ships were sank all the time on top. I checked the console for Errors, and there were none. I don't know what's wrong in my code.  \r\n\r\nSo far my code looks like this. And the console is not showing any errors.\r\n\r\n```\r\n\r\n\r\nvar view = { \r\ndisplayMessage: function(msg){\r\n\tvar messageArea = document.getElementById(\"messageArea\");\r\n\tmessageArea.innerHTML = msg;\r\n},\r\ndisplayHit: function(location){\r\n\tvar cell = document.getElementById(location);\r\n\tcell.setAttribute(\"class\",\"hit\");\r\n},\r\ndisplayMiss: function(location){\r\n\tvar cell = document.getElementById(location);\r\n\tcell.setAttribute(\"class\",\"miss\");\r\n}\r\n\r\n};\r\n\r\n\r\nview.displayMiss(\"00\");\r\nview.displayHit(\"34\");\r\nview.displayHit(\"12\");\r\nview.displayMiss(\"25\");\r\n\r\nview.displayMessage(\"are you on?\");\r\n\r\nvar model = {\r\n\tboardsize: 7,\r\n\tnumships: 3,\r\n\tshipLength: 3,\r\n\tshipSunk: 0,\r\n ships: [{ locations: [\"06\", \"16\", \"26\"], hits: [\"hit\", \"\", \"\"] },\r\n { locations: [\"24\", \"34\", \"44\"], hits: [\"\", \"\", \"\"] },\r\n { locations: [\"10\", \"11\", \"12\"], hits: [\"\", \"\", \"\"] }],\r\nfire: function(guess) {\r\n\tfor(var i = 0; i \u003c this.numships; i++){\r\n\t\tvar ship = this.ships[i];\r\n\t\tvar index = ship.locations.indexOf(guess);\r\n\t\tif(index \u003e=0){\r\n\t\t\tship.hits[index] = \"hit\";\r\n\t\t\tview.displayHit(guess);\r\n\t\t\tview.displayMessage(\"HIT!\");\r\n\t\t\tif (this.isSunk(ship)){\r\n\t\t\t\tview.displayMessage(\"You sank my warship\");\r\n\t\t\t\tthis.shipSunk++;\r\n\t\t\t}\r\n\t\t\treturn true;\r\n\t\t}\r\n\t}\r\n\tview.displayMiss(guess);\r\n\tview.displayMessage(\"You Missed.\");\r\n\treturn false;\r\n\t\r\n\t},\r\n\tisSunk: function(ship) {\r\n\t\tfor (var i = 0; i \u003c this.shipLength; i++){\r\n\t\t\tif (ship.hits[i] !== \"hit\"){\r\n\t\t\t\treturn false;\r\n\t\t\t}\r\n\t\t}\r\n\t\treturn true;\r\n\r\n\t}\r\n};\r\n/*\r\nmodel.fire(\"53\");\r\nmodel.fire(\"06\");\r\nmodel.fire(\"16\");\r\nmodel.fire(\"26\");\r\nmodel.fire(\"34\");\r\nmodel.fire(\"24\");\r\nmodel.fire(\"44\");\r\nmodel.fire(\"12\");\r\nmodel.fire(\"11\");\r\nmodel.fire(\"10\");\r\n*/\r\nfunction parseGuess(guess){\r\n\tvar alphabet = [\"A\",\"B\",\"C\",\"D\",\"E\",\"F\",\"G\"];\r\n\tif(guess === null || guess.length !== 2){\r\n\t\talert(\"Enter a valid number and letter\");\r\n\t\t} else{\r\n\t\t\tvar row = alphabet.indexOf(guess.charAt(0));\r\n\t\t\tvar column = guess.charAt(1);\r\n\t\t\t\r\n\t\t\tif (isNaN(row) || isNaN(column)){\r\n\t\t\talert(\"invalid number\");\r\n\t\t\t}\r\n\t\t\telse if (row \u003c 0 || row \u003e= model.boardsize || column \u003c 0 || column \u003e= model.boardsize){\r\n\t\t\t\talert(\"off the board\");\r\n\t\t} else {\r\n\t\t\treturn row + column;\r\n\t\t}\r\n\r\n\t\t}\r\n\t\treturn null;\r\n\t\t}\r\n\t\r\nvar controller = {\r\n\tguesses: 0,\r\n\tprocessGuess: function(guess){\r\n\t\tvar location = parseGuess(guess);\r\n\t\tif(location){\r\n\t\t\tthis.guesses++;\r\n\t\t\tvar hit = model.fire(location);\r\n\t\t\tif(hit \u0026\u0026 model.shipSunk === model.numships) {\r\n\t\t\t\tview.displayMessage(\"You sank the warship, in\" + this.guesses + \"guesses\");\r\n\t\t\t}\r\n\t\t}\r\n\t}\r\n}\r\ncontroller.processGuess(\"A0\");\r\ncontroller.processGuess(\"A6\");\r\ncontroller.processGuess(\"B6\");\r\ncontroller.processGuess(\"C6\");\r\ncontroller.processGuess(\"C4\");\r\ncontroller.processGuess(\"D5\");\r\ncontroller.processGuess(\"E4\");\r\ncontroller.processGuess(\"B0\");\r\ncontroller.processGuess(\"B1\");\r\ncontroller.processGuess(\"B2\");\r\n\r\nfunction init(){\r\n\tvar fireButton = document.getElementById(\"fireButton\");\r\n\tfireButton.onclick = handleFireButton;\r\n\tguessInput.onkeypress = handleKeyPress;\r\n}\r\n\t\r\n\tfunction handleKeyPress(e){\r\n\t\tvar fireButton = document.getElementById(\"fireButton\");\r\n\t\tif(e.keycode === 13){\r\n\t\t\tfireButton.click();\r\n\t\t\treturn false;\r\n\t\t}\r\n\t}\r\n\tfunction handleFireButton(){\r\n\t\tvar guessInput = document.getElementById(\"guessInput\");\r\n\t\tvar guess = guessInput.value;\r\n\t\tcontroller.processGuess(guess);\r\n\t\tguessInput.value = \"\";\r\n\t}\r\n\twindow.onload = init;\r\n\r\n```\r\n\r\n \r\n \r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n \r\n```","author":{"url":"https://github.com/KU740","@type":"Person","name":"KU740"},"datePublished":"2020-10-09T13:32:12.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/26/Head-First-JavaScript-Programming/issues/26"}