René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Chapter 8 - Battleship ","articleBody":"Hi, I'm on chapter 8 where you build a battleship game. I have finished the Viewer and Model part without the Controller part. My problem:\r\nI type in the console model.fire(\"somecell\") to make 3 hits and drown a ship, but I keep getting that the ship is sunk on every hit. It never says \"Hit!\"\r\n\r\nMy code:\r\n`var view = {\r\n  displayMessage: function(msg){\r\n    var messageArea = document.getElementById('messageArea');\r\n    messageArea.innerHTML = msg;\r\n  },\r\n  displayHit: function(location){\r\n    var cell = document.getElementById(location);\r\n    cell.setAttribute(\"class\", \"hit\");\r\n  },\r\n  displayMiss: function(location) {\r\n    var cell = document.getElementById(location);\r\n    cell.setAttribute(\"class\", \"miss\");\r\n  }\r\n};\r\n\r\nvar model = {\r\n  boardSize : 7,\r\n  numShips: 3,\r\n  shipLength: 3,\r\n  shipsSunk: 0,\r\n\r\n  ships:[\r\n    {locations: [\"10\", \"20\", \"30\"], hits: [\"\", \"\", \"\"]},\r\n  {locations: [\"32\",\"33\",\"34\"], hits:[\"\", \"\", \"\"]},\r\n  {locations: [\"63\",\"64\",\"65\"], hits:[\"\", \"\", \"\"]}\r\n],\r\n\r\n  fire: function(guess){\r\n    for(var i = 0; i \u003c this.numShips; i++) {\r\n      var ship = this.ships[i];\r\n      var index = ship.locations.indexOf(guess);\r\n\r\n      if (index \u003e=0) {\r\n        //trafiony\r\n        ship.hits[index] = \"hit\";\r\n        view.displayHit(guess);\r\n        view.displayMessage(\"Hit!\");\r\n\r\n        if (this.isSunk(ship)){\r\n          view.displayMessage(\"Sunk!\");\r\n          this.shipsSunk++;\r\n        }\r\n        return true;\r\n      }\r\n    }\r\n    view.displayMiss(guess);\r\n    view.displayMessage(\"Miss!\")\r\n    return false;\r\n  },\r\n  isSunk: function(ship) {\r\n    for (var i=0; i \u003c this.shipLength; i++){\r\n      if (ship.hits[i] !== \"hit\") {\r\n        return false;\r\n      }\r\n      return true;\r\n    }\r\n  }\r\n};\r\n`\r\n\r\nI compared the code and it's the same as in the book and don't understand why it won't work. Can you help me? \r\nBtw. this book is awesome. I bought a polish version :)","author":{"url":"https://github.com/akyjoon","@type":"Person","name":"akyjoon"},"datePublished":"2017-08-07T23:11:55.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":17},"url":"https://github.com/23/Head-First-JavaScript-Programming/issues/23"}