| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:51c16a15-bdd1-d887-de45-6d0fa66236aa |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BF36:D4C17:2ABA91D:38FE421:69807278 |
| html-safe-nonce | 92db43cee22b237d2c062b5f5e2867b19da32ab84419819e0c93b3979dbf4cc7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjM2OkQ0QzE3OjJBQkE5MUQ6MzhGRTQyMTo2OTgwNzI3OCIsInZpc2l0b3JfaWQiOiI0NzkxNzE4Mzc0Nzk3MjQzMDAwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 22e07d25f94b21c8321e035a107852167de59b884f7c2c9db876a6206cea3afd |
| hovercard-subject-tag | pull_request:2182772424 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/benchling/openapi-python-client/219/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f0727c77e71ee3e042eb6b99b9d8d189c4c84f4a4eb0749119fcf4be6effd7d5/benchling/openapi-python-client/pull/219 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f0727c77e71ee3e042eb6b99b9d8d189c4c84f4a4eb0749119fcf4be6effd7d5/benchling/openapi-python-client/pull/219 |
| og:image:alt | This is equivalent to my upstream PR openapi-generators#1121. I described the symptoms in detail in openapi-generators#1120, but basically this was a problem that happened with certain patterns of ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | eli-bl |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0959b1a93ca48b0c88b3bddbdfd04ca43f388cb1a8293105a28c5ef6e8079db8 |
| turbo-cache-control | no-preview |
| go-import | github.com/benchling/openapi-python-client git https://github.com/benchling/openapi-python-client.git |
| octolytics-dimension-user_id | 2392113 |
| octolytics-dimension-user_login | benchling |
| octolytics-dimension-repository_id | 292424898 |
| octolytics-dimension-repository_nwo | benchling/openapi-python-client |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | true |
| octolytics-dimension-repository_parent_id | 240776275 |
| octolytics-dimension-repository_parent_nwo | openapi-generators/openapi-python-client |
| octolytics-dimension-repository_network_root_id | 240776275 |
| octolytics-dimension-repository_network_root_nwo | openapi-generators/openapi-python-client |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 78307334c66591a8f87f493dd2968126b34961dd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbenchling%2Fopenapi-python-client%2Fpull%2F219 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbenchling%2Fopenapi-python-client%2Fpull%2F219 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=benchling%2Fopenapi-python-client |
| Reload | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219 |
| Reload | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219 |
| Reload | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219 |
|
benchling
| https://patch-diff.githubusercontent.com/benchling |
| openapi-python-client | https://patch-diff.githubusercontent.com/benchling/openapi-python-client |
| openapi-generators/openapi-python-client | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Fbenchling%2Fopenapi-python-client |
|
Fork
1
| https://patch-diff.githubusercontent.com/login?return_to=%2Fbenchling%2Fopenapi-python-client |
|
Star
0
| https://patch-diff.githubusercontent.com/login?return_to=%2Fbenchling%2Fopenapi-python-client |
|
Code
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client |
|
Pull requests
7
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/actions |
|
Projects
0
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/projects |
|
Security
0
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/security |
|
Insights
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pulse |
|
Code
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client |
|
Pull requests
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/actions |
|
Projects
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/projects |
|
Security
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/security |
|
Insights
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pulse |
| Sign up for GitHub
| https://patch-diff.githubusercontent.com/signup?return_to=%2Fbenchling%2Fopenapi-python-client%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=%2Fbenchling%2Fopenapi-python-client%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#issue-comment-box |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| prod/2.x | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/tree/prod/2.x |
| eli.bishop/BNCH-111776-nullables | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/tree/eli.bishop/BNCH-111776-nullables |
|
eng: fix bug in type generation for nullable/union props BNCH-111776
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#top |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| prod/2.x | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/tree/prod/2.x |
| eli.bishop/BNCH-111776-nullables | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/tree/eli.bishop/BNCH-111776-nullables |
|
Conversation
11
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219 |
|
Commits
6
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/commits |
|
Checks
0
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/checks |
|
Files changed
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/files |
| Please reload this page | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| Nov 15, 2024 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#issue-2663438524 |
| Please reload this page | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219 |
| openapi-generators#1121 | https://github.com/openapi-generators/openapi-python-client/pull/1121 |
| openapi-generators#1120 | https://github.com/openapi-generators/openapi-python-client/issues/1120 |
| Please reload this page | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219 |
|
| https://patch-diff.githubusercontent.com/eli-bl |
| fix bug in type generation for nullable props BNCH-111776 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/commits/9056e92c01e00805e7fe1c68fbac08905625ca6f |
| 9056e92 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/commits/9056e92c01e00805e7fe1c68fbac08905625ca6f |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
|
Nov 15, 2024
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#pullrequestreview-2439921654 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/files |
| end_to_end_tests/functional_tests/generated_code_execution/test_enums_and_consts.py | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/files#diff-695fdfbb911f06ccf8dfcf404bce9c13b3546c9347c3298b39a99299576c74bc |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| Nov 15, 2024 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#discussion_r1844658377 |
| Please reload this page | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| force-pushed | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/compare/40702a84702550576a1b7a14db626cbc9c9c6b4b..8059d242967c9ca2d2fb939c4ed30c9ef0ad559a |
| 40702a8 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/commit/40702a84702550576a1b7a14db626cbc9c9c6b4b |
| 8059d24 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/commit/8059d242967c9ca2d2fb939c4ed30c9ef0ad559a |
|
Compare
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/compare/40702a84702550576a1b7a14db626cbc9c9c6b4b..8059d242967c9ca2d2fb939c4ed30c9ef0ad559a |
| November 15, 2024 23:24 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#event-15319083216 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
|
Nov 15, 2024
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#pullrequestreview-2439923059 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/files |
| end_to_end_tests/functional_tests/generated_code_execution/test_enums_and_consts.py | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/files#diff-695fdfbb911f06ccf8dfcf404bce9c13b3546c9347c3298b39a99299576c74bc |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| Nov 15, 2024 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#discussion_r1844659475 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
|
Nov 15, 2024
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#pullrequestreview-2439924260 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/files |
| end_to_end_tests/generated_client.py | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/files#diff-ca58d24de3504aa80fdcc73ec29030f7733664510940d97c99d3181eb628fd3b |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| Nov 15, 2024 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#discussion_r1844660394 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
|
Nov 15, 2024
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#pullrequestreview-2439925167 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/files |
| end_to_end_tests/golden-record/my_test_api_client/models/__init__.py | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/files#diff-b559da36cbc384fc7e69fbd9357aeaeec4263efa53e42c4f07d003f913cc4b3e |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| Nov 15, 2024 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#discussion_r1844661024 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
|
Nov 15, 2024
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#pullrequestreview-2439930370 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/files |
| openapi_python_client/parser/properties/union.py | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/files#diff-cd8d1b6355e7d64432afb9f7431c2898f051978253484bb7e9af78db96b8c470 |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| Nov 15, 2024 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#discussion_r1844664938 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219 |
|
| https://patch-diff.githubusercontent.com/eli-bl |
| functional tests for union type fix | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/commits/b92fed6f52e64f321d79c64445b98cd23af2c0e7 |
| b92fed6 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/commits/b92fed6f52e64f321d79c64445b98cd23af2c0e7 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| force-pushed | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/compare/8059d242967c9ca2d2fb939c4ed30c9ef0ad559a..b92fed6f52e64f321d79c64445b98cd23af2c0e7 |
| 8059d24 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/commit/8059d242967c9ca2d2fb939c4ed30c9ef0ad559a |
| b92fed6 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/commit/b92fed6f52e64f321d79c64445b98cd23af2c0e7 |
|
Compare
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/compare/8059d242967c9ca2d2fb939c4ed30c9ef0ad559a..b92fed6f52e64f321d79c64445b98cd23af2c0e7 |
| November 15, 2024 23:41 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#event-15319153614 |
|
| https://patch-diff.githubusercontent.com/eli-bl |
| misc fixes | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/commits/f4d3735271f7ba874c920c932b6b9d4928dc06c2 |
| f4d3735 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/commits/f4d3735271f7ba874c920c932b6b9d4928dc06c2 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| force-pushed | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/compare/c4dda2c140d525c93084fbd46515a58a2e732943..f4d3735271f7ba874c920c932b6b9d4928dc06c2 |
| c4dda2c | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/commit/c4dda2c140d525c93084fbd46515a58a2e732943 |
| f4d3735 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/commit/f4d3735271f7ba874c920c932b6b9d4928dc06c2 |
|
Compare
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/compare/c4dda2c140d525c93084fbd46515a58a2e732943..f4d3735271f7ba874c920c932b6b9d4928dc06c2 |
| November 18, 2024 19:47 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#event-15339364947 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| November 18, 2024 19:54 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#event-15339475215 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| damola-benchling | https://patch-diff.githubusercontent.com/damola-benchling |
| December 3, 2024 18:51 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#event-15514713194 |
| https://patch-diff.githubusercontent.com/damola-benchling |
| damola-benchling | https://patch-diff.githubusercontent.com/damola-benchling |
|
Dec 6, 2024
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#pullrequestreview-2485549709 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/files/f4d3735271f7ba874c920c932b6b9d4928dc06c2 |
| damola-benchling | https://patch-diff.githubusercontent.com/damola-benchling |
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#pullrequestreview-2485549709 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219 |
| openapi_python_client/parser/properties/union.py | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/files/f4d3735271f7ba874c920c932b6b9d4928dc06c2#diff-cd8d1b6355e7d64432afb9f7431c2898f051978253484bb7e9af78db96b8c470 |
| damola-benchling | https://patch-diff.githubusercontent.com/damola-benchling |
| Dec 6, 2024 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#discussion_r1873790583 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219 |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| Dec 6, 2024 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#discussion_r1873846188 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219 |
| damola-benchling | https://patch-diff.githubusercontent.com/damola-benchling |
| Dec 6, 2024 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#discussion_r1874112258 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219 |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| December 6, 2024 10:30 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#commits-pushed-1d76bca |
|
| https://patch-diff.githubusercontent.com/eli-bl |
| Merge branch 'prod/2.x' into eli.bishop/BNCH-111776-nullables | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/commits/1d76bca5e91f115564f70a718813dfe97337b5f7 |
| 1d76bca | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/commits/1d76bca5e91f115564f70a718813dfe97337b5f7 |
|
| https://patch-diff.githubusercontent.com/eli-bl |
| clarify nullable special-case logic | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/commits/668ea043a7c145baaa6229f1134bfc44bde8dc13 |
| 668ea04 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/commits/668ea043a7c145baaa6229f1134bfc44bde8dc13 |
|
| https://patch-diff.githubusercontent.com/eli-bl |
| further clarification | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/commits/a5ed889b975bde48326f9ec90ad9912f0ad7ee5f |
| a5ed889 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/commits/a5ed889b975bde48326f9ec90ad9912f0ad7ee5f |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| damola-benchling | https://patch-diff.githubusercontent.com/damola-benchling |
| December 6, 2024 20:11 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#event-15565229418 |
| https://patch-diff.githubusercontent.com/damola-benchling |
| damola-benchling | https://patch-diff.githubusercontent.com/damola-benchling |
|
Dec 6, 2024
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#pullrequestreview-2486120753 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/files/a5ed889b975bde48326f9ec90ad9912f0ad7ee5f |
| pyproject.toml | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/files/a5ed889b975bde48326f9ec90ad9912f0ad7ee5f#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711 |
| Please reload this page | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| December 6, 2024 23:40 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#event-15567100491 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| 853eb9c | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/commit/853eb9cfc36d29bab5790f568c5221a53c65d46d |
| Dec 6, 2024 | https://github.com/benchling/openapi-python-client/pull/219#event-15567127717 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| December 6, 2024 23:44 | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219#event-15567128290 |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbenchling%2Fopenapi-python-client%2Fpull%2F219 |
|
| https://patch-diff.githubusercontent.com/damola-benchling |
|
damola-benchling
| https://patch-diff.githubusercontent.com/damola-benchling |
|
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219/files/a5ed889b975bde48326f9ec90ad9912f0ad7ee5f |
| Please reload this page | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/219 |
|
| https://patch-diff.githubusercontent.com/eli-bl |
|
| https://patch-diff.githubusercontent.com/damola-benchling |
|
| https://patch-diff.githubusercontent.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |