René's URL Explorer Experiment


Title: add discriminator property support by eli-bl · Pull Request #214 · benchling/openapi-python-client · GitHub

Open Graph Title: add discriminator property support by eli-bl · Pull Request #214 · benchling/openapi-python-client

X Title: add discriminator property support by eli-bl · Pull Request #214 · benchling/openapi-python-client

Description: See description in my PR against the upstream repo: openapi-generators#1154 Why we need this fix: Both the v3 and v2 API specs make heavy use of discriminators for polymorphic types. Without discri...

Open Graph Description: See description in my PR against the upstream repo: openapi-generators#1154 Why we need this fix: Both the v3 and v2 API specs make heavy use of discriminators for polymorphic types. Without discri...

X Description: See description in my PR against the upstream repo: openapi-generators#1154 Why we need this fix: Both the v3 and v2 API specs make heavy use of discriminators for polymorphic types. Without discri...

Opengraph URL: https://github.com/benchling/openapi-python-client/pull/214

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d9e73b59-9cc9-e00b-5c8e-edb748d84007
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA52A:293143:10BDF89:1702851:6980B70F
html-safe-nonceefa9fc90d80c2d9bbf8a95a392177cbd69c7cdfa249809f4112d908e249450b3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTJBOjI5MzE0MzoxMEJERjg5OjE3MDI4NTE6Njk4MEI3MEYiLCJ2aXNpdG9yX2lkIjoiNTY2OTU3Nzc3ODQ5MjY1MTI3OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1b9d21471c27b63badf644e52da39c3e73af8b667c5d5c03089348b1a2d065b5
hovercard-subject-tagpull_request:2150017259
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/benchling/openapi-python-client/214/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/88a6d809700612f560256dc145c7b8d5c783038513851dc44faf9ed2ca901aba/benchling/openapi-python-client/pull/214
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/88a6d809700612f560256dc145c7b8d5c783038513851dc44faf9ed2ca901aba/benchling/openapi-python-client/pull/214
og:image:altSee description in my PR against the upstream repo: openapi-generators#1154 Why we need this fix: Both the v3 and v2 API specs make heavy use of discriminators for polymorphic types. Without discri...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameeli-bl
hostnamegithub.com
expected-hostnamegithub.com
Nonefb936832e40deb3175641d9cfedc8432372f91b0bc899576222953095fc7879e
turbo-cache-controlno-preview
go-importgithub.com/benchling/openapi-python-client git https://github.com/benchling/openapi-python-client.git
octolytics-dimension-user_id2392113
octolytics-dimension-user_loginbenchling
octolytics-dimension-repository_id292424898
octolytics-dimension-repository_nwobenchling/openapi-python-client
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id240776275
octolytics-dimension-repository_parent_nwoopenapi-generators/openapi-python-client
octolytics-dimension-repository_network_root_id240776275
octolytics-dimension-repository_network_root_nwoopenapi-generators/openapi-python-client
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasead74180531de4861d5eee036a47b86c66a5b756e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbenchling%2Fopenapi-python-client%2Fpull%2F214
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbenchling%2Fopenapi-python-client%2Fpull%2F214
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=benchling%2Fopenapi-python-client
Reloadhttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214
Reloadhttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214
Reloadhttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214
benchling https://patch-diff.githubusercontent.com/benchling
openapi-python-clienthttps://patch-diff.githubusercontent.com/benchling/openapi-python-client
openapi-generators/openapi-python-clienthttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fbenchling%2Fopenapi-python-client
Fork 1 https://patch-diff.githubusercontent.com/login?return_to=%2Fbenchling%2Fopenapi-python-client
Star 0 https://patch-diff.githubusercontent.com/login?return_to=%2Fbenchling%2Fopenapi-python-client
Code https://patch-diff.githubusercontent.com/benchling/openapi-python-client
Pull requests 7 https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pulls
Actions https://patch-diff.githubusercontent.com/benchling/openapi-python-client/actions
Projects 0 https://patch-diff.githubusercontent.com/benchling/openapi-python-client/projects
Security 0 https://patch-diff.githubusercontent.com/benchling/openapi-python-client/security
Insights https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pulse
Code https://patch-diff.githubusercontent.com/benchling/openapi-python-client
Pull requests https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pulls
Actions https://patch-diff.githubusercontent.com/benchling/openapi-python-client/actions
Projects https://patch-diff.githubusercontent.com/benchling/openapi-python-client/projects
Security https://patch-diff.githubusercontent.com/benchling/openapi-python-client/security
Insights https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fbenchling%2Fopenapi-python-client%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fbenchling%2Fopenapi-python-client%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#issue-comment-box
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
2.xhttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/tree/2.x
discriminatorshttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/tree/discriminators
add discriminator property support https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#top
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
2.xhttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/tree/2.x
discriminatorshttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/tree/discriminators
Conversation 17 https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214
Commits 6 https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/commits
Checks 0 https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/checks
Files changed https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files
Please reload this pagehttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Oct 28, 2024https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#issue-2619395782
Please reload this pagehttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214
openapi-generators#1154https://github.com/openapi-generators/openapi-python-client/pull/1154
Please reload this pagehttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
October 28, 2024 20:47https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#event-14969329863
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
damola-benchlinghttps://patch-diff.githubusercontent.com/damola-benchling
October 28, 2024 20:47https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#event-14969331103
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Oct 28, 2024 https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#pullrequestreview-2400198315
View reviewed changes https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files
end_to_end_tests/baseline_openapi_3.0.jsonhttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files#diff-77684f26aa921fc62d68726ed5ff58c4f476b3d33708bbc21b960aefeec84157
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Oct 28, 2024https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#discussion_r1819742055
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Oct 28, 2024 https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#pullrequestreview-2400199956
View reviewed changes https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files
end_to_end_tests/golden-record/my_test_api_client/models/a_discriminated_union_type_1.pyhttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files#diff-229dacb82696cef16fdb9cddc19efed45ee4fb5a212a6157b6d83c45ef1bd804
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Oct 28, 2024https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#discussion_r1819743163
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Oct 28, 2024 https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#pullrequestreview-2400209557
View reviewed changes https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files
end_to_end_tests/golden-record/my_test_api_client/models/model_with_discriminated_union.pyhttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files#diff-73d4a95cc340cc6f6c519e0c447f53fbabc191b376c582770147c9dd99c4d9c6
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Oct 28, 2024https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#discussion_r1819749588
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Oct 28, 2024 https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#pullrequestreview-2400210156
View reviewed changes https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files
end_to_end_tests/golden-record/my_test_api_client/models/model_with_discriminated_union.pyhttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files#diff-73d4a95cc340cc6f6c519e0c447f53fbabc191b376c582770147c9dd99c4d9c6
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Oct 28, 2024https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#discussion_r1819750108
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
force-pushedhttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/compare/caa81a742f854642d1d8911ee97406fde477ecf8..2136c1431ac1fa70ae53f30c56803b942272750a
caa81a7https://patch-diff.githubusercontent.com/benchling/openapi-python-client/commit/caa81a742f854642d1d8911ee97406fde477ecf8
2136c14https://patch-diff.githubusercontent.com/benchling/openapi-python-client/commit/2136c1431ac1fa70ae53f30c56803b942272750a
Compare https://patch-diff.githubusercontent.com/benchling/openapi-python-client/compare/caa81a742f854642d1d8911ee97406fde477ecf8..2136c1431ac1fa70ae53f30c56803b942272750a
October 28, 2024 20:56https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#event-14969425018
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Oct 28, 2024 https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#pullrequestreview-2400214495
View reviewed changes https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files
openapi_python_client/parser/properties/union.pyhttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files#diff-cd8d1b6355e7d64432afb9f7431c2898f051978253484bb7e9af78db96b8c470
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Oct 28, 2024https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#discussion_r1819752877
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Oct 28, 2024 https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#pullrequestreview-2400230513
View reviewed changes https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files
openapi_python_client/parser/properties/union.pyhttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files#diff-cd8d1b6355e7d64432afb9f7431c2898f051978253484bb7e9af78db96b8c470
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Oct 28, 2024https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#discussion_r1819762745
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Oct 28, 2024 https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#pullrequestreview-2400234793
View reviewed changes https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files
openapi_python_client/parser/properties/union.pyhttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files#diff-cd8d1b6355e7d64432afb9f7431c2898f051978253484bb7e9af78db96b8c470
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Oct 28, 2024https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#discussion_r1819765465
Please reload this pagehttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Oct 28, 2024 https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#pullrequestreview-2400238321
View reviewed changes https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files
openapi_python_client/parser/properties/union.pyhttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files#diff-cd8d1b6355e7d64432afb9f7431c2898f051978253484bb7e9af78db96b8c470
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Oct 28, 2024https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#discussion_r1819767592
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Oct 28, 2024 https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#pullrequestreview-2400264988
View reviewed changes https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files
openapi_python_client/parser/properties/union.pyhttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files#diff-cd8d1b6355e7d64432afb9f7431c2898f051978253484bb7e9af78db96b8c470
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Oct 28, 2024https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#discussion_r1819783586
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Oct 28, 2024 https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#pullrequestreview-2400271729
View reviewed changes https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files
openapi_python_client/templates/property_templates/union_property.py.jinjahttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files#diff-23d4c94f056bacffca42533cd744b9df1851d32b1947472bc1683f52cf977da6
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Oct 28, 2024https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#discussion_r1819787722
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Oct 28, 2024 https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#pullrequestreview-2400275403
View reviewed changes https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files
openapi_python_client/templates/property_templates/union_property.py.jinjahttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files#diff-23d4c94f056bacffca42533cd744b9df1851d32b1947472bc1683f52cf977da6
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Oct 28, 2024https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#discussion_r1819790117
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Oct 28, 2024 https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#pullrequestreview-2400277975
View reviewed changes https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files
openapi_python_client/templates/property_templates/union_property.py.jinjahttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files#diff-23d4c94f056bacffca42533cd744b9df1851d32b1947472bc1683f52cf977da6
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Oct 28, 2024https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#discussion_r1819791942
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
force-pushedhttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/compare/2136c1431ac1fa70ae53f30c56803b942272750a..1956f6834d37ae4e63d05b685179449a6634e629
2136c14https://patch-diff.githubusercontent.com/benchling/openapi-python-client/commit/2136c1431ac1fa70ae53f30c56803b942272750a
1956f68https://patch-diff.githubusercontent.com/benchling/openapi-python-client/commit/1956f6834d37ae4e63d05b685179449a6634e629
Compare https://patch-diff.githubusercontent.com/benchling/openapi-python-client/compare/2136c1431ac1fa70ae53f30c56803b942272750a..1956f6834d37ae4e63d05b685179449a6634e629
October 28, 2024 21:30https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#event-14969827438
https://patch-diff.githubusercontent.com/eli-bl
add discriminator property supporthttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/commits/0496ff886af2a73718b2ceb250e49078905fc666
0496ff8https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/commits/0496ff886af2a73718b2ceb250e49078905fc666
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
force-pushedhttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/compare/1956f6834d37ae4e63d05b685179449a6634e629..0496ff886af2a73718b2ceb250e49078905fc666
1956f68https://patch-diff.githubusercontent.com/benchling/openapi-python-client/commit/1956f6834d37ae4e63d05b685179449a6634e629
0496ff8https://patch-diff.githubusercontent.com/benchling/openapi-python-client/commit/0496ff886af2a73718b2ceb250e49078905fc666
Compare https://patch-diff.githubusercontent.com/benchling/openapi-python-client/compare/1956f6834d37ae4e63d05b685179449a6634e629..0496ff886af2a73718b2ceb250e49078905fc666
October 28, 2024 21:33https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#event-14969852336
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
October 30, 2024 15:25https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#commits-pushed-b75adda
https://patch-diff.githubusercontent.com/eli-bl
simply the discriminator logic a bithttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/commits/b75adda0bcf64009120f8b6eedeaf55bf95a5fde
b75addahttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/commits/b75adda0bcf64009120f8b6eedeaf55bf95a5fde
https://patch-diff.githubusercontent.com/eli-bl
remove new category of tests for nowhttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/commits/29414518643acfaa72d97e21a17b64224cb0ef24
2941451https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/commits/29414518643acfaa72d97e21a17b64224cb0ef24
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
force-pushedhttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/compare/9e719360af461fc0582a048dd279d74b16bb8bbf..29414518643acfaa72d97e21a17b64224cb0ef24
9e71936https://patch-diff.githubusercontent.com/benchling/openapi-python-client/commit/9e719360af461fc0582a048dd279d74b16bb8bbf
2941451https://patch-diff.githubusercontent.com/benchling/openapi-python-client/commit/29414518643acfaa72d97e21a17b64224cb0ef24
Compare https://patch-diff.githubusercontent.com/benchling/openapi-python-client/compare/9e719360af461fc0582a048dd279d74b16bb8bbf..29414518643acfaa72d97e21a17b64224cb0ef24
October 31, 2024 17:18https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#event-15042283536
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
November 5, 2024 13:29https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#commits-pushed-d189f77
https://patch-diff.githubusercontent.com/eli-bl
linthttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/commits/d189f771180f189555e7109aee24da871d548724
d189f77https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/commits/d189f771180f189555e7109aee24da871d548724
https://patch-diff.githubusercontent.com/eli-bl
linthttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/commits/de1ddf33667318aad595227492109fed6436bb70
de1ddf3https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/commits/de1ddf33667318aad595227492109fed6436bb70
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
force-pushedhttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/compare/344ec970cd4eaf177784522be1a1daabdac9342b..de1ddf33667318aad595227492109fed6436bb70
344ec97https://patch-diff.githubusercontent.com/benchling/openapi-python-client/commit/344ec970cd4eaf177784522be1a1daabdac9342b
de1ddf3https://patch-diff.githubusercontent.com/benchling/openapi-python-client/commit/de1ddf33667318aad595227492109fed6436bb70
Compare https://patch-diff.githubusercontent.com/benchling/openapi-python-client/compare/344ec970cd4eaf177784522be1a1daabdac9342b..de1ddf33667318aad595227492109fed6436bb70
November 5, 2024 23:38https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#event-15131174308
https://patch-diff.githubusercontent.com/eli-bl
handle a case where there's multiple values mapped to same typehttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/commits/9071de05a4158ff397f74ac829ba3eb9f11daf62
9071de0https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/commits/9071de05a4158ff397f74ac829ba3eb9f11daf62
https://patch-diff.githubusercontent.com/damola-benchling
damola-benchlinghttps://patch-diff.githubusercontent.com/damola-benchling
Nov 6, 2024 https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#pullrequestreview-2419495266
View reviewed changes https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files/9071de05a4158ff397f74ac829ba3eb9f11daf62
damola-benchlinghttps://patch-diff.githubusercontent.com/damola-benchling
https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#pullrequestreview-2419495266
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214
openapi_python_client/parser/properties/union.pyhttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files/9071de05a4158ff397f74ac829ba3eb9f11daf62#diff-cd8d1b6355e7d64432afb9f7431c2898f051978253484bb7e9af78db96b8c470
damola-benchlinghttps://patch-diff.githubusercontent.com/damola-benchling
Nov 6, 2024https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#discussion_r1831754950
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Nov 6, 2024https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#discussion_r1831784559
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214
openapi_python_client/parser/properties/union.pyhttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files/9071de05a4158ff397f74ac829ba3eb9f11daf62#diff-cd8d1b6355e7d64432afb9f7431c2898f051978253484bb7e9af78db96b8c470
damola-benchlinghttps://patch-diff.githubusercontent.com/damola-benchling
Nov 6, 2024https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#discussion_r1831782816
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Nov 6, 2024https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214#discussion_r1831785192
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
d76c0fchttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/commit/d76c0fc0b4540f7c341cae46fc44f09f2859b9bb
Nov 6, 2024https://github.com/benchling/openapi-python-client/pull/214#event-15160899369
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbenchling%2Fopenapi-python-client%2Fpull%2F214
https://patch-diff.githubusercontent.com/damola-benchling
damola-benchling https://patch-diff.githubusercontent.com/damola-benchling
https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214/files/9071de05a4158ff397f74ac829ba3eb9f11daf62
Please reload this pagehttps://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214
https://patch-diff.githubusercontent.com/eli-bl
https://patch-diff.githubusercontent.com/damola-benchling
https://patch-diff.githubusercontent.com/apps/copilot-swe-agent
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.