| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2f470548-727a-3f55-8561-b120b5d997b9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CD6A:371F17:4ABFD:5B89F:698E992B |
| html-safe-nonce | 52303e47bac6ced8581b1dd93755568e49bb2389a663c489f9a0861ca1dbe217 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDZBOjM3MUYxNzo0QUJGRDo1Qjg5Rjo2OThFOTkyQiIsInZpc2l0b3JfaWQiOiIyNzQ4MjY0MzIzNjc1NDk0Njk5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 64b97b85b77a244bc70e4418d0fbdc52f4c15a4c372a7e8972b04f7aa0a42b01 |
| hovercard-subject-tag | pull_request:394146687 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/bee-queue/bee-queue/193/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/048e2373fd06a94fadf34aaded6373ae962e0225fe86ee6a50a5305f36637197/bee-queue/bee-queue/pull/193 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/048e2373fd06a94fadf34aaded6373ae962e0225fe86ee6a50a5305f36637197/bee-queue/bee-queue/pull/193 |
| og:image:alt | These changes fix the problems reported in #189 and originally in #78 . They do so by managing the job id in the Job object itself rather than in Redis. Various simplifications emerge. Note that... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | hughsw |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb2828a801ee6b7be618f3ac76fbf55def35bbc30f053a9c41bf90210b8b72ba |
| turbo-cache-control | no-preview |
| go-import | github.com/bee-queue/bee-queue git https://github.com/bee-queue/bee-queue.git |
| octolytics-dimension-user_id | 30018338 |
| octolytics-dimension-user_login | bee-queue |
| octolytics-dimension-repository_id | 29453461 |
| octolytics-dimension-repository_nwo | bee-queue/bee-queue |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 29453461 |
| octolytics-dimension-repository_network_root_nwo | bee-queue/bee-queue |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6b91a7e6e46287d26887e3fb7a4161657bab8f7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbee-queue%2Fbee-queue%2Fpull%2F193 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbee-queue%2Fbee-queue%2Fpull%2F193 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=bee-queue%2Fbee-queue |
| Reload | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193 |
| Reload | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193 |
| Reload | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193 |
|
bee-queue
| https://patch-diff.githubusercontent.com/bee-queue |
| bee-queue | https://patch-diff.githubusercontent.com/bee-queue/bee-queue |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Fbee-queue%2Fbee-queue |
|
Fork
222
| https://patch-diff.githubusercontent.com/login?return_to=%2Fbee-queue%2Fbee-queue |
|
Star
4k
| https://patch-diff.githubusercontent.com/login?return_to=%2Fbee-queue%2Fbee-queue |
|
Code
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue |
|
Issues
32
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/issues |
|
Pull requests
6
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pulls |
|
Discussions
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/discussions |
|
Actions
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/actions |
|
Projects
0
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/wiki |
|
Security
0
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/security |
|
Insights
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pulse |
|
Code
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue |
|
Issues
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pulls |
|
Discussions
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/discussions |
|
Actions
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/actions |
|
Projects
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/wiki |
|
Security
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/security |
|
Insights
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pulse |
| Sign up for GitHub
| https://patch-diff.githubusercontent.com/signup?return_to=%2Fbee-queue%2Fbee-queue%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=%2Fbee-queue%2Fbee-queue%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193#issue-comment-box |
| hughsw | https://patch-diff.githubusercontent.com/hughsw |
| bee-queue:master | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/tree/master |
| hughsw:fix-dropped-jobs | https://patch-diff.githubusercontent.com/hughsw/bee-queue/tree/fix-dropped-jobs |
|
fix(job.id): Use unique hex string for job id to avoid a race condition
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193#top |
| hughsw | https://patch-diff.githubusercontent.com/hughsw |
| bee-queue:master | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/tree/master |
| hughsw:fix-dropped-jobs | https://patch-diff.githubusercontent.com/hughsw/bee-queue/tree/fix-dropped-jobs |
|
Conversation
9
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193 |
|
Commits
2
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193/commits |
|
Checks
0
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193/checks |
|
Files changed
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193/files |
| Please reload this page | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/hughsw |
| hughsw | https://patch-diff.githubusercontent.com/hughsw |
| Mar 26, 2020 | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193#issue-588392361 |
| Please reload this page | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193 |
| #189 | https://github.com/bee-queue/bee-queue/issues/189 |
| #78 | https://github.com/bee-queue/bee-queue/issues/78 |
| Please reload this page | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193 |
|
| https://patch-diff.githubusercontent.com/hughsw |
| fix(job.id): Use unique hex string for job id to avoid a race condition | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193/commits/d1a0cd9201647f0b11c6a0c2fb085ae7b059fe23 |
| d1a0cd9 | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193/commits/d1a0cd9201647f0b11c6a0c2fb085ae7b059fe23 |
| https://patch-diff.githubusercontent.com/hughsw |
| hughsw | https://patch-diff.githubusercontent.com/hughsw |
| Mar 26, 2020 | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193#issuecomment-604412713 |
| Please reload this page | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193 |
|
| https://patch-diff.githubusercontent.com/hughsw |
| fix(tests): Fix two tests to work with new job.id behavior | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193/commits/9bd4134bee0a0998bc49f50d92b4735f561a7788 |
| 9bd4134 | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193/commits/9bd4134bee0a0998bc49f50d92b4735f561a7788 |
| https://patch-diff.githubusercontent.com/hughsw |
| hughsw | https://patch-diff.githubusercontent.com/hughsw |
| Mar 26, 2020 | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193#issuecomment-604448257 |
| Please reload this page | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193 |
| Please reload this page | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193 |
|
Reproducible: bee-queue loses track of jobs
#189
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/issues/189 |
|
'success' event not fired
#78
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/issues/78 |
| https://patch-diff.githubusercontent.com/bradvogel |
| bradvogel | https://patch-diff.githubusercontent.com/bradvogel |
| Mar 27, 2020 | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193#issuecomment-604988978 |
| Please reload this page | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193 |
| https://patch-diff.githubusercontent.com/hughsw |
| hughsw | https://patch-diff.githubusercontent.com/hughsw |
| Mar 27, 2020 | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193#issuecomment-605056270 |
| #189 | https://github.com/bee-queue/bee-queue/issues/189 |
| Please reload this page | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193 |
| https://patch-diff.githubusercontent.com/bradvogel |
| bradvogel | https://patch-diff.githubusercontent.com/bradvogel |
| Mar 27, 2020 | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193#issuecomment-605105660 |
| @skeggse | https://github.com/skeggse |
| @LewisJEllis | https://github.com/LewisJEllis |
| Please reload this page | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193 |
| https://patch-diff.githubusercontent.com/hughsw |
| hughsw | https://patch-diff.githubusercontent.com/hughsw |
| Mar 28, 2020 | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193#issuecomment-605439878 |
| Please reload this page | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193 |
| #78 | https://github.com/bee-queue/bee-queue/issues/78 |
| Please reload this page | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193 |
| https://patch-diff.githubusercontent.com/hughsw |
| hughsw | https://patch-diff.githubusercontent.com/hughsw |
| Mar 28, 2020 | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193#issuecomment-605446820 |
| Please reload this page | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193 |
| Please reload this page | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193 |
| https://patch-diff.githubusercontent.com/hughsw |
| hughsw | https://patch-diff.githubusercontent.com/hughsw |
| Mar 28, 2020 | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193#issuecomment-605500218 |
| Please reload this page | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193 |
| #194 | https://github.com/bee-queue/bee-queue/pull/194 |
| Please reload this page | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193 |
| https://patch-diff.githubusercontent.com/hughsw |
| hughsw | https://patch-diff.githubusercontent.com/hughsw |
| Apr 7, 2020 | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193#issuecomment-610442638 |
| #197 | https://github.com/bee-queue/bee-queue/pull/197 |
| Please reload this page | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193 |
| https://patch-diff.githubusercontent.com/hughsw |
| hughsw | https://patch-diff.githubusercontent.com/hughsw |
| Apr 7, 2020 | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193#event-3210315446 |
| https://patch-diff.githubusercontent.com/hughsw |
| hughsw | https://patch-diff.githubusercontent.com/hughsw |
| April 7, 2020 15:08 | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193#event-3210316977 |
| https://patch-diff.githubusercontent.com/hughsw |
| hughsw | https://patch-diff.githubusercontent.com/hughsw |
|
Apr 7, 2020
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193#ref-pullrequest-595938548 |
|
[Obsolete draft] Fix dropped jobs issue
#197
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/197 |
| https://patch-diff.githubusercontent.com/skeggse |
| skeggse | https://patch-diff.githubusercontent.com/skeggse |
|
Apr 16, 2020
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193#ref-pullrequest-601604235 |
|
fix: prevent event delivery race condition
#232
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/232 |
| https://patch-diff.githubusercontent.com/hughsw |
| hughsw | https://patch-diff.githubusercontent.com/hughsw |
|
Apr 18, 2020
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193#ref-pullrequest-602485085 |
|
fix: avoid collisions in auto-generated Job IDs causing dropped jobs
#237
| https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/237 |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbee-queue%2Fbee-queue%2Fpull%2F193 |
| Please reload this page | https://patch-diff.githubusercontent.com/bee-queue/bee-queue/pull/193 |
|
| https://patch-diff.githubusercontent.com/hughsw |
|
| https://patch-diff.githubusercontent.com/bradvogel |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |