René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"hash_secret with salt version set to non-bcrypt version returns an empty string instead of raising BCrypt::Errors::InvalidSalt","articleBody":"There is some interesting behavior going on when generating a hash with a salt that fits the validation regex, but has a version that doesn't exist, in that it returns the empty string instead of raising:\n\n```\n\u003e salt = \"$2a$10$TD5b9p9vdGsuEwKyrtSua.\"\n\u003e BCrypt::Engine.hash_secret(\"test\", salt, 10).to_s\n=\u003e \"$2a$10$TD5b9p9vdGsuEwKyrtSua.sh9lprEf.VOyagv/sm7PbdPVT46i.1K\"\n\n\u003e salt = \"$2x$10$TD5b9p9vdGsuEwKyrtSua.\"\n\u003e BCrypt::Engine.hash_secret(\"test\", salt, 10).to_s\n=\u003e \"$2x$10$TD5b9p9vdGsuEwKyrtSua.sh9lprEf.VOyagv/sm7PbdPVT46i.1K\"\n\n\u003e salt = \"$00$10$TD5b9p9vdGsuEwKyrtSua.\"\n\u003e BCrypt::Engine.hash_secret(\"test\", salt, 10).to_s\n=\u003e \"\"\n```\n\nThis behavior doesn't appear to be covered by specs, and looks to be slightly dangerous if undetected. Would it be a good idea to change the regex at https://github.com/codahale/bcrypt-ruby/blob/master/lib/bcrypt/engine.rb#L81\nfrom \n`/^\\$[0-9a-z]{2,}\\$[0-9]{2,}\\$[A-Za-z0-9\\.\\/]{22,}$/`\nto\n`/^\\$2[abxy]\\$[0-9]{2,}\\$[A-Za-z0-9\\.\\/]{22,}$/`\n, or am I missing some use-case here?\n","author":{"url":"https://github.com/DZittersteyn","@type":"Person","name":"DZittersteyn"},"datePublished":"2016-03-11T14:14:51.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/133/bcrypt-ruby/issues/133"}