| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f7409ad0-22aa-6de1-bfbe-55999c71b42b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AE1E:5BCF5:5C1CE62:76839B9:69766829 |
| html-safe-nonce | 4299bd25cc329ab0bac8122fed489359f5c7316ea517576c7e581ebdf29f3364 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTFFOjVCQ0Y1OjVDMUNFNjI6NzY4MzlCOTo2OTc2NjgyOSIsInZpc2l0b3JfaWQiOiI2OTg0MjI3OTQ3MzcxOTgwODQxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 1816f535b6c0df733d106b9f13cc6ae4b24ba8157708c72613fdfca3c8d9b537 |
| hovercard-subject-tag | pull_request:516562990 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/aws-cloudformation/cloudformation-cli-java-plugin/327/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/df9580cf754b1c960827695bd3c6c011d78a231429f890c169e2c40be27e13a9/aws-cloudformation/cloudformation-cli-java-plugin/pull/327 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/df9580cf754b1c960827695bd3c6c011d78a231429f890c169e2c40be27e13a9/aws-cloudformation/cloudformation-cli-java-plugin/pull/327 |
| og:image:alt | Issue #, if available:
Description of changes:
adding best practice to the codegen on how to handle tag update:
Stack level tags might be undesired tags, hence it's a best practice to catch pe... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ammokhov |
| hostname | github.com |
| expected-hostname | github.com |
| None | 032152924a283b83384255d9489e7b93b54ba01da8d380b05ecd3953b3212411 |
| turbo-cache-control | no-preview |
| go-import | github.com/aws-cloudformation/cloudformation-cli-java-plugin git https://github.com/aws-cloudformation/cloudformation-cli-java-plugin.git |
| octolytics-dimension-user_id | 19900777 |
| octolytics-dimension-user_login | aws-cloudformation |
| octolytics-dimension-repository_id | 152624998 |
| octolytics-dimension-repository_nwo | aws-cloudformation/cloudformation-cli-java-plugin |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 152624998 |
| octolytics-dimension-repository_network_root_nwo | aws-cloudformation/cloudformation-cli-java-plugin |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5b577f6be6482e336e3c30e8daefa30144947b17 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Faws-cloudformation%2Fcloudformation-cli-java-plugin%2Fpull%2F327 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Faws-cloudformation%2Fcloudformation-cli-java-plugin%2Fpull%2F327 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=aws-cloudformation%2Fcloudformation-cli-java-plugin |
| Reload | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327 |
| Reload | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327 |
| Reload | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327 |
|
aws-cloudformation
| https://patch-diff.githubusercontent.com/aws-cloudformation |
| cloudformation-cli-java-plugin | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Faws-cloudformation%2Fcloudformation-cli-java-plugin |
|
Fork
48
| https://patch-diff.githubusercontent.com/login?return_to=%2Faws-cloudformation%2Fcloudformation-cli-java-plugin |
|
Star
30
| https://patch-diff.githubusercontent.com/login?return_to=%2Faws-cloudformation%2Fcloudformation-cli-java-plugin |
|
Code
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin |
|
Issues
31
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/issues |
|
Pull requests
12
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/actions |
|
Projects
0
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/projects |
|
Security
1
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/security |
|
Insights
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pulse |
|
Code
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin |
|
Issues
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/actions |
|
Projects
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/projects |
|
Security
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/security |
|
Insights
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pulse |
| Sign up for GitHub
| https://patch-diff.githubusercontent.com/signup?return_to=%2Faws-cloudformation%2Fcloudformation-cli-java-plugin%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=%2Faws-cloudformation%2Fcloudformation-cli-java-plugin%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327#issue-comment-box |
| ammokhov | https://patch-diff.githubusercontent.com/ammokhov |
| aws-cloudformation:master | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/tree/master |
| ammokhov:codegen-update-tags | https://patch-diff.githubusercontent.com/ammokhov/cloudformation-cli-java-plugin/tree/codegen-update-tags |
|
[codegen] adding best practice to update tags
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327#top |
| ammokhov | https://patch-diff.githubusercontent.com/ammokhov |
| aws-cloudformation:master | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/tree/master |
| ammokhov:codegen-update-tags | https://patch-diff.githubusercontent.com/ammokhov/cloudformation-cli-java-plugin/tree/codegen-update-tags |
|
Conversation
7
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327 |
|
Commits
1
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327/commits |
|
Checks
0
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327/checks |
|
Files changed
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327/files |
| Please reload this page | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/ammokhov |
| ammokhov | https://patch-diff.githubusercontent.com/ammokhov |
| Nov 6, 2020 | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327#issue-737539621 |
| Please reload this page | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327 |
|
| https://patch-diff.githubusercontent.com/ammokhov |
| [codegen] adding best practice to update tags | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327/commits/93cb30a47bb8d1886e9bc57c306281212a4ec6d4 |
| 93cb30a | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327/commits/93cb30a47bb8d1886e9bc57c306281212a4ec6d4 |
| https://patch-diff.githubusercontent.com/ammokhov |
| ammokhov | https://patch-diff.githubusercontent.com/ammokhov |
| wbingli | https://patch-diff.githubusercontent.com/wbingli |
| November 6, 2020 07:30 | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327#event-3965901045 |
| https://patch-diff.githubusercontent.com/ammokhov |
| ammokhov | https://patch-diff.githubusercontent.com/ammokhov |
| Nov 6, 2020 | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327#event-3965901362 |
| https://patch-diff.githubusercontent.com/ammokhov |
| ammokhov | https://patch-diff.githubusercontent.com/ammokhov |
|
codegen
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/issues?q=state%3Aopen%20label%3Acodegen |
|
enhancement
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/issues?q=state%3Aopen%20label%3Aenhancement |
| Nov 6, 2020 | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327#event-3965901921 |
| https://patch-diff.githubusercontent.com/ammokhov |
| ammokhov | https://patch-diff.githubusercontent.com/ammokhov |
| johnttompkins | https://patch-diff.githubusercontent.com/johnttompkins |
| nina-ctrlv | https://patch-diff.githubusercontent.com/nina-ctrlv |
| sungkkim | https://patch-diff.githubusercontent.com/sungkkim |
| November 6, 2020 07:32 | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327#event-3965906724 |
| https://patch-diff.githubusercontent.com/sungkkim |
| sungkkim | https://patch-diff.githubusercontent.com/sungkkim |
| Nov 6, 2020 | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327#issuecomment-723303668 |
| Please reload this page | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327 |
| https://patch-diff.githubusercontent.com/wbingli |
| wbingli | https://patch-diff.githubusercontent.com/wbingli |
|
Nov 10, 2020
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327#pullrequestreview-527463375 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327/files/93cb30a47bb8d1886e9bc57c306281212a4ec6d4 |
| python/rpdk/java/templates/init/guided_aws/StubUpdateHandler.java | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327/files/93cb30a47bb8d1886e9bc57c306281212a4ec6d4#diff-c3260ebdad21f5d2b1119b4e705c4aef486a8b5ff2ba36d7f4063ad3d1be2bb1 |
| wbingli | https://patch-diff.githubusercontent.com/wbingli |
| Nov 10, 2020 | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327#discussion_r520759704 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327 |
| ammokhov | https://patch-diff.githubusercontent.com/ammokhov |
| Nov 10, 2020 | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327#discussion_r520761889 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327 |
| https://patch-diff.githubusercontent.com/wbingli |
| wbingli | https://patch-diff.githubusercontent.com/wbingli |
|
Nov 10, 2020
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327#pullrequestreview-527488461 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327/files/93cb30a47bb8d1886e9bc57c306281212a4ec6d4 |
| python/rpdk/java/templates/init/guided_aws/StubUpdateHandler.java | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327/files/93cb30a47bb8d1886e9bc57c306281212a4ec6d4#diff-c3260ebdad21f5d2b1119b4e705c4aef486a8b5ff2ba36d7f4063ad3d1be2bb1 |
| wbingli | https://patch-diff.githubusercontent.com/wbingli |
| Nov 10, 2020 | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327#discussion_r520779132 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327 |
| ammokhov | https://patch-diff.githubusercontent.com/ammokhov |
| Nov 10, 2020 | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327#discussion_r520817623 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327 |
| https://patch-diff.githubusercontent.com/nina-ctrlv |
| nina-ctrlv | https://patch-diff.githubusercontent.com/nina-ctrlv |
| Nov 10, 2020 | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327#issuecomment-724933309 |
| Please reload this page | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327 |
| https://patch-diff.githubusercontent.com/wbingli |
| wbingli | https://patch-diff.githubusercontent.com/wbingli |
| Nov 23, 2020 | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327#issuecomment-732438826 |
| Please reload this page | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327 |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Faws-cloudformation%2Fcloudformation-cli-java-plugin%2Fpull%2F327 |
|
| https://patch-diff.githubusercontent.com/johnttompkins |
|
johnttompkins
| https://patch-diff.githubusercontent.com/johnttompkins |
|
| https://patch-diff.githubusercontent.com/sungkkim |
|
sungkkim
| https://patch-diff.githubusercontent.com/sungkkim |
|
| https://patch-diff.githubusercontent.com/nina-ctrlv |
|
nina-ctrlv
| https://patch-diff.githubusercontent.com/nina-ctrlv |
|
| https://patch-diff.githubusercontent.com/wbingli |
|
wbingli
| https://patch-diff.githubusercontent.com/wbingli |
|
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327/files/93cb30a47bb8d1886e9bc57c306281212a4ec6d4 |
|
| https://patch-diff.githubusercontent.com/ammokhov |
|
ammokhov
| https://patch-diff.githubusercontent.com/ammokhov |
|
codegen
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/issues?q=state%3Aopen%20label%3Acodegen |
|
enhancement
| https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/issues?q=state%3Aopen%20label%3Aenhancement |
| Please reload this page | https://patch-diff.githubusercontent.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/327 |
|
| https://patch-diff.githubusercontent.com/ammokhov |
|
| https://patch-diff.githubusercontent.com/sungkkim |
|
| https://patch-diff.githubusercontent.com/nina-ctrlv |
|
| https://patch-diff.githubusercontent.com/wbingli |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |