René's URL Explorer Experiment


Title: Modernise grammar and fix bugs by Alhadis · Pull Request #415 · atom/language-javascript · GitHub

Open Graph Title: Modernise grammar and fix bugs by Alhadis · Pull Request #415 · atom/language-javascript

X Title: Modernise grammar and fix bugs by Alhadis · Pull Request #415 · atom/language-javascript

Description: There's quite a bit happening with this PR, so hopefully my explanations are digestible. Added: Support for ES6 Unicode escapes ## Fixed: Bugs with constructors Constructors containing dollar-sign...

Open Graph Description: There's quite a bit happening with this PR, so hopefully my explanations are digestible. Added: Support for ES6 Unicode escapes ## Fixed: Bugs with constructors Constructors containing dollar-...

X Description: There's quite a bit happening with this PR, so hopefully my explanations are digestible. Added: Support for ES6 Unicode escapes ## Fixed: Bugs with constructors Constructors containing dol...

Opengraph URL: https://github.com/atom/language-javascript/pull/415

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:787282ef-c313-6806-18f9-8bd5101727f6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA684:1B8E26:A54E004:D6C75B5:69765458
html-safe-nonceb857b85db6b0c74677f9b90c44b0410adb74b98224ba56abd15ff27c4dab8176
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjg0OjFCOEUyNjpBNTRFMDA0OkQ2Qzc1QjU6Njk3NjU0NTgiLCJ2aXNpdG9yX2lkIjoiNDk1MDk1MjkwODYxMTI3NzkxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc85bbabf0c4268514b0f77a107b6811df125fcdcc01110caa371d97dc360f6d4
hovercard-subject-tagpull_request:82345488
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/atom/language-javascript/415/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/55472008085ef1703f5c456b119afd814a9edb77b2c19f3ae5a05b605960ffc5/atom/language-javascript/pull/415
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/55472008085ef1703f5c456b119afd814a9edb77b2c19f3ae5a05b605960ffc5/atom/language-javascript/pull/415
og:image:altThere's quite a bit happening with this PR, so hopefully my explanations are digestible. Added: Support for ES6 Unicode escapes ## Fixed: Bugs with constructors Constructors containing dollar-...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAlhadis
hostnamegithub.com
expected-hostnamegithub.com
None032152924a283b83384255d9489e7b93b54ba01da8d380b05ecd3953b3212411
turbo-cache-controlno-preview
go-importgithub.com/atom/language-javascript git https://github.com/atom/language-javascript.git
octolytics-dimension-user_id1089146
octolytics-dimension-user_loginatom
octolytics-dimension-repository_id13712111
octolytics-dimension-repository_nwoatom/language-javascript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id13712111
octolytics-dimension-repository_network_root_nwoatom/language-javascript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5b577f6be6482e336e3c30e8daefa30144947b17
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fatom%2Flanguage-javascript%2Fpull%2F415
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fatom%2Flanguage-javascript%2Fpull%2F415
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=atom%2Flanguage-javascript
Reloadhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415
Reloadhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415
Reloadhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415
atom https://patch-diff.githubusercontent.com/atom
language-javascripthttps://patch-diff.githubusercontent.com/atom/language-javascript
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fatom%2Flanguage-javascript
Fork 235 https://patch-diff.githubusercontent.com/login?return_to=%2Fatom%2Flanguage-javascript
Star 197 https://patch-diff.githubusercontent.com/login?return_to=%2Fatom%2Flanguage-javascript
Code https://patch-diff.githubusercontent.com/atom/language-javascript
Issues 82 https://patch-diff.githubusercontent.com/atom/language-javascript/issues
Pull requests 12 https://patch-diff.githubusercontent.com/atom/language-javascript/pulls
Actions https://patch-diff.githubusercontent.com/atom/language-javascript/actions
Projects 0 https://patch-diff.githubusercontent.com/atom/language-javascript/projects
Wiki https://patch-diff.githubusercontent.com/atom/language-javascript/wiki
Security 0 https://patch-diff.githubusercontent.com/atom/language-javascript/security
Insights https://patch-diff.githubusercontent.com/atom/language-javascript/pulse
Code https://patch-diff.githubusercontent.com/atom/language-javascript
Issues https://patch-diff.githubusercontent.com/atom/language-javascript/issues
Pull requests https://patch-diff.githubusercontent.com/atom/language-javascript/pulls
Actions https://patch-diff.githubusercontent.com/atom/language-javascript/actions
Projects https://patch-diff.githubusercontent.com/atom/language-javascript/projects
Wiki https://patch-diff.githubusercontent.com/atom/language-javascript/wiki
Security https://patch-diff.githubusercontent.com/atom/language-javascript/security
Insights https://patch-diff.githubusercontent.com/atom/language-javascript/pulse
winstliuhttps://patch-diff.githubusercontent.com/winstliu
atom:masterhttps://patch-diff.githubusercontent.com/atom/language-javascript/tree/master
Modernise grammar and fix bugs https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#top
winstliuhttps://patch-diff.githubusercontent.com/winstliu
atom:masterhttps://patch-diff.githubusercontent.com/atom/language-javascript/tree/master
Conversation 15 https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415
Commits 20 https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits
Checks 0 https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/checks
Files changed https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/files
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/atom/language-javascript/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/Alhadis
Alhadishttps://patch-diff.githubusercontent.com/Alhadis
Aug 23, 2016https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#issue-172672175
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415
https://cloud.githubusercontent.com/assets/2346707/17889218/86adadb4-6972-11e6-94cf-5592100d0359.gif
#280https://github.com/atom/language-javascript/issues/280
https://cloud.githubusercontent.com/assets/2346707/17889381/4839b8ba-6973-11e6-9bef-727485a421ca.gif
#409: Wrong highlighting for constants with dollar signhttps://github.com/atom/language-javascript/issues/409
#344: Wrong scope on $this and $defaulthttps://github.com/atom/language-javascript/issues/344
JavaScript classeshttps://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference
wrote a scripthttps://gist.github.com/Alhadis/16effd7a22522c793a41bbc65424eed8
web interfaces documented on MDNhttps://developer.mozilla.org/en-US/docs/Web/API
HTMLAnchorhttps://developer.mozilla.org/en-US/docs/Web/API/HTMLAnchorElement
HTMLAreahttps://developer.mozilla.org/en-US/docs/Web/API/HTMLAreaElement
HTMLSelecthttps://developer.mozilla.org/en-US/docs/Web/API/HTMLSelectElement
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415
August 21, 2016 00:53https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#commits-pushed-9f6a8ac
Add pattern-matching for Unicode escape sequenceshttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/9f6a8acba4b3538e6679b55d2bab8a9289922e8b
https://patch-diff.githubusercontent.com/atom/language-javascript/commit/9f6a8acba4b3538e6679b55d2bab8a9289922e8b#comments
9f6a8achttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/9f6a8acba4b3538e6679b55d2bab8a9289922e8b
Add error highlighting to codepoints over U+10FFFFhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/a208ceb10f6fd154b2798e0197ccaa26e864f74b
a208cebhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/a208ceb10f6fd154b2798e0197ccaa26e864f74b
Merge upstream changes into topic branchhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/03798dbaeefc8a636b2ea5b9af0a825f8fa9c080
03798dbhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/03798dbaeefc8a636b2ea5b9af0a825f8fa9c080
Allow whitespace in "support.constant" accessorshttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/b04283b4d847bc78c5ece6dcba65e72ff5e4c638
b04283bhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/b04283b4d847bc78c5ece6dcba65e72ff5e4c638
Update and correctly classify "support" keywordshttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/fb9f7d8f2df8bef2a076cdce8e8a501d74d2f0da
fb9f7d8https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/fb9f7d8f2df8bef2a076cdce8e8a501d74d2f0da
https://developer.mozilla.org/en-US/docs/Web/APIhttps://developer.mozilla.org/en-US/docs/Web/API
Fix bugs with matching dollar-signs in constantshttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/2fac2bd8482282f6593086d7ff9dd54478ff3318
2fac2bdhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/2fac2bd8482282f6593086d7ff9dd54478ff3318
#409https://github.com/atom/language-javascript/issues/409
Avoid matching "this" in "$this"https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/de3212648440ae367f9c19ddc4c9eb8334dd2b33
de32126https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/de3212648440ae367f9c19ddc4c9eb8334dd2b33
#344https://github.com/atom/language-javascript/issues/344
Fix bugs with matching instantiation patternshttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/fb456ca9411b19aff3f417da00923df6023c29e0
fb456cahttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/fb456ca9411b19aff3f417da00923df6023c29e0
#280https://github.com/atom/language-javascript/issues/280
Allow solitary majuscules to match as constantshttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/50b02a4c35216ebe39eadf1afa6a619ee832a1f6
50b02a4https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/50b02a4c35216ebe39eadf1afa6a619ee832a1f6
#413https://github.com/atom/language-javascript/issues/413
Add specs forhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/f4ec66d13309909bdc806ecfbc9457469432e119
9f6a8achttps://github.com/atom/language-javascript/commit/9f6a8acba4b3538e6679b55d2bab8a9289922e8b
andhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/f4ec66d13309909bdc806ecfbc9457469432e119
a208cebhttps://github.com/atom/language-javascript/commit/a208ceb10f6fd154b2798e0197ccaa26e864f74b
f4ec66dhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/f4ec66d13309909bdc806ecfbc9457469432e119
Avoid matching constants without majusculeshttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/d95b0ea8758effc8cfaff22f53b991807064a1d9
d95b0eahttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/d95b0ea8758effc8cfaff22f53b991807064a1d9
Use more specific scope-names when possiblehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/0ee586487b00ef3ea506669d819b26f06f363d76
0ee5864https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/0ee586487b00ef3ea506669d819b26f06f363d76
https://patch-diff.githubusercontent.com/MaximSokolov
MaximSokolovhttps://patch-diff.githubusercontent.com/MaximSokolov
Aug 23, 2016https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#issuecomment-241704914
#408https://github.com/atom/language-javascript/pull/408
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415
Resolve conflicts withhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/b9ba47bde6a7491220f65824ac0b8e1e9f71afd0
#408https://github.com/atom/language-javascript/pull/408
b9ba47bhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/b9ba47bde6a7491220f65824ac0b8e1e9f71afd0
https://patch-diff.githubusercontent.com/Alhadis
Alhadishttps://patch-diff.githubusercontent.com/Alhadis
Aug 23, 2016https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#issuecomment-241711504
https://cloud.githubusercontent.com/assets/2346707/17891369/aac2ac34-697e-11e6-8aa0-37dcc4d62ced.jpg
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415
Fix failing specshttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/fc8560ee6f03b8de6386984989ab883c2caf0d42
fc8560ehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/fc8560ee6f03b8de6386984989ab883c2caf0d42
https://patch-diff.githubusercontent.com/Alhadis
Alhadishttps://patch-diff.githubusercontent.com/Alhadis
Aug 23, 2016https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#issuecomment-241712297
@MaximSokolovhttps://github.com/MaximSokolov
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415
Merge upstream into topic branchhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/07e2a16d7758a090202a623552398aa12c47ff8f
07e2a16https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/07e2a16d7758a090202a623552398aa12c47ff8f
https://patch-diff.githubusercontent.com/winstliu
winstliuhttps://patch-diff.githubusercontent.com/winstliu
Aug 23, 2016https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#issuecomment-241791238
#408https://github.com/atom/language-javascript/pull/408
@Alhadishttps://github.com/Alhadis
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415
https://patch-diff.githubusercontent.com/Alhadis
Alhadishttps://patch-diff.githubusercontent.com/Alhadis
Aug 23, 2016https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#issuecomment-241791511
Already didhttps://github.com/atom/language-javascript/pull/415/commits/b9ba47bde6a7491220f65824ac0b8e1e9f71afd0
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415
https://patch-diff.githubusercontent.com/winstliu
winstliuhttps://patch-diff.githubusercontent.com/winstliu
needs-review https://patch-diff.githubusercontent.com/atom/language-javascript/issues?q=state%3Aopen%20label%3Aneeds-review
Aug 23, 2016https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#event-764749300
winstliuhttps://patch-diff.githubusercontent.com/winstliu
Aug 23, 2016 https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#discussion-diff-75913112
View reviewed changes https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/files/07e2a16d7758a090202a623552398aa12c47ff8f#diff-eb4d6a651ba24caf4dd09a5759907caa8599306654fc5cf8d25c695248e565cd
grammars/javascript.csonhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/files#diff-eb4d6a651ba24caf4dd09a5759907caa8599306654fc5cf8d25c695248e565cd
winstliuhttps://patch-diff.githubusercontent.com/winstliu
Aug 23, 2016https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#discussion_r75913112
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415
https://patch-diff.githubusercontent.com/winstliu
winstliuhttps://patch-diff.githubusercontent.com/winstliu
Aug 23, 2016https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#issuecomment-241810363
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415
August 24, 2016 03:34https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#commits-pushed-3b082ef
Add missing space and scope-namehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/3b082efe08cc22225e680ae867f729f1627620c9
3b082efhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/3b082efe08cc22225e680ae867f729f1627620c9
Remove whitespace in specshttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/70a1a68af70cedf62e2cd0ddcab978cf00b187c9
70a1a68https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/70a1a68af70cedf62e2cd0ddcab978cf00b187c9
https://patch-diff.githubusercontent.com/Alhadis
Alhadishttps://patch-diff.githubusercontent.com/Alhadis
Aug 23, 2016https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#issuecomment-241812899
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415
August 24, 2016 05:16https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#commits-pushed-6145b2d
Merge upstream changes into topic branchhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/6145b2dab82304f702bd0933e162a058675e41e9
6145b2dhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/6145b2dab82304f702bd0933e162a058675e41e9
Update specs to accommodatehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/33fcb714e36a831b8cd343da645d40daec1a557b
3b082efhttps://github.com/atom/language-javascript/commit/3b082efe08cc22225e680ae867f729f1627620c9
's changeshttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/33fcb714e36a831b8cd343da645d40daec1a557b
33fcb71https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/33fcb714e36a831b8cd343da645d40daec1a557b
winstliuhttps://patch-diff.githubusercontent.com/winstliu
Aug 23, 2016 https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#discussion-diff-75939075
View reviewed changes https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/files/33fcb714e36a831b8cd343da645d40daec1a557b#diff-ad1df1a6fb1e184c8294a94418c0dcba44b84968ae60b819ab60358361d4c8c1
spec/javascript-spec.coffeehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/files#diff-ad1df1a6fb1e184c8294a94418c0dcba44b84968ae60b819ab60358361d4c8c1
winstliuhttps://patch-diff.githubusercontent.com/winstliu
Aug 23, 2016https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#discussion_r75939075
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415
winstliuhttps://patch-diff.githubusercontent.com/winstliu
Aug 23, 2016 https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#discussion-diff-75939114
View reviewed changes https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/files/33fcb714e36a831b8cd343da645d40daec1a557b#diff-ad1df1a6fb1e184c8294a94418c0dcba44b84968ae60b819ab60358361d4c8c1
spec/javascript-spec.coffeehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/files#diff-ad1df1a6fb1e184c8294a94418c0dcba44b84968ae60b819ab60358361d4c8c1
winstliuhttps://patch-diff.githubusercontent.com/winstliu
Aug 23, 2016https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#discussion_r75939114
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415
Alhadishttps://patch-diff.githubusercontent.com/Alhadis
Aug 23, 2016https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#discussion_r75939705
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415
winstliuhttps://patch-diff.githubusercontent.com/winstliu
Aug 23, 2016https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#discussion_r75960795
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415
winstliuhttps://patch-diff.githubusercontent.com/winstliu
Aug 23, 2016https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#discussion_r75960836
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415
Alhadishttps://patch-diff.githubusercontent.com/Alhadis
Aug 24, 2016https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#discussion_r75995533
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415
Conform to formatting of existing specshttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/f2871d41f9494479a4d4a93f7ef530485ab599e2
f2871d4https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/f2871d41f9494479a4d4a93f7ef530485ab599e2
https://patch-diff.githubusercontent.com/winstliu
winstliuhttps://patch-diff.githubusercontent.com/winstliu
6e22521https://patch-diff.githubusercontent.com/atom/language-javascript/commit/6e22521be0a466dc7edaaf97e882145aafab8164
Aug 24, 2016https://github.com/atom/language-javascript/pull/415#event-766485498
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fatom%2Flanguage-javascript%2Fpull%2F415
needs-review https://patch-diff.githubusercontent.com/atom/language-javascript/issues?q=state%3Aopen%20label%3Aneeds-review
Wrong highlighting for constants with dollar sign https://github.com/atom/language-javascript/issues/409
Wrong scope on $this and $default https://github.com/atom/language-javascript/issues/344
Missing scopes on periods https://github.com/atom/language-javascript/issues/280
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/415
https://patch-diff.githubusercontent.com/Alhadis
https://patch-diff.githubusercontent.com/MaximSokolov
https://patch-diff.githubusercontent.com/winstliu
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.