| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:787282ef-c313-6806-18f9-8bd5101727f6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A684:1B8E26:A54E004:D6C75B5:69765458 |
| html-safe-nonce | b857b85db6b0c74677f9b90c44b0410adb74b98224ba56abd15ff27c4dab8176 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjg0OjFCOEUyNjpBNTRFMDA0OkQ2Qzc1QjU6Njk3NjU0NTgiLCJ2aXNpdG9yX2lkIjoiNDk1MDk1MjkwODYxMTI3NzkxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c85bbabf0c4268514b0f77a107b6811df125fcdcc01110caa371d97dc360f6d4 |
| hovercard-subject-tag | pull_request:82345488 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/atom/language-javascript/415/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/55472008085ef1703f5c456b119afd814a9edb77b2c19f3ae5a05b605960ffc5/atom/language-javascript/pull/415 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/55472008085ef1703f5c456b119afd814a9edb77b2c19f3ae5a05b605960ffc5/atom/language-javascript/pull/415 |
| og:image:alt | There's quite a bit happening with this PR, so hopefully my explanations are digestible.
Added: Support for ES6 Unicode escapes
## Fixed: Bugs with constructors
Constructors containing dollar-... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Alhadis |
| hostname | github.com |
| expected-hostname | github.com |
| None | 032152924a283b83384255d9489e7b93b54ba01da8d380b05ecd3953b3212411 |
| turbo-cache-control | no-preview |
| go-import | github.com/atom/language-javascript git https://github.com/atom/language-javascript.git |
| octolytics-dimension-user_id | 1089146 |
| octolytics-dimension-user_login | atom |
| octolytics-dimension-repository_id | 13712111 |
| octolytics-dimension-repository_nwo | atom/language-javascript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 13712111 |
| octolytics-dimension-repository_network_root_nwo | atom/language-javascript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5b577f6be6482e336e3c30e8daefa30144947b17 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fatom%2Flanguage-javascript%2Fpull%2F415 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fatom%2Flanguage-javascript%2Fpull%2F415 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=atom%2Flanguage-javascript |
| Reload | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415 |
| Reload | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415 |
| Reload | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415 |
|
atom
| https://patch-diff.githubusercontent.com/atom |
| language-javascript | https://patch-diff.githubusercontent.com/atom/language-javascript |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Fatom%2Flanguage-javascript |
|
Fork
235
| https://patch-diff.githubusercontent.com/login?return_to=%2Fatom%2Flanguage-javascript |
|
Star
197
| https://patch-diff.githubusercontent.com/login?return_to=%2Fatom%2Flanguage-javascript |
|
Code
| https://patch-diff.githubusercontent.com/atom/language-javascript |
|
Issues
82
| https://patch-diff.githubusercontent.com/atom/language-javascript/issues |
|
Pull requests
12
| https://patch-diff.githubusercontent.com/atom/language-javascript/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/atom/language-javascript/actions |
|
Projects
0
| https://patch-diff.githubusercontent.com/atom/language-javascript/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/atom/language-javascript/wiki |
|
Security
0
| https://patch-diff.githubusercontent.com/atom/language-javascript/security |
|
Insights
| https://patch-diff.githubusercontent.com/atom/language-javascript/pulse |
|
Code
| https://patch-diff.githubusercontent.com/atom/language-javascript |
|
Issues
| https://patch-diff.githubusercontent.com/atom/language-javascript/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/atom/language-javascript/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/atom/language-javascript/actions |
|
Projects
| https://patch-diff.githubusercontent.com/atom/language-javascript/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/atom/language-javascript/wiki |
|
Security
| https://patch-diff.githubusercontent.com/atom/language-javascript/security |
|
Insights
| https://patch-diff.githubusercontent.com/atom/language-javascript/pulse |
| winstliu | https://patch-diff.githubusercontent.com/winstliu |
| atom:master | https://patch-diff.githubusercontent.com/atom/language-javascript/tree/master |
|
Modernise grammar and fix bugs
| https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#top |
| winstliu | https://patch-diff.githubusercontent.com/winstliu |
| atom:master | https://patch-diff.githubusercontent.com/atom/language-javascript/tree/master |
|
Conversation
15
| https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415 |
|
Commits
20
| https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits |
|
Checks
0
| https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/checks |
|
Files changed
| https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/files |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/atom/language-javascript/pull/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/Alhadis |
| Alhadis | https://patch-diff.githubusercontent.com/Alhadis |
| Aug 23, 2016 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#issue-172672175 |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415 |
| https://cloud.githubusercontent.com/assets/2346707/17889218/86adadb4-6972-11e6-94cf-5592100d0359.gif |
| #280 | https://github.com/atom/language-javascript/issues/280 |
| https://cloud.githubusercontent.com/assets/2346707/17889381/4839b8ba-6973-11e6-9bef-727485a421ca.gif |
| #409: Wrong highlighting for constants with dollar sign | https://github.com/atom/language-javascript/issues/409 |
| #344: Wrong scope on $this and $default | https://github.com/atom/language-javascript/issues/344 |
| JavaScript classes | https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference |
| wrote a script | https://gist.github.com/Alhadis/16effd7a22522c793a41bbc65424eed8 |
| web interfaces documented on MDN | https://developer.mozilla.org/en-US/docs/Web/API |
| HTMLAnchor | https://developer.mozilla.org/en-US/docs/Web/API/HTMLAnchorElement |
| HTMLArea | https://developer.mozilla.org/en-US/docs/Web/API/HTMLAreaElement |
| HTMLSelect | https://developer.mozilla.org/en-US/docs/Web/API/HTMLSelectElement |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415 |
| August 21, 2016 00:53 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#commits-pushed-9f6a8ac |
| Add pattern-matching for Unicode escape sequences | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/9f6a8acba4b3538e6679b55d2bab8a9289922e8b |
|
| https://patch-diff.githubusercontent.com/atom/language-javascript/commit/9f6a8acba4b3538e6679b55d2bab8a9289922e8b#comments |
| 9f6a8ac | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/9f6a8acba4b3538e6679b55d2bab8a9289922e8b |
| Add error highlighting to codepoints over U+10FFFF | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/a208ceb10f6fd154b2798e0197ccaa26e864f74b |
| a208ceb | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/a208ceb10f6fd154b2798e0197ccaa26e864f74b |
| Merge upstream changes into topic branch | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/03798dbaeefc8a636b2ea5b9af0a825f8fa9c080 |
| 03798db | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/03798dbaeefc8a636b2ea5b9af0a825f8fa9c080 |
| Allow whitespace in "support.constant" accessors | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/b04283b4d847bc78c5ece6dcba65e72ff5e4c638 |
| b04283b | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/b04283b4d847bc78c5ece6dcba65e72ff5e4c638 |
| Update and correctly classify "support" keywords | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/fb9f7d8f2df8bef2a076cdce8e8a501d74d2f0da |
| fb9f7d8 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/fb9f7d8f2df8bef2a076cdce8e8a501d74d2f0da |
| https://developer.mozilla.org/en-US/docs/Web/API | https://developer.mozilla.org/en-US/docs/Web/API |
| Fix bugs with matching dollar-signs in constants | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/2fac2bd8482282f6593086d7ff9dd54478ff3318 |
| 2fac2bd | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/2fac2bd8482282f6593086d7ff9dd54478ff3318 |
| #409 | https://github.com/atom/language-javascript/issues/409 |
| Avoid matching "this" in "$this" | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/de3212648440ae367f9c19ddc4c9eb8334dd2b33 |
| de32126 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/de3212648440ae367f9c19ddc4c9eb8334dd2b33 |
| #344 | https://github.com/atom/language-javascript/issues/344 |
| Fix bugs with matching instantiation patterns | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/fb456ca9411b19aff3f417da00923df6023c29e0 |
| fb456ca | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/fb456ca9411b19aff3f417da00923df6023c29e0 |
| #280 | https://github.com/atom/language-javascript/issues/280 |
| Allow solitary majuscules to match as constants | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/50b02a4c35216ebe39eadf1afa6a619ee832a1f6 |
| 50b02a4 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/50b02a4c35216ebe39eadf1afa6a619ee832a1f6 |
| #413 | https://github.com/atom/language-javascript/issues/413 |
| Add specs for | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/f4ec66d13309909bdc806ecfbc9457469432e119 |
| 9f6a8ac | https://github.com/atom/language-javascript/commit/9f6a8acba4b3538e6679b55d2bab8a9289922e8b |
| and | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/f4ec66d13309909bdc806ecfbc9457469432e119 |
| a208ceb | https://github.com/atom/language-javascript/commit/a208ceb10f6fd154b2798e0197ccaa26e864f74b |
| f4ec66d | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/f4ec66d13309909bdc806ecfbc9457469432e119 |
| Avoid matching constants without majuscules | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/d95b0ea8758effc8cfaff22f53b991807064a1d9 |
| d95b0ea | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/d95b0ea8758effc8cfaff22f53b991807064a1d9 |
| Use more specific scope-names when possible | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/0ee586487b00ef3ea506669d819b26f06f363d76 |
| 0ee5864 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/0ee586487b00ef3ea506669d819b26f06f363d76 |
| https://patch-diff.githubusercontent.com/MaximSokolov |
| MaximSokolov | https://patch-diff.githubusercontent.com/MaximSokolov |
| Aug 23, 2016 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#issuecomment-241704914 |
| #408 | https://github.com/atom/language-javascript/pull/408 |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415 |
| Resolve conflicts with | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/b9ba47bde6a7491220f65824ac0b8e1e9f71afd0 |
| #408 | https://github.com/atom/language-javascript/pull/408 |
| b9ba47b | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/b9ba47bde6a7491220f65824ac0b8e1e9f71afd0 |
| https://patch-diff.githubusercontent.com/Alhadis |
| Alhadis | https://patch-diff.githubusercontent.com/Alhadis |
| Aug 23, 2016 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#issuecomment-241711504 |
| https://cloud.githubusercontent.com/assets/2346707/17891369/aac2ac34-697e-11e6-8aa0-37dcc4d62ced.jpg |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415 |
| Fix failing specs | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/fc8560ee6f03b8de6386984989ab883c2caf0d42 |
| fc8560e | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/fc8560ee6f03b8de6386984989ab883c2caf0d42 |
| https://patch-diff.githubusercontent.com/Alhadis |
| Alhadis | https://patch-diff.githubusercontent.com/Alhadis |
| Aug 23, 2016 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#issuecomment-241712297 |
| @MaximSokolov | https://github.com/MaximSokolov |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415 |
| Merge upstream into topic branch | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/07e2a16d7758a090202a623552398aa12c47ff8f |
| 07e2a16 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/07e2a16d7758a090202a623552398aa12c47ff8f |
| https://patch-diff.githubusercontent.com/winstliu |
| winstliu | https://patch-diff.githubusercontent.com/winstliu |
| Aug 23, 2016 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#issuecomment-241791238 |
| #408 | https://github.com/atom/language-javascript/pull/408 |
| @Alhadis | https://github.com/Alhadis |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415 |
| https://patch-diff.githubusercontent.com/Alhadis |
| Alhadis | https://patch-diff.githubusercontent.com/Alhadis |
| Aug 23, 2016 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#issuecomment-241791511 |
| Already did | https://github.com/atom/language-javascript/pull/415/commits/b9ba47bde6a7491220f65824ac0b8e1e9f71afd0 |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415 |
| https://patch-diff.githubusercontent.com/winstliu |
| winstliu | https://patch-diff.githubusercontent.com/winstliu |
|
needs-review
| https://patch-diff.githubusercontent.com/atom/language-javascript/issues?q=state%3Aopen%20label%3Aneeds-review |
| Aug 23, 2016 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#event-764749300 |
| winstliu | https://patch-diff.githubusercontent.com/winstliu |
|
Aug 23, 2016
| https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#discussion-diff-75913112 |
| View reviewed changes
| https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/files/07e2a16d7758a090202a623552398aa12c47ff8f#diff-eb4d6a651ba24caf4dd09a5759907caa8599306654fc5cf8d25c695248e565cd |
| grammars/javascript.cson | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/files#diff-eb4d6a651ba24caf4dd09a5759907caa8599306654fc5cf8d25c695248e565cd |
| winstliu | https://patch-diff.githubusercontent.com/winstliu |
| Aug 23, 2016 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#discussion_r75913112 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415 |
| https://patch-diff.githubusercontent.com/winstliu |
| winstliu | https://patch-diff.githubusercontent.com/winstliu |
| Aug 23, 2016 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#issuecomment-241810363 |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415 |
| August 24, 2016 03:34 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#commits-pushed-3b082ef |
| Add missing space and scope-name | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/3b082efe08cc22225e680ae867f729f1627620c9 |
| 3b082ef | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/3b082efe08cc22225e680ae867f729f1627620c9 |
| Remove whitespace in specs | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/70a1a68af70cedf62e2cd0ddcab978cf00b187c9 |
| 70a1a68 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/70a1a68af70cedf62e2cd0ddcab978cf00b187c9 |
| https://patch-diff.githubusercontent.com/Alhadis |
| Alhadis | https://patch-diff.githubusercontent.com/Alhadis |
| Aug 23, 2016 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#issuecomment-241812899 |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415 |
| August 24, 2016 05:16 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#commits-pushed-6145b2d |
| Merge upstream changes into topic branch | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/6145b2dab82304f702bd0933e162a058675e41e9 |
| 6145b2d | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/6145b2dab82304f702bd0933e162a058675e41e9 |
| Update specs to accommodate | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/33fcb714e36a831b8cd343da645d40daec1a557b |
| 3b082ef | https://github.com/atom/language-javascript/commit/3b082efe08cc22225e680ae867f729f1627620c9 |
| 's changes | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/33fcb714e36a831b8cd343da645d40daec1a557b |
| 33fcb71 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/33fcb714e36a831b8cd343da645d40daec1a557b |
| winstliu | https://patch-diff.githubusercontent.com/winstliu |
|
Aug 23, 2016
| https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#discussion-diff-75939075 |
| View reviewed changes
| https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/files/33fcb714e36a831b8cd343da645d40daec1a557b#diff-ad1df1a6fb1e184c8294a94418c0dcba44b84968ae60b819ab60358361d4c8c1 |
| spec/javascript-spec.coffee | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/files#diff-ad1df1a6fb1e184c8294a94418c0dcba44b84968ae60b819ab60358361d4c8c1 |
| winstliu | https://patch-diff.githubusercontent.com/winstliu |
| Aug 23, 2016 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#discussion_r75939075 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415 |
| winstliu | https://patch-diff.githubusercontent.com/winstliu |
|
Aug 23, 2016
| https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#discussion-diff-75939114 |
| View reviewed changes
| https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/files/33fcb714e36a831b8cd343da645d40daec1a557b#diff-ad1df1a6fb1e184c8294a94418c0dcba44b84968ae60b819ab60358361d4c8c1 |
| spec/javascript-spec.coffee | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/files#diff-ad1df1a6fb1e184c8294a94418c0dcba44b84968ae60b819ab60358361d4c8c1 |
| winstliu | https://patch-diff.githubusercontent.com/winstliu |
| Aug 23, 2016 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#discussion_r75939114 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415 |
| Alhadis | https://patch-diff.githubusercontent.com/Alhadis |
| Aug 23, 2016 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#discussion_r75939705 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415 |
| winstliu | https://patch-diff.githubusercontent.com/winstliu |
| Aug 23, 2016 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#discussion_r75960795 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415 |
| winstliu | https://patch-diff.githubusercontent.com/winstliu |
| Aug 23, 2016 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#discussion_r75960836 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415 |
| Alhadis | https://patch-diff.githubusercontent.com/Alhadis |
| Aug 24, 2016 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415#discussion_r75995533 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415 |
| Conform to formatting of existing specs | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/f2871d41f9494479a4d4a93f7ef530485ab599e2 |
| f2871d4 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415/commits/f2871d41f9494479a4d4a93f7ef530485ab599e2 |
| https://patch-diff.githubusercontent.com/winstliu |
| winstliu | https://patch-diff.githubusercontent.com/winstliu |
| 6e22521 | https://patch-diff.githubusercontent.com/atom/language-javascript/commit/6e22521be0a466dc7edaaf97e882145aafab8164 |
| Aug 24, 2016 | https://github.com/atom/language-javascript/pull/415#event-766485498 |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fatom%2Flanguage-javascript%2Fpull%2F415 |
|
needs-review
| https://patch-diff.githubusercontent.com/atom/language-javascript/issues?q=state%3Aopen%20label%3Aneeds-review |
|
Wrong highlighting for constants with dollar sign
| https://github.com/atom/language-javascript/issues/409 |
|
Wrong scope on $this and $default
| https://github.com/atom/language-javascript/issues/344 |
|
Missing scopes on periods
| https://github.com/atom/language-javascript/issues/280 |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415 |
|
| https://patch-diff.githubusercontent.com/Alhadis |
|
| https://patch-diff.githubusercontent.com/MaximSokolov |
|
| https://patch-diff.githubusercontent.com/winstliu |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |